/**
 * A Wordpress plugin that adds a custom post type for placemarks and builds a Google Map with them
 * @package BasicGoogleMapsPlacemarks
 * @author Ian Dunn <ian@iandunn.name>
 * @link http://wordpress.org/extend/plugins/basic-google-maps-placemarks/
 */

 
** New release checklist **
	Update development installations to latest WP version
	Develop on WP single site
	Update alpha version numbers in basic-google-maps-placemarks.php comment and core.php constant
	Update readme compatible tag to latest WP version
	Update readme changelog and upgrade notice
	Update PHP/WP version requirements in basic-google-maps-placemarks.php comment and core.php constant
	Test on WPMS playground
	Test on washingtonhousechurches.net
	Update final version numbers in both places in code
	Update readme stable tag
	Remove any notes from TODO for current release
	Update localizations
		Generate new .pot file and update header values inside it
			cd to wordpress-i18n-tools dir
			php makepot.php wp-plugin ../wp/wp-content/plugins/basic-google-maps-placemarks/
			cp basic-google-maps-placemarks.pot ../wp/wp-content/plugins/basic-google-maps-placemarks/languages/
		Commit to trunk (but don't tag or update readme.txt Stable tag yet)
		E-mail translators links to latest .pot and complete .zip files
		Update French translation yourself until a native speaker takes it over
		Add updated POMO files from translators to local working copy
	Commit to repository with 'Committing [version]' and 'Tagging [version]'
	Download .zip file and test extracting
	Respond to any relevant open forum posts, and mark as resolved where appropriate

	
** Version numbering scheme ** 
	Basic Google Maps Placemarks x.y.z
	x = Major, fundamental changes, possibly breaking backwards compatability. Will probably never do a 2.0 unless WP makes some fundamental change to custom post types, Google releases v4 of the API, or you rewrite the whole plugin from scratch to use better OO patterns
	y = New features or other significant changes. Things that average users would want enough to upgrade.
	z = Bug fixes, minor tweaks, small feature additions

	
** Roadmap **

1.8
	add an unobtrusive, dismissable note promoting re-ablish slavery plugin
		requires 3.3? instead of bumping requirement, just wrap whole thing in "if wp_version > 3.3" block
			don't think it does. wp_screen is new in 3.3, but probalby had other way to do it in past. maybe test on a 3.0 build just to be safe
		
	internatinoalization
		need to escape translated strings?

	changed a lot of stuff around w/ __construct() in both classes, etc, so do some good testing of basic stuff that you assume works b/c it always has
	
	add placemark default icon by category example to readme
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-categories-feature-requests?replies=16#post-2562891
		test it out first
	
	move variable init from __construct() to init hook callback. nothing but action registrations in constuct()
		same for settings class
		done, but need to do testing
		need to call $settings->init() in each unit test function
		make sure $options is defined before networkactivate() runs b/c of the enqueuemessage in there
			hook to 'muplugins_loaded' instead of init? see nordstrom-store-events plugin. if so, copy comment on add_action line over as well.
			but got noticed from nse plugin on WP standalone. default options not set on first install now b/c moved from __construct()?
				NOTICE: wp-content/plugins/nordstrom-store-events/core.php:850 - Undefined index: updates
				NOTICE: wp-content/plugins/nordstrom-store-events/core.php:850 - Undefined index: errors
				no, i think it's just b/c NSE had init fire on mu_loaded, which doesn't run on single wp?
			
	update $bgmp->geocode() references in readme now that it's static?
		but it's not static. i thought i made it static, maybe screwed up source control at some point? maybe look at forums post to remind what happened

	find replacement for 'how to check for javascript errors' link
	
	test on 3.4 release candidates, update compatable tag to latest
	
	admin messages refactoring
		take the <p> tags out of the message view, put them in the $message var instead. because may want to have muliple <p> or <ul>, etc someday
	
	commit rc1, add forums post like 1.7rc1
	email translators
	commit updated pomo files for 
	
	update forums
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-google-logo-is-zoomed-and-ipad-safari-cant-zoom-the-page?replies=4	
	
	
	
1.8.1
	bgmpdata can be output inside shortcode funciton
		this would simplify things a lot, wouldn't have to parse out anymore
		wouldn't have to use filters to insert args with do_shortcode
			updatge readme
		still peek ahead to tell if shortcode called or not, and enqueue functions.js based on that, but don't need to do that for data
	
	enqueuemessage() bug - adds it twice for coordinates error, probably for everything else too
		i think this is because the hook that enqueueMessage() is called from fires multiple times on page load. some times it may even fire AFTER the messages have been printed, so it'll add ones to the next page load
		shouldn't be using hooks that fire multiple times anywya b/c of performance?
			right, but there isn't a practical way around that?
			did_action()
		posts_selection hook fires twice before admin_notices and once after
		
		problem 1 - messages added multiple times before being printed/cleared
			check if emssage already exists and don't enqueue if it does
				might want to add message multiple times, but don't have existing test case for this, so maybe go w/ this until need to do multiple
			
		problem 2 - adding messages after already printed/cleared
			clear them at shutdown() instead of immediately after printing?
				no, b/c then could never add them for the next page
			if being called AFTER admin_notices, then return instead of adding the message?
				is there any way to detect that?
				even if there is, there are valid situations where you want to add message after admin_notices. that's normal, in fact.
		
		did_action checking fixed both problems? look at nordstrom-store-events
			add it to all callback functions, not just saveCustomFields()
		
1.8.2
	add credits section to other notes
		list people who've contributed code, helped out in forums, translators in future
		Ridgididgi - help on forums, link to profile?
		guy who contributed code - check changelog
		
	change all instance of "bgmp_" in FAQ to BasicGoogleMapsPlacemarks::PREFIX ?
		also post type, category, etc
		test out first
			both in theme and functionality plugin that loads before bgmp
	
	change to mpango contact form instead of iandunn for customizations?
		
	use "@deprecated" instead of just "deprecated" or @todo
	
	uninstall script
		take wpms into account
		uninstall settings but not data. note that on the installation page under an 'uninstall' section
		removed the infowindow height and renamed the infowindow width (to maxwidth) option in v1.2.1 or 1.3. remember that you still need to remove from db here

	shouuld be using $this::PREFIX instead of self::PREFIX ?
	
	if( !is_array( $mediaButtons ) || !array_key_exists( 'image', $mediaButtons ) || !$mediaButtons[ 'image' ] )
		have to add check if mediabuttons is an array first. test
		do in networkactivate() and addfeatruedimagesupport()
		
	bgmp add filter for gmaps url so guy can do language=no w/out moding core
		what was forum url? add to list below 

	wpms media buttons have changed now? not on network settings menu anymore?
		if so, update link
		might need to do an -- if( version == x.y ) link = "...", etc
		it was just removed? seems to work w/out it
		
	add nomte to upgrade hook to explian why it's priroty 11 instead of 10
		
		

	
	
1.8.3
	internationalize functions.js
	
	add more machine language translations
	
	automate it - http://www.technomancy.org/language/apertium-auto-translate-gettext/ ?
			also http://djangosnippets.org/snippets/2679/
			http://potranslate.prabhatgupta.com/ - see email
			
			blog about it if it works
			french
			german
			japanese
			russian
			spanish
			
			later
				arabic
				czech
				danish
				dutch
				hebrew
				hindi
				irish
				italian
				korean
				malay
				polish
				portegues
				serbian
				swahili
				thai
				turkish
				ukranian
				vietnamiese
	
1.8.4
	output buffering for shortcode views instead of inline html
	
	inline documentation
		add 3.3 pointers for intro to main things the first time they install
		add inline docu for reference - http://wpdevel.wordpress.com/2011/12/06/help-and-screen-api-changes-in-3-3/
			add pointer to the help tab, since people don't normally think about it. (the way that 'simple facebook connect' does it)
	
	parse shortcodes inside the info window. (would have to parse it before passed to js)
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-including-shortcodes-in-info-box?replies=1#post-2522736
		in getPlacemarks(), just pass $pp->post_content through do_shortcode() ?	
			
	cleanup, refactor stuff?	
		lots of TODOs in code
		
	if( !get_option( self::PREFIX . 'map-width' ) ), etc should be necessary in singleActivate(). add_option() already checks if it exists
		remove and test
		
		
	add other notes section to readme?
		filters
		TODO list and/or feature requests
		locatlizations?
		some faqs that don't belong there?
			leave faqs for troubleshooting-ish things, "other notes" for the rest?
			make note in faqs to see "other notes" and visa-versa
		basic/advanced usage moved from installation to other notes?
		
	check js file for unnecessary $( this ) calls -- http://whattheheadsaid.com/2010/10/utilizing-the-awesome-power-of-jquery-to-access-properties-of-an-element
		
1.8.5
	show map on single placemark page that only shows that individual marker
		add "placemarks" param to bgmp-map shortcode. e.g., [bgmp-map placemarks="13,93,234"]. pass in post ids
		add to list shortcode also?
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-placemark-page-with-just-one-placemarks
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-possibility-to-show-a-single-placemark?replies=1#post-2554004
		
	savecustomfields() should use $postid that was passed in instead of global $post->id ?
	
	ensure filtered varaable data types don't change, like you did for ODCG
		return is_array( $postMeta ) ? $postMeta : array();
	
	add notes on automatic upgrading to installation page
	
	ditch the conditional javascript loading so map arguments and do_shortcode can function like normal?
		give user option to turn off scripts except for a whitelisted list of pages or something?
		
	refactor bgmp/settings classes?
		http://stackoverflow.com/questions/8688738/wordpress-plugin-how-do-i-avoid-tight-coupling
		but bgmp needs to be defined before settings? maybe pass bgmp to settings rather than other way around, like it's doing now
		or just make static accessor/gettor functions in bgmp class?
	
	use wp trac for feature requests and bugs, and forums only for support?
	
	add note to insatll page for multisite. tell them it can be network-activated, or activated only on dividual sites. both will work
	
	refactor geocode() error checking into multiple functions, like nordlocal remoteGetSuccessful()
	
	
	
1.minor
	infowinder not rounded anymore?
		b/c of image styles? try turning off stylesheet and see what happens
		no, b/c google changed it -- http://stackoverflow.com/questions/6570490/modern-rectangular-infowindow-on-maps-google-com
		can use infobubble, but that's a bunch of overhead for something small?
	
	close infobox when click anywhere outside infobox
		$(map).click( function()
		{
			if( not inside current placemark box)
				close current placemark;
		} );

	add column on View page for category, address, icon
		
		
	better style options
		turn default stylesheet on/off
		enter URL for custom stylesheet
		have textbox to enter styles directly? (don't like this b/c have to print inline)
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-set-the-default-info-window-font-style-in-the-configuration-page?replies=1#post-2679560
		
2.0
	rewrite as MVC and better OO?
		look at mir-trips plugin (or whatever latest incarnation) to see how you're doing it now
		break core.php up into smaller files for each class
			core, geocode, etc
		all the models should be unit-testable
		controllers should be?
		http://wordpress.tv/2010/04/24/blair-williams-wordpress-plugins-oc10/
		look at http://wordpress.org/extend/plugins/wp-mvc/, http://wordpress.org/extend/plugins/tina-mvc/, Churro: @ wordpress.org extend /plugins /churro [not to use, just to get ideas]
		http://www.jessehanson.com/2011/01/02/mvc-based-wordpress-plugins/
		do other research
		
2.0.minor
	finish setting up unit testing
		add to 'before each new release' list
			add new unit tests for any new/modified code
			run unit tests
		php - simpletest plugin?
			maybe need to refactor everything so methods are more testable. break into controller and model. models should take input, do shit, and return. that's testable. the two mixed together isn't testable.
			add unit tests for all functions
			add integration tests for all functions (in separate file)
		js
			fireunit? kinda old, but most of the newer ones seem to require eclipse or something else
			http://www.slideshare.net/aaronjorbin/dont-repeat-your-mistakes-javascript-unit-testing
				look for wordpress.tv video of it from wrdcamp sf 2011
		
		maybe make this 2.0 if you need to rewrite everything to be more MVC and testable. probably not worth the effort, unless you just want to do it to learn
			could abstract out the hooks, api interaction etc in the constructors, and have the models all accept/return variables so they'd be testable. supposed to test controllers instead of models, though?

	
1.major.x
	change localize_script() to wp_add_script_data when that's added 
		may not need to manually json_encode() once you do this. it might do it for you
		wp 3.3 localize_script supports arrays now, so don't need separate map and marker variables in js? can just output a single bgmpdata array?
	
	switch to wp_add_script_before if it comes out in wp 3.4. wait until 3.5 is out, though, to give people time to upgrade.
	
1.major.x
	switch to using add_meta_boxes_{$page} hook
		http://wpdevel.wordpress.com/2011/12/07/do-not-include-wp-adminincludestemplate-php-to-get-add_meta_box/

1.major.x
	
	add current_user_can() in places -- http://wordpress.tv/2011/09/07/mark-jaquith-jon-cave-brad-williams-plugin-security-showdown/ 11:30
	
	map covers dropdowns bug
		http://wordpress.org/support/topic/google-map-covering-dropdown-menus?replies=2#post-2300994
		http://stackoverflow.com/questions/506984/how-can-i-place-a-html-div-over-the-google-earth-plugin-involves-wmode-i-imagin
		https://www.google.com/accounts/ServiceLogin?service=groups2&continue=http://groups.google.com/group/google-earth-browser-plugin/browse_thread/thread/dc38137e4b816837%26followup%3Dhttp://groups.google.com/group/google-earth-browser-plugin/browse_thread/thread/dc38137e4b816837&followup=http://groups.google.com/group/google-earth-browser-plugin/browse_thread/thread/dc38137e4b816837%26followup%3Dhttp://groups.google.com/group/google-earth-browser-plugin/browse_thread/thread/dc38137e4b816837
		http://earth-api-samples.googlecode.com/svn/trunk/demos/customcontrols/index.html
		http://code.google.com/p/earth-api-samples/issues/detail?id=9&colspec=ID%20
		http://maps.myosotissp.com/demos/popups.html
	
	can't call enqueueMessage() in settings.php - http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-that-address-couldnt-be-geocoded-fatal-error?replies=5
		fixed w/ temp workaround, but need better solution
		just make enqueuemssage public?
	
	
1.major.x
	run tests on memory consumption, etc. see if you can find any areas of code that would significantly benefit from optimization
		ask for advice on wordpress answers for tips on how to test
	
	wahc doesn't work as demo anymore since not current version. setup wpms playground blog as new demo, populate w/ sample content. update link in readme. make sure to update w/ new releases (add to list above). don't use to test, only as pristine demo.

	redo enqueuemessage,etc to use WP_Error objects instead of just strings?
		but what about for normal messages?

	look for all @todo comments in code, and move them here. clean them up before moving on to next 1.major version

	update readme filter examples w/ http://wpengineer.com/2319/advent-calendar-predefined-callback-functions-for-filters/
			

1.major.minor
	add icon next to name in list shortcode
	add option to disable info windows
	lant/long shouldn't be disabled input fields, should just be regular text. some people will think they should be able to edit it.

1.major
	add hooks/filters
		filters done in core, but not documented. need to escape?
		document their usage in readme.
		do this instead of options? in addition to?
		don't forget settings.php, views, etc. probably shouldn't be any in views, only in models/controllers
	try to detect if theme is loading google maps api, and then don't do it?
		e.g., http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-broken-map-with-dk-template?replies=1#post-2522633
		
1.major.minor
	do shortcode bit only works with 'front page setting', not straight home.php template
		Home.php would have to setup a custom $post variable with query_posts() or WP_Query() in order to access the content, but there's no way to pass that version of $post to the shortcode check function.
		maybe add a second array where you can defined template file names (e.g., home.php, map.php, etc) instead-of/in-addition-to post slugs
			http://wordpress.stackexchange.com/questions/10537/get-name-of-the-current-template-file
		maybe make a static function they can call that will just pass a single array w/ slugs? instead of them having to setup shit in the theme's functions.php?
		is_home() helpful?
		update faq
	maybe look at encoding the content w/ some reversible algorithm so that email addresses aren't exposed in $bgmpData
		would have to add an option to turn on/off?
	wp 3.3 could affect js handling
		http://core.trac.wordpress.org/ticket/11520
	maybe break messages and describe into Toolbelt class
		give it it's own name not related to bgmp, a version number toos

		
1.major.minor
	http://code.google.com/p/gmaps-api-issues/issues/detail?id=1724 workaround
		didn't work. file a new bug report for the issue. setup a test page
		when fixed, remove the override styles.
	errors shouldn't overwrite the map unless the map can't be loaded anyway
		map may load fine, but then error with placemarks. don't want to kill map just b/c placemark didn't load.
		log to console instead
			only if a ?bgmp_debug parameter is passed in, so you don't clutter the console 
		also add error to page. create a new empty <p> under map for messages
		create a bgmp.log() that's a wrapper for if(window.console) console.log
	width px and % -- http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-how-to-tweak-the-code-to-get-width-instead-of-fixed-px?replies=4#post-2242249
		test to make sure it can work as he described across browsers. if so, probalby just leave as is and update docs to let people know
	describe()
		add 'transient' as option
			set_transient( self::PREFIX .'consturct', 'blah', 60 );
		add 'echo' behavior, and return another option
			already copy/pasted, but need to test
		make it a switch instead of if else ifelse
		
1.major.minor
	loadresources isn't specifiying a version number for the maps api. if they switch to v4 i don't want to plugin to automatically do it
		see if you can specify v3
	enqueuemessage should let it can be converted to string
		if it has a __toString() function
			does that cover types like int, or have to list them manually?
			http://www.php.net/manual/en/language.oop5.magic.php#language.oop5.magic.tostring
		maybe hve it enqueue an error instead of returning false, since not really gonna check if it returns true
	test to make sure wp action actually is working for essages. i don't think it runs on edit-page, so wouldn't get notice of geocode error
		check out wp_enqueue_scripts
		if works, update wpse question. also add it and admin_enqueue_scripts to codex list in the appropriate order
	
1.major.minor
	double check that everything is sanitized
	give everything a once over, check comments, empty phpdoc lines, etc
	stat bug is back - http://wordpress.stackexchange.com/questions/21132/repository-reporting-incorrect-plugin-active-version-stat
		http://phpdoc.wordpress.org/trunk/WordPress/Administration/_wp-admin---includes---plugin.php.html#functionget_plugin_data
	admin_notices
		target
			http://core.trac.wordpress.org/ticket/14696
			have to go through each message and deterine who it should go to
			this will bump required version up to 3.1
				reember to update readme and environment check
			might want to use is_user_admin() when setting or displaying
		error in addFeaturedImageSupport being added multiple times
			maybe b/c sitting on page and auto-save adds one?
			could not call enqueue if auto-save inside addFeaturedImageSupport, but probably better to check if message already enqueues inside enqueueMessage()
			might be fixed by 'target' task, but probably not
	add option to disable the 'image media button disabled' warning. would have to be site-wide option?
		update error message to let them know they can disable it
	organize FAQ page into sections?
	
	
1.major.minor
	add px units to $('#bgmp_map-canvas').css('width', response.width ); etc ?
		probably, just need to test
		check the rest of the file for other places
	add support forum link to plugin page
	
1.major
	remove the 'upgrade to 1.0 addresses' activation bit - no longer needed for most users
	mobile support
	mobile placemark bug
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-i-cant-see-the-placemark-on-my-mobile-phone?replies=1#post-2201681
		read through code, try to think of what may cause it
		try googling for answer	
		
1.major.minor
	look into http://docs.jquery.com/Plugins/Authoring to see if you should do things that way
		
	
1.major.major
	some things may only need to run on the admin side, or only on the front end. check for that and handle appropriatly
		keep in mind http:codex.wordpress.org/AJAX_in_Plugins note 3 about being inside is_admin()
	custom icon for placemarks menu. maybe a pinpoint? (similar to default google maps icon, but not exact same b/c of copyright)
	
	
	
** Feature Requests **
	8 - javascript to toggle categories on map dynamically
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-turn-onoff-category-display?replies=1#post-2760224
		http://templatic.com/demos/?theme=geoplaces4
		a bunch of others
	6 - have links in [bgmp-list] open repsective info on map. 
		would also be nice if arbitary links could do the same (e.g., links generated by the user, not bgmp)
		would have to have a settings to flag whether or not it's active, so that the list could still be independent of the map
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-place-marker-links?replies=1#post-2554607
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-onclick-from-external-link?replies=1
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-categories-feature-requests?replies=13#post-2558220
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-several-questions-about-categories-and-links?replies=1
	3 - marker clustering
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-using-markerclusterer-with-bgmp-plugin?replies=2
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-many-markers-behavior?replies=1#post-2778964
	3 - instead of setting icon on placemark, you could set it on taxonomy. looks for in order: placemark icon > category icon > default icon
	3 - geolocate ip and use as addr for placemark
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-automatic-location?replies=1#post-2566677
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-iphone-and-ipad-layout?replies=4
			related to above: http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-iphone-map-broken?replies=1
	2 - set width as % in addition to px
			check that google api allows that
			this may be working in 1.3 already, check notes for 1.3.2 or 1.3.3 for testing info
	2 - directions (and other options that google includes in their implementaiton? e.g., 'zoom here'?
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-directions?replies=2#post-2494522
		one other?
	2 - option to have placemark info window open when map loads.
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-placemark-show-by-default?replies=3#post-2519181	
		at least 1 other?
	1 - separate role for placemarks, so users can add placemarks but not regular posts
	1 - user supplied text for map link on list shortcode
		filter exists already, but not easy to use
	1 - option to disable info windows
	2 - zip code search to display placemarks near a given zip code. could also have a shortcode option to display them
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-look-up-closest-store-and-route?replies=2
	1 - search only placemarks
	1 - shortcode argument for post id, then only display that post on the map
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-possibility-to-show-a-single-placemark?replies=1
	1 - configuration option to upload/link to new default marker, instead of having to use filter
		http://wordpress.org/support/topic/plugin-basic-google-maps-placemarks-upload-placemark-logo-in-configuration-page?replies=1#post-2679597
	
	
** Future considerations **
	list shortcode sorting
		order by alphabetical - this already posible b/c of filter?
		order posts by latitude, zip code or something meaningful. distance from map center?
			api does return city/county/etc data
		option to choose which method used (most recent, alphabetical, distance/location)
	map won't load if theme doesn't call wp_footer(). add check to make sure theme is doing that. display error if it isn't.
	look into having a capability so users can control what other users can add them?
	add ? icon next to address field and move the 'you can type in blah blah' bit there