From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 8 Dec 2020 19:55:41 -0800 Subject: Remove MakeExternal case for uncached internal strings https://chromium-review.googlesource.com/c/v8/v8/+/2565511 V8 removed a case where we can make an uncached internal string through MakeExternal - to fix this we make the strings bigger so as to make then internal & external & not uncached (i.e. cached). diff --git a/test/parallel/test-fs-write.js b/test/parallel/test-fs-write.js index bdee397eb58dd2e5ca59dc1ec280e9e664ba23f9..c52c958a1fd1a5679f731a1360b0563d13fa7581 100644 --- a/test/parallel/test-fs-write.js +++ b/test/parallel/test-fs-write.js @@ -40,7 +40,7 @@ const constants = fs.constants; common.allowGlobals(externalizeString, isOneByteString, x); { - const expected = 'ümlaut eins'; // Must be a unique string. + const expected = 'ümlaut sechzig'; // Must be a unique string. externalizeString(expected); assert.strictEqual(isOneByteString(expected), true); const fd = fs.openSync(fn, 'w'); @@ -50,7 +50,7 @@ common.allowGlobals(externalizeString, isOneByteString, x); } { - const expected = 'ümlaut zwei'; // Must be a unique string. + const expected = 'ümlaut neunzig'; // Must be a unique string. externalizeString(expected); assert.strictEqual(isOneByteString(expected), true); const fd = fs.openSync(fn, 'w'); @@ -60,7 +60,7 @@ common.allowGlobals(externalizeString, isOneByteString, x); } { - const expected = '中文 1'; // Must be a unique string. + const expected = 'Zhōngwén 1'; // Must be a unique string. externalizeString(expected); assert.strictEqual(isOneByteString(expected), false); const fd = fs.openSync(fn, 'w'); @@ -70,7 +70,7 @@ common.allowGlobals(externalizeString, isOneByteString, x); } { - const expected = '中文 2'; // Must be a unique string. + const expected = 'Zhōngwén 2'; // Must be a unique string. externalizeString(expected); assert.strictEqual(isOneByteString(expected), false); const fd = fs.openSync(fn, 'w');