From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 5 May 2020 12:36:39 -0700 Subject: breakpad: allow getting string values for crash keys Linux is currently recording both crashpad and breakpad keys on linux (because upstream is experimenting with crashpad-on-linux). We can fetch the string values for crashpad keys on win/mac, and they're easily available on linux too, this just exposes them. Should be upstreamed, or failing that, deleted once crashpad is enabled on linux. If removing this patch doesn't cause a compile failure, it's fine to delete! diff --git a/components/crash/core/common/crash_key.h b/components/crash/core/common/crash_key.h index 9d193ea962e919d4509eef296c900e47059761f4..225b8ce822a42d31d59bc89aab473710384c3010 100644 --- a/components/crash/core/common/crash_key.h +++ b/components/crash/core/common/crash_key.h @@ -212,6 +212,10 @@ class CrashKeyStringCombined : public internal::CrashKeyStringCombinedImpl { crashpad_key_.Set(value); } + const base::StringPiece value() const { + return crashpad_key_.value(); + } + private: CrashKeyStringBreakpad breakpad_key_; crashpad::StringAnnotation crashpad_key_;