#!/usr/bin/env bash
# install_aris.sh — Project-local ARIS skill installation (flat per-skill symlinks).
#
# Each ARIS skill is symlinked into `<project>/.claude/skills/<skill-name>` so
# Claude Code's slash-command discovery (which only scans one level deep) finds it.
# A versioned manifest at `<project>/.aris/installed-skills.txt` tracks every
# entry this installer created — uninstall and reconcile read from the manifest
# and never touch user-owned skills with the same name.
#
# Usage:
#   bash tools/install_aris.sh [project_path] [options]
#
# Actions (mutually exclusive, default: auto):
#   default          install if no manifest, else reconcile
#   --reconcile      explicit reconcile; refuse if no manifest
#   --uninstall      remove only entries in manifest; delete manifest
#
# Selection (catalog: tools/skill-groups.tsv):
#   --groups A,B           install only these skill groups (see --list-groups)
#   --skills X,Y           additionally install these skills (clears declined mark)
#   --exclude X,Y          never install these skills (recorded as declined)
#   --all                  install every upstream skill (legacy default)
#   --add-new              reconcile: accept all upstream skills not yet installed
#   --skip-new             reconcile: skip new upstream skills without prompting
#   --list-groups          print the group catalog and exit
#   With no selection flags: fresh install on a TTY opens a full-screen
#   checkbox picker (Space toggles a skill / a whole group, Enter confirms;
#   ARIS_NO_PICKER=1 or missing python3/curses falls back to per-group
#   Y/n/e prompts); fresh install with --quiet/no TTY installs everything (old behavior).
#   Reconcile keeps exactly what the manifest says is installed; NEW upstream
#   skills need per-skill confirmation (declined ones are remembered in
#   .aris/skills-declined.txt and never re-asked).
#
# Options:
#   --aris-repo PATH       override aris-repo discovery
#   --dry-run              show plan, no writes
#   --quiet                no prompts; abort on any condition that would prompt
#   --no-doc               skip CLAUDE.md update
#   --adopt-existing NAME  adopt a non-managed symlink that already points to
#                          the correct upstream target (repeatable)
#   --replace-link NAME    replace an upstream-internal symlink that points to
#                          a DIFFERENT entry than expected (repeatable)
#   --platform PLATFORM    force platform: codex or claude (default: auto-detect)
#   --from-old             trigger migration from legacy nested install
#                          (.claude/skills/aris/)
#   --migrate-copy STRAT   for legacy COPY install: STRAT = keep-user | prefer-upstream
#                          (default: refuse)
#   --clear-stale-lock     remove stale lock dir from a crashed prior run
#                          (host+PID metadata is verified before removal)
#   --no-agent-profiles    never put Copilot reviewer profiles into the
#                          project's .github/agents/ (remembered in .aris/;
#                          undo with --agent-profiles). Without either flag
#                          the profiles are deployed only while
#                          auto-review-loop is installed.
#
# Safety rules enforced:
#   S1  Never delete a path that is not a symlink.
#   S2  Never delete a symlink whose target is outside the configured aris-repo.
#   S3  Never delete a symlink not listed in the manifest (except via --uninstall
#       which only deletes manifest entries).
#   S4  Never overwrite an existing path during CREATE — abort by default.
#   S5  Manifest write is atomic (temp + rename in same dir).
#   S6  Concurrent runs in same project serialize via mkdir lockdir.
#   S7  Crash mid-apply leaves the previous manifest intact; rerun adopts.
#   S8  Uninstall revalidates each managed symlink's target before removing.
#   S9  If .aris/, .claude/, or .claude/skills/ is itself a symlink, abort.
#   S10 Reject upstream entries that are symlinks to outside aris-repo.
#   S11 Revalidate exact target match (lstat + readlink) before every mutation.
#   S12 The optional `.aris/tools` symlink (added in #174) is the only managed
#       artifact NOT tracked in the manifest. It is identified at uninstall
#       time by exact target match against `<aris-repo>/tools`. Any other
#       path or differently-targeted symlink at `.aris/tools` is left alone.
#   S12 Temp files live in the same directory as the destination.
#   S13 Skill names must match ^[A-Za-z0-9][A-Za-z0-9._-]*$ (slug regex).
#   S14 Copilot agent links are removed only when listed in the dedicated
#       installed-agent-profiles.txt ownership sidecar.

set -euo pipefail

# ─── Constants ────────────────────────────────────────────────────────────────
MANIFEST_VERSION="1"
MANIFEST_NAME="installed-skills.txt"
MANIFEST_PREV_NAME="installed-skills.txt.prev"
AGENT_MANIFEST_NAME="installed-agent-profiles.txt"
DECLINED_NAME="skills-declined.txt"
CATALOG_REL="tools/skill-groups.tsv"
GLOBAL_POINTER="$HOME/.aris/repo"
ARIS_DIR_NAME=".aris"
LOCK_DIR_NAME=".install.lock.d"
SKILLS_REL=".claude/skills"
DOC_FILE_NAME="CLAUDE.md"
BLOCK_BEGIN="<!-- ARIS:BEGIN -->"
BLOCK_END="<!-- ARIS:END -->"
SAFE_NAME_REGEX='^[A-Za-z0-9][A-Za-z0-9._-]*$'
SUPPORT_NAMES=("shared-references")
AGENT_PROFILES_SRC=".github/agents"  # Copilot agent profiles deployed alongside skills (F5)
AGENT_PROFILES_OPT_OUT_NAME="agent-profiles-opt-out"  # #431: remembered --no-agent-profiles
AGENT_PROFILES_FLAG=""  # "off" (--no-agent-profiles) | "on" (--agent-profiles) | "" (remembered choice)
EXCLUDE_TOP_NAMES=("skills-codex" "skills-codex.bak")  # not skills, not symlinked

# ─── Argument parsing ─────────────────────────────────────────────────────────
PROJECT_PATH=""
ARIS_REPO_OVERRIDE=""
ACTION="auto"        # auto | reconcile | uninstall
DRY_RUN=false
QUIET=false
NO_DOC=false
FROM_OLD=false
MIGRATE_COPY=""      # "" | keep-user | prefer-upstream
CLEAR_STALE_LOCK=false
ADOPT_NAMES=()
REPLACE_LINK_NAMES=()
SELECT_GROUPS=""     # comma list from --groups
SELECT_SKILLS=""     # comma list from --skills
EXCLUDE_SKILLS=""    # comma list from --exclude
SELECT_ALL=false
NEW_POLICY=""        # "" (prompt) | add | skip
LIST_GROUPS=false

usage() { sed -n '2,69p' "$0" | sed 's/^# \?//'; }

FORWARDED_ARGS=()
PLATFORM_OVERRIDE=""
DETECTED_PLATFORM=""
CLAUDE_ONLY_FLAGS_USED=()
CODEX_ONLY_FLAGS_SEEN=()

# ─── Platform auto-detection for Codex CLI (#180) ──────────────────────────────
# If the project has Codex markers (.agents/, AGENTS.md, .codex/config.toml)
# and NO Claude markers (.claude/, CLAUDE.md), delegate to install_aris_codex.sh.
auto_detect_platform() {
    local proj="$1"
    local has_strong_codex_markers=false
    local has_codex_hint=false
    local has_claude_markers=false

    # Strong Codex markers. AGENTS.md by itself is only a hint because many Claude
    # projects may carry repo-level agent instructions before .claude/ exists.
    [[ -d "$proj/.agents" || -f "$proj/.codex/config.toml" ]] && has_strong_codex_markers=true
    [[ -f "$proj/AGENTS.md" ]] && has_codex_hint=true

    # Claude markers
    [[ -d "$proj/.claude" || -f "$proj/CLAUDE.md" || -f "$proj/.claude/settings.json" ]] && has_claude_markers=true

    if $has_strong_codex_markers && $has_claude_markers; then
        warn "Both Claude and Codex markers found in $proj"
        warn "  Defaulting to claude; use --platform codex to override."
        DETECTED_PLATFORM="claude"
    elif $has_strong_codex_markers && ! $has_claude_markers; then
        DETECTED_PLATFORM="codex"
    elif $has_claude_markers; then
        DETECTED_PLATFORM="claude"
    elif $has_codex_hint; then
        warn "AGENTS.md found without .agents/ or .codex/config.toml; defaulting to claude."
        warn "  Use --platform codex to delegate to install_aris_codex.sh."
    fi
}

while [[ $# -gt 0 ]]; do
    case "$1" in
        --reconcile)         FORWARDED_ARGS+=("$1"); ACTION="reconcile"; shift ;;
        --uninstall)         FORWARDED_ARGS+=("$1"); ACTION="uninstall"; shift ;;
        --aris-repo)         FORWARDED_ARGS+=("$1" "${2:?--aris-repo requires path}"); ARIS_REPO_OVERRIDE="$2"; shift 2 ;;
        --dry-run)           FORWARDED_ARGS+=("$1"); DRY_RUN=true; shift ;;
        --quiet)             FORWARDED_ARGS+=("$1"); QUIET=true; shift ;;
        --no-doc)            FORWARDED_ARGS+=("$1"); NO_DOC=true; shift ;;
        --from-old)          FORWARDED_ARGS+=("$1"); FROM_OLD=true; CLAUDE_ONLY_FLAGS_USED+=("--from-old"); shift ;;
        --migrate-copy)      FORWARDED_ARGS+=("$1" "${2:?--migrate-copy requires keep-user|prefer-upstream}"); MIGRATE_COPY="$2"; CLAUDE_ONLY_FLAGS_USED+=("--migrate-copy"); shift 2 ;;
        --clear-stale-lock)  FORWARDED_ARGS+=("$1"); CLEAR_STALE_LOCK=true; shift ;;
        --no-agent-profiles) FORWARDED_ARGS+=("$1"); AGENT_PROFILES_FLAG="off"; CLAUDE_ONLY_FLAGS_USED+=("--no-agent-profiles"); shift ;;
        --agent-profiles)    FORWARDED_ARGS+=("$1"); AGENT_PROFILES_FLAG="on"; CLAUDE_ONLY_FLAGS_USED+=("--agent-profiles"); shift ;;
        --adopt-existing)    FORWARDED_ARGS+=("$1" "${2:?--adopt-existing requires NAME}"); ADOPT_NAMES+=("$2"); CLAUDE_ONLY_FLAGS_USED+=("--adopt-existing"); shift 2 ;;
        --replace-link)      FORWARDED_ARGS+=("$1" "${2:?--replace-link requires NAME}"); REPLACE_LINK_NAMES+=("$2"); shift 2 ;;
        --groups)            FORWARDED_ARGS+=("$1" "${2:?--groups requires A,B,...}"); SELECT_GROUPS="${SELECT_GROUPS:+$SELECT_GROUPS,}$2"; shift 2 ;;
        --skills)            FORWARDED_ARGS+=("$1" "${2:?--skills requires X,Y,...}"); SELECT_SKILLS="${SELECT_SKILLS:+$SELECT_SKILLS,}$2"; shift 2 ;;
        --exclude)           FORWARDED_ARGS+=("$1" "${2:?--exclude requires X,Y,...}"); EXCLUDE_SKILLS="${EXCLUDE_SKILLS:+$EXCLUDE_SKILLS,}$2"; shift 2 ;;
        --all)               FORWARDED_ARGS+=("$1"); SELECT_ALL=true; shift ;;
        --add-new)           FORWARDED_ARGS+=("$1"); NEW_POLICY="add"; shift ;;
        --skip-new)          FORWARDED_ARGS+=("$1"); NEW_POLICY="skip"; shift ;;
        --list-groups)       FORWARDED_ARGS+=("$1"); LIST_GROUPS=true; shift ;;
        --platform)
            PLATFORM_OVERRIDE="${2:?--platform requires codex|claude}"; shift 2 ;;
        --force)
            echo "Error: --force is removed. Use the granular flags:" >&2
            echo "       --adopt-existing NAME (for non-managed symlinks pointing to correct upstream)" >&2
            echo "       --replace-link NAME (for managed symlinks pointing to different upstream entry)" >&2
            echo "       Real files/directories are never overwritten — back up and remove them yourself." >&2
            exit 2 ;;
        -h|--help)           usage; exit 0 ;;
        # Codex-only flags: recognized by parent, forwarded during delegation
        --with-claude-review-overlay) FORWARDED_ARGS+=("$1"); CODEX_ONLY_FLAGS_SEEN+=("$1"); shift ;;
        --with-gemini-review-overlay) FORWARDED_ARGS+=("$1"); CODEX_ONLY_FLAGS_SEEN+=("$1"); shift ;;
        --*)                 echo "Unknown option: $1" >&2; exit 2 ;;
        *)
            if [[ -z "$PROJECT_PATH" ]]; then PROJECT_PATH="$1"
            else echo "Error: unexpected positional: $1" >&2; exit 2; fi
            FORWARDED_ARGS+=("$1"); shift ;;
    esac
done

if [[ -n "$MIGRATE_COPY" && "$MIGRATE_COPY" != "keep-user" && "$MIGRATE_COPY" != "prefer-upstream" ]]; then
    echo "Error: --migrate-copy must be keep-user or prefer-upstream (got: $MIGRATE_COPY)" >&2; exit 2
fi
if [[ -n "$PLATFORM_OVERRIDE" && "$PLATFORM_OVERRIDE" != "codex" && "$PLATFORM_OVERRIDE" != "claude" ]]; then
    echo "Error: --platform must be codex or claude (got: $PLATFORM_OVERRIDE)" >&2; exit 2
fi
if $SELECT_ALL && [[ -n "$SELECT_GROUPS$SELECT_SKILLS" ]]; then
    echo "Error: --all cannot be combined with --groups/--skills (only --exclude)" >&2; exit 2
fi

# ─── Helpers ──────────────────────────────────────────────────────────────────
log()      { $QUIET && return 0; echo "$@"; }
warn()     { echo "warning: $*" >&2; }
die()      { echo "error: $*" >&2; exit 1; }
prompt()   { $QUIET && return 1; printf "%s " "$1" >&2; read -r REPLY; [[ "$REPLY" =~ ^[Yy]$ ]]; }
abs_path() { ( cd "$1" 2>/dev/null && pwd ) || return 1; }

is_safe_name() { [[ "$1" =~ $SAFE_NAME_REGEX ]]; }

# Read symlink target without following further (one hop)
read_link_target() {
    if command -v greadlink >/dev/null 2>&1; then greadlink "$1"
    else readlink "$1"; fi
}

# Resolve a path, following all symlinks, to a canonical absolute path
canonicalize() {
    if command -v greadlink >/dev/null 2>&1; then greadlink -f "$1" 2>/dev/null || true
    elif readlink -f "$1" 2>/dev/null; then :
    else
        # macOS fallback: cd + pwd
        local d f
        if [[ -d "$1" ]]; then ( cd "$1" && pwd )
        else d="$(dirname "$1")"; f="$(basename "$1")"; ( cd "$d" 2>/dev/null && echo "$(pwd)/$f" )
        fi
    fi
}

# True if $1 is a symlink (lstat-style; doesn't follow)
is_symlink() { [[ -L "$1" ]]; }

# Find aris-repo location
resolve_aris_repo() {
    local p
    if [[ -n "$ARIS_REPO_OVERRIDE" ]]; then
        p="$(abs_path "$ARIS_REPO_OVERRIDE")" || die "--aris-repo path not found: $ARIS_REPO_OVERRIDE"
        [[ -d "$p/skills" ]] || die "--aris-repo has no skills/ subdir: $p"
        echo "$p"; return
    fi
    local script_dir parent
    script_dir="$(cd "$(dirname "$0")" && pwd)"
    parent="$(cd "$script_dir/.." && pwd)"
    if [[ -d "$parent/skills" ]]; then echo "$parent"; return; fi
    if [[ -n "${ARIS_REPO:-}" && -d "$ARIS_REPO/skills" ]]; then abs_path "$ARIS_REPO"; return; fi
    for guess in \
        "$HOME/Desktop/aris_repo" \
        "$HOME/aris_repo" \
        "$HOME/.aris" \
        "$HOME/Desktop/Auto-claude-code-research-in-sleep" \
        "$HOME/.codex/Auto-claude-code-research-in-sleep" \
        "$HOME/.claude/Auto-claude-code-research-in-sleep" ; do
        [[ -d "$guess/skills" ]] && { abs_path "$guess"; return; }
    done
    die "cannot find ARIS repo. Use --aris-repo PATH or set ARIS_REPO env var."
}

# Build the upstream inventory: array of "kind|name" entries
# Skills = top-level dirs in <aris-repo>/skills/ containing SKILL.md
# Support = explicitly listed support directories (shared-references)
# Rejects: anything in EXCLUDE_TOP_NAMES, names failing slug regex, symlinks to outside aris-repo (S10)
build_upstream_inventory() {
    local repo="$1"
    local skills_dir="$repo/skills"
    local entries=() name kind src
    # skills (with SKILL.md)
    for d in "$skills_dir"/*/; do
        name="$(basename "$d")"
        is_safe_name "$name" || { warn "skipping unsafe upstream name: $name"; continue; }
        # exclude listed
        for ex in "${EXCLUDE_TOP_NAMES[@]}"; do [[ "$name" == "$ex" ]] && continue 2; done
        # support entries handled separately
        local is_support=false
        for s in "${SUPPORT_NAMES[@]}"; do [[ "$name" == "$s" ]] && { is_support=true; break; }; done
        if $is_support; then continue; fi
        if [[ ! -f "$d/SKILL.md" ]]; then continue; fi
        # S10: source must not be a symlink leading outside the repo
        src="$skills_dir/$name"
        if is_symlink "$src"; then
            local resolved; resolved="$(canonicalize "$src")"
            [[ "$resolved" == "$repo"/* ]] || { warn "skipping upstream symlink leading outside repo: $name -> $resolved"; continue; }
        fi
        entries+=("skill|$name")
    done
    # support directories (existing only)
    for s in "${SUPPORT_NAMES[@]}"; do
        if [[ -d "$skills_dir/$s" ]]; then entries+=("support|$s"); fi
    done
    # bash 3.2: empty-array "${ARR[@]}" trips `set -u`; an upstream with no valid
    # entries should yield empty output so the caller's own diagnostic fires.
    if [[ ${#entries[@]} -gt 0 ]]; then
        printf "%s\n" "${entries[@]}"
    fi
}

# ─── Selective install (#366) ─────────────────────────────────────────────────
# Catalog = tools/skill-groups.tsv in the aris-repo. Two record types:
#   group\t<id>\t<display>\t<description>
#   skill\t<name>\t<group-id>\t<requires: comma list or "-">
# Selection state lives in two project files:
#   .aris/installed-skills.txt  — what IS installed (existing manifest)
#   .aris/skills-declined.txt   — skills the user explicitly said no to;
#                                 never re-prompted on reconcile.
# "Skipped" (via --skip-new / --quiet) is NOT declined — those skills are
# asked about again on the next interactive reconcile.

catalog_ok() { [[ -n "${CATALOG_PATH:-}" && -f "$CATALOG_PATH" ]]; }
catalog_groups() { awk -F'\t' '$1=="group"{print $2 "\t" $3 "\t" $4}' "$CATALOG_PATH"; }
catalog_group_of() { awk -F'\t' -v s="$1" '$1=="skill" && $2==s {print $3; exit}' "$CATALOG_PATH"; }
catalog_desc_of() { awk -F'\t' -v s="$1" '$1=="skill" && $2==s {print (NF>=5?$5:""); exit}' "$CATALOG_PATH"; }
catalog_group_display() { awk -F'\t' -v g="$1" '$1=="group" && $2==g {print $3; exit}' "$CATALOG_PATH"; }
catalog_requires() { awk -F'\t' -v s="$1" '$1=="skill" && $2==s && $4!="-" {print $4; exit}' "$CATALOG_PATH" | tr ',' '\n'; }
catalog_skills_in_group() { awk -F'\t' -v g="$1" '$1=="skill" && $3==g {print $2}' "$CATALOG_PATH"; }
catalog_has_skill() { awk -F'\t' -v s="$1" '$1=="skill" && $2==s {found=1; exit} END{exit !found}' "$CATALOG_PATH"; }

in_file() { grep -qxF "$1" "$2" 2>/dev/null; }
upstream_has_skill() { grep -q "^skill|$1\$" "$2"; }

print_group_catalog() {
    catalog_ok || die "skill catalog not found: ${CATALOG_PATH:-<unset>}"
    echo "Skill groups (from $CATALOG_PATH):"
    local gid display desc n
    while IFS=$'\t' read -r gid display desc; do
        n=$(catalog_skills_in_group "$gid" | wc -l | tr -d ' ')
        printf "\n  %-14s %s — %s  [%s skills]\n" "$gid" "$display" "$desc" "$n"
        awk -F'\t' -v g="$gid" '$1=="skill" && $3==g {printf "      %-28s %s\n", $2, (NF>=5?$5:"")}' "$CATALOG_PATH"
    done < <(catalog_groups)
}

load_declined() {  # $1 = out file
    : > "$1"
    [[ -f "$DECLINED_PATH" ]] || return 0
    grep -v '^[[:space:]]*$' "$DECLINED_PATH" >> "$1" || true
}

# Final declined set = (old declined ∪ new declines ∪ excludes ∪ fresh
# unselected) minus everything selected. S5-style atomic write, same dir.
save_declined() {  # $1 = candidates file, $2 = selected file
    $DRY_RUN && return 0
    mkdir -p "$PROJECT_ARIS_DIR"
    local tmp="$DECLINED_PATH.tmp.$$"
    sort -u "$1" | grep -v '^$' | grep -vxF -f "$2" > "$tmp" || true
    if [[ -s "$tmp" || -f "$DECLINED_PATH" ]]; then
        mv -f "$tmp" "$DECLINED_PATH"
    else
        rm -f "$tmp"
    fi
}

# Auto-include hard pipeline deps (catalog `requires` column, transitively).
# A dep excluded via --exclude this run is never auto-added — warn instead.
expand_deps() {  # $1 = selected file, $2 = excludes file, $3 = upstream file
    catalog_ok || return 0
    local changed=1 name dep
    while (( changed )); do
        changed=0
        for name in $(cat "$1"); do
            for dep in $(catalog_requires "$name"); do
                in_file "$dep" "$1" && continue
                if in_file "$dep" "$2"; then
                    warn "'$name' requires '$dep' but it is excluded — that pipeline phase will break"
                    continue
                fi
                upstream_has_skill "$dep" "$3" || continue
                echo "$dep" >> "$1"
                log "  ↳ auto-including '$dep' (required by '$name')"
                changed=1
            done
        done
    done
}

# Interactive selection (fresh install on a TTY, no selection flags).
# Preferred UI: full-screen checkbox picker (tools/skill_picker.py, curses) —
# Space toggles a skill / a whole group, Enter confirms, q aborts. Falls back
# to the classic per-group Y/n/e prompts when python3/curses/tty are
# unavailable or ARIS_NO_PICKER=1 is set.
interactive_select() {  # $1 = upstream file, $2 = out (selected) file
    if [[ "${ARIS_NO_PICKER:-0}" != "1" ]] && command -v python3 >/dev/null 2>&1 \
       && [[ -f "$ARIS_REPO/tools/skill_picker.py" ]]; then
        local avail_f rc=0
        avail_f="$(mktemp -t aris-avail.XXXX)"
        grep '^skill|' "$1" | cut -d'|' -f2 > "$avail_f" || true
        python3 "$ARIS_REPO/tools/skill_picker.py" \
            --catalog "$CATALOG_PATH" --available "$avail_f" --out "$2" \
            </dev/tty >/dev/tty || rc=$?
        rm -f "$avail_f"
        if [[ $rc -eq 0 ]]; then return 0
        elif [[ $rc -eq 1 ]]; then die "interactive selection aborted"
        fi
        # rc=2 (or unexpected): picker unusable — fall through to prompts.
        warn "checkbox picker unavailable — using per-group prompts"
    fi
    log ""
    log "Interactive skill selection — per group: Y=install all, n=skip, e=pick per skill."
    local gid display desc n reply r2 name glist
    glist="$(mktemp -t aris-glist.XXXX)"
    while IFS=$'\t' read -r gid display desc; do
        catalog_skills_in_group "$gid" | while read -r name; do
            upstream_has_skill "$name" "$1" && echo "$name"
        done > "$glist" || true
        n=$(wc -l < "$glist" | tr -d ' ')
        (( n == 0 )) && continue
        printf "\n%s (%s) — %s\n" "$display" "$gid" "$desc" >&2
        sed 's/^/    /' "$glist" >&2
        printf "Install group '%s' (%s skills)? [Y/n/e] " "$gid" "$n" >&2
        read -r reply </dev/tty
        case "$reply" in
            [nN]*) : ;;
            [eE]*)
                while read -r name; do
                    printf "  install %-30s [Y/n] " "$name" >&2
                    read -r r2 </dev/tty
                    [[ "$r2" =~ ^[nN] ]] || echo "$name" >> "$2"
                done < "$glist"
                ;;
            *) cat "$glist" >> "$2" ;;
        esac
    done < <(catalog_groups)
    # Upstream skills the catalog doesn't know yet (catalog drift): never drop silently.
    local ungrouped; ungrouped="$(mktemp -t aris-ungrouped.XXXX)"
    grep '^skill|' "$1" | cut -d'|' -f2 | while read -r name; do
        catalog_has_skill "$name" || echo "$name"
    done > "$ungrouped" || true
    if [[ -s "$ungrouped" ]]; then
        printf "\nSkills not in the catalog yet:\n" >&2
        sed 's/^/    /' "$ungrouped" >&2
        while read -r name; do
            printf "  install %-30s [Y/n] " "$name" >&2
            read -r r2 </dev/tty
            [[ "$r2" =~ ^[nN] ]] || echo "$name" >> "$2"
        done < "$ungrouped"
    fi
    rm -f "$glist" "$ungrouped"
}

# Validate --groups/--skills names against catalog + upstream.
validate_selection_flags() {  # $1 = upstream file
    local g s
    if [[ -n "$SELECT_GROUPS" ]]; then
        catalog_ok || die "--groups needs the catalog at $CATALOG_PATH (update your aris-repo clone)"
        for g in $(echo "$SELECT_GROUPS" | tr ',' ' '); do
            catalog_groups | cut -f1 | grep -qxF "$g" \
                || die "unknown group '$g' — run with --list-groups to see valid ids"
        done
    fi
    for s in $(echo "$SELECT_SKILLS" | tr ',' ' '); do
        upstream_has_skill "$s" "$1" || die "unknown skill '$s' (not an upstream skill)"
    done
}

# Build the selected-skill set (one name per line in $3).
build_selection() {  # $1 = upstream file, $2 = declined-candidates out file, $3 = selected out file
    local upstream="$1" declined_out="$2" out="$3"
    : > "$out"
    load_declined "$declined_out"

    local excl; excl="$(mktemp -t aris-excl.XXXX)"
    echo "$EXCLUDE_SKILLS" | tr ',' '\n' | grep -v '^$' > "$excl" || true
    cat "$excl" >> "$declined_out"

    validate_selection_flags "$upstream"

    local has_selection_flags=false
    [[ -n "$SELECT_GROUPS$SELECT_SKILLS" ]] && has_selection_flags=true
    local fresh=true
    [[ -f "$MANIFEST_PATH" ]] && fresh=false

    local name g subset_choice=false
    if $fresh; then
        if $SELECT_ALL || { ! $has_selection_flags && { $QUIET || [[ ! -t 0 ]]; }; }; then
            grep '^skill|' "$upstream" | cut -d'|' -f2 > "$out"
        elif $has_selection_flags; then
            subset_choice=true
            for g in $(echo "$SELECT_GROUPS" | tr ',' ' '); do
                catalog_skills_in_group "$g" | while read -r name; do
                    upstream_has_skill "$name" "$upstream" && echo "$name"
                done >> "$out" || true
            done
            echo "$SELECT_SKILLS" | tr ',' '\n' | grep -v '^$' >> "$out" || true
        elif catalog_ok; then
            subset_choice=true
            interactive_select "$upstream" "$out"
        else
            warn "catalog missing at $CATALOG_PATH — falling back to full install"
            grep '^skill|' "$upstream" | cut -d'|' -f2 > "$out"
        fi
        # Explicit subset choice ⇒ remember the rest as declined (won't re-ask).
        if $subset_choice; then
            grep '^skill|' "$upstream" | cut -d'|' -f2 | grep -vxF -f "$out" >> "$declined_out" 2>/dev/null || true
        fi
    else
        # Reconcile: installed set = manifest ∩ upstream (auto-detected).
        manifest_names "$MANIFEST_DATA" | while read -r name; do
            [[ "$(manifest_kind_of "$MANIFEST_DATA" "$name")" == "skill" ]] || continue
            upstream_has_skill "$name" "$upstream" && echo "$name"
        done >> "$out" || true
        # Flag-based additions re-enable previously declined skills.
        for g in $(echo "$SELECT_GROUPS" | tr ',' ' '); do
            catalog_skills_in_group "$g" | while read -r name; do
                upstream_has_skill "$name" "$upstream" && echo "$name"
            done >> "$out" || true
        done
        echo "$SELECT_SKILLS" | tr ',' '\n' | grep -v '^$' >> "$out" || true
        # NEW upstream skills: not installed, not declined, not just selected.
        local new_file; new_file="$(mktemp -t aris-new.XXXX)"
        grep '^skill|' "$upstream" | cut -d'|' -f2 | while read -r name; do
            in_file "$name" "$out" && continue
            in_file "$name" "$declined_out" && continue
            echo "$name"
        done > "$new_file" || true
        if [[ -s "$new_file" ]]; then
            if $SELECT_ALL || [[ "$NEW_POLICY" == "add" ]]; then
                cat "$new_file" >> "$out"
                log "→ adding $(wc -l < "$new_file" | tr -d ' ') new upstream skill(s) (--all/--add-new)"
            elif [[ "$NEW_POLICY" == "skip" ]] || $QUIET || [[ ! -t 0 ]]; then
                # warn (not log): must stay visible under --quiet — silently
                # missing new skills is exactly the failure mode #366 fixes.
                warn "new upstream skills NOT installed: $(paste -sd, - < "$new_file")"
                warn "  (rerun interactively to be asked, or pass --add-new / --skills NAME)"
            else
                log ""
                log "New skills appeared upstream since your last install:"
                local reply grp sdesc
                while read -r name; do
                    grp="$(catalog_group_of "$name")"
                    sdesc="$(catalog_desc_of "$name")"
                    printf "  install new skill %-30s (group: %s)%s [y/N] " "$name" "${grp:-?}" "${sdesc:+ — $sdesc}" >&2
                    read -r reply </dev/tty
                    if [[ "$reply" =~ ^[yY] ]]; then echo "$name" >> "$out"
                    else echo "$name" >> "$declined_out"
                    fi
                done < "$new_file"
            fi
        fi
        rm -f "$new_file"
    fi

    # Excludes beat every other source (manifest, groups, deps, new skills):
    # prune before dep expansion so an excluded pipeline doesn't drag deps in,
    # and expand_deps itself refuses to re-add excluded names.
    local pruned
    if [[ -s "$excl" ]]; then
        pruned="$(mktemp -t aris-pruned.XXXX)"
        grep -vxF -f "$excl" "$out" > "$pruned" || true
        mv -f "$pruned" "$out"
    fi
    expand_deps "$out" "$excl" "$upstream"
    sort -u -o "$out" "$out"
    rm -f "$excl"
    [[ -s "$out" ]] || die "selection is empty — nothing to install (use --all or --groups/--skills)"
}

# Keep support entries + selected skills only.
filter_upstream_by_selection() {  # $1 = upstream file, $2 = selected file, $3 = out
    awk -F'|' -v sel="$2" '
        BEGIN { while ((getline line < sel) > 0) picked[line]=1 }
        $1=="support" { print; next }
        $1=="skill" && picked[$2] { print }
    ' "$1" > "$3"
}

# Layer-4 helper resolution (#366): a global pointer file lets globally/copy-
# installed skills find $ARIS_REPO/tools without a per-project install.
ensure_global_pointer() {
    $DRY_RUN && return 0
    mkdir -p "$(dirname "$GLOBAL_POINTER")" 2>/dev/null || { warn "cannot create $(dirname "$GLOBAL_POINTER") — skipping global pointer"; return 0; }
    local cur=""
    [[ -f "$GLOBAL_POINTER" ]] && cur="$(cat "$GLOBAL_POINTER" 2>/dev/null || true)"
    [[ "$cur" == "$ARIS_REPO" ]] && return 0
    printf '%s\n' "$ARIS_REPO" > "$GLOBAL_POINTER.tmp.$$" && mv -f "$GLOBAL_POINTER.tmp.$$" "$GLOBAL_POINTER"
    log "  + global pointer $GLOBAL_POINTER -> $ARIS_REPO"
}

# Parse manifest into a global associative-style array via temp file lookup
# We store the parsed content in $MANIFEST_DATA_FILE (one entry per line) for grep lookup
load_manifest() {
    local path="$1" out="$2"
    : > "$out"
    [[ -f "$path" ]] || return 0
    # Validate version header
    local ver; ver="$(awk -F'\t' '$1=="version"{print $2}' "$path" | head -1)"
    [[ "$ver" == "$MANIFEST_VERSION" ]] || die "manifest version mismatch (file: $ver, expected: $MANIFEST_VERSION)"
    # Body lines: kind\tname\tsource_rel\ttarget_rel\tmode
    awk -F'\t' '
        BEGIN { in_body=0 }
        /^kind\tname\tsource_rel\ttarget_rel\tmode$/ { in_body=1; next }
        in_body && NF==5 { print }
    ' "$path" > "$out"
}

manifest_lookup_target() {
    # echo target_rel for given name from $1=manifest_data_file $2=name
    awk -F'\t' -v n="$2" '$2==n {print $4; exit}' "$1"
}
manifest_lookup_source() {
    awk -F'\t' -v n="$2" '$2==n {print $3; exit}' "$1"
}
manifest_names() { awk -F'\t' '{print $2}' "$1"; }
manifest_kind_of() {
    awk -F'\t' -v n="$2" '$2==n {print $1; exit}' "$1"
}

# ─── Resolve project path & aris-repo ─────────────────────────────────────────
PROJECT_PATH="${PROJECT_PATH:-$(pwd)}"
[[ -d "$PROJECT_PATH" ]] || die "project path does not exist: $PROJECT_PATH"
PROJECT_PATH="$(abs_path "$PROJECT_PATH")"

# ─── Platform auto-detect + delegation (before resolve_aris_repo) ─────────────
# Must happen before resolve_aris_repo because the Codex installer resolves its
# own repo path (looking for skills/skills-codex instead of just skills/).
# Skip auto-detect (and its marker warnings) when --platform is explicit — the
# override wins anyway, so detecting would only print a misleading "defaulting to …".
[[ -n "$PLATFORM_OVERRIDE" ]] || auto_detect_platform "$PROJECT_PATH"
PLATFORM="${PLATFORM_OVERRIDE:-$DETECTED_PLATFORM}"
if [[ "$PLATFORM" == "codex" ]]; then
    # Validate: claude-only flags are incompatible with codex platform
    if [[ ${#CLAUDE_ONLY_FLAGS_USED[@]} -gt 0 ]]; then
        die "Claude-only flags incompatible with codex platform: ${CLAUDE_ONLY_FLAGS_USED[*]}"
    fi
    SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
    CODEX_INSTALLER="$SCRIPT_DIR/install_aris_codex.sh"
    [[ -f "$CODEX_INSTALLER" ]] || die "Codex installer not found: $CODEX_INSTALLER"
    log ""
    if [[ -n "$PLATFORM_OVERRIDE" ]]; then
        log "Codex CLI platform selected — delegating to install_aris_codex.sh"
    else
        log "Codex CLI platform detected — delegating to install_aris_codex.sh"
        log "  (override with --platform claude)"
    fi
    log ""
    if [[ ${#FORWARDED_ARGS[@]} -gt 0 ]]; then
        exec bash "$CODEX_INSTALLER" "${FORWARDED_ARGS[@]}"
    fi
    exec bash "$CODEX_INSTALLER"
fi
# Validate: codex-only flags are incompatible with claude platform
if [[ ${#CODEX_ONLY_FLAGS_SEEN[@]} -gt 0 ]]; then
    die "Codex-only flags incompatible with claude platform: ${CODEX_ONLY_FLAGS_SEEN[*]}"
fi

ARIS_REPO="$(resolve_aris_repo)"
SKILLS_DIR_ABS="$ARIS_REPO/skills"
PROJECT_SKILLS_DIR="$PROJECT_PATH/$SKILLS_REL"
PROJECT_ARIS_DIR="$PROJECT_PATH/$ARIS_DIR_NAME"
MANIFEST_PATH="$PROJECT_ARIS_DIR/$MANIFEST_NAME"
MANIFEST_PREV="$PROJECT_ARIS_DIR/$MANIFEST_PREV_NAME"
AGENT_MANIFEST_PATH="$PROJECT_ARIS_DIR/$AGENT_MANIFEST_NAME"
AGENT_PROFILES_OPT_OUT_PATH="$PROJECT_ARIS_DIR/$AGENT_PROFILES_OPT_OUT_NAME"
LOCK_DIR="$PROJECT_ARIS_DIR/$LOCK_DIR_NAME"
DOC_FILE="$PROJECT_PATH/$DOC_FILE_NAME"
CATALOG_PATH="$ARIS_REPO/$CATALOG_REL"
DECLINED_PATH="$PROJECT_ARIS_DIR/$DECLINED_NAME"

if $LIST_GROUPS; then
    print_group_catalog
    exit 0
fi

# ─── S9: refuse if .aris / .claude / .claude/skills is itself a symlink ───────
# (.aris and .claude/skills may not exist yet — only check if present.)
check_no_symlinked_parents() {
    local p
    for p in "$PROJECT_ARIS_DIR" "$PROJECT_PATH/.claude" "$PROJECT_SKILLS_DIR" "$PROJECT_PATH/.github" "$PROJECT_PATH/.github/agents"; do
        if is_symlink "$p"; then
            die "S9: $p is a symlink — refusing to install (would mutate symlink target)"
        fi
    done
}

# ─── Lock acquisition (mkdir-based, portable) ─────────────────────────────────
write_lock_metadata() {
    # Two files: owner.json for human inspection, owner.pid for reliable parsing
    cat > "$LOCK_DIR/owner.json" <<EOF
{"host":"$(hostname)","pid":$$,"started_at":"$(date -u +%Y-%m-%dT%H:%M:%SZ)","tool":"install_aris.sh"}
EOF
    echo "$$" > "$LOCK_DIR/owner.pid"
    echo "$(hostname)" > "$LOCK_DIR/owner.host"
}

acquire_lock() {
    mkdir -p "$PROJECT_ARIS_DIR"
    if mkdir "$LOCK_DIR" 2>/dev/null; then
        write_lock_metadata
        trap release_lock EXIT INT TERM
        return 0
    fi
    if $CLEAR_STALE_LOCK; then
        local owner=""
        [[ -f "$LOCK_DIR/owner.json" ]] && owner="$(cat "$LOCK_DIR/owner.json")"
        warn "removing stale lock: $LOCK_DIR (was: $owner)"
        rm -rf "$LOCK_DIR"
        mkdir "$LOCK_DIR" || die "still cannot acquire lock after stale clear"
        write_lock_metadata
        trap release_lock EXIT INT TERM
        return 0
    fi
    local owner=""
    [[ -f "$LOCK_DIR/owner.json" ]] && owner="$(cat "$LOCK_DIR/owner.json")"
    die "another install_aris.sh is running in this project (lock: $LOCK_DIR)
       owner: $owner
       if you are sure no install is in progress, rerun with --clear-stale-lock"
}

release_lock() {
    [[ -d "$LOCK_DIR" ]] || return 0
    if [[ -f "$LOCK_DIR/owner.pid" ]]; then
        local pid; pid="$(cat "$LOCK_DIR/owner.pid" 2>/dev/null || echo "")"
        local host; host="$(cat "$LOCK_DIR/owner.host" 2>/dev/null || echo "")"
        if [[ "$pid" == "$$" && "$host" == "$(hostname)" ]]; then
            rm -rf "$LOCK_DIR"
        fi
    fi
}

# ─── Migration detection ──────────────────────────────────────────────────────
LEGACY_NESTED="$PROJECT_SKILLS_DIR/aris"

detect_legacy() {
    if [[ ! -e "$LEGACY_NESTED" && ! -L "$LEGACY_NESTED" ]]; then echo "none"; return; fi
    if is_symlink "$LEGACY_NESTED"; then
        local tgt; tgt="$(read_link_target "$LEGACY_NESTED")"
        if [[ "$tgt" == "$SKILLS_DIR_ABS" || "$tgt" == "$SKILLS_DIR_ABS/" ]]; then
            echo "symlink_to_repo"
        else
            echo "symlink_to_other"
        fi
    elif [[ -d "$LEGACY_NESTED" ]]; then
        echo "real_dir"
    else
        echo "real_file"
    fi
}

migrate_legacy() {
    local kind; kind="$(detect_legacy)"
    case "$kind" in
        none)
            return 0 ;;
        symlink_to_repo)
            log "→ migrating legacy nested symlink: removing $LEGACY_NESTED"
            $DRY_RUN || rm -f "$LEGACY_NESTED"
            return 0 ;;
        symlink_to_other)
            die "S2: legacy $LEGACY_NESTED is a symlink to OUTSIDE the repo — refusing to touch.
       investigate manually before re-running."
            ;;
        real_file)
            die "$LEGACY_NESTED is a regular file (unexpected). Move/delete it manually." ;;
        real_dir)
            if [[ -z "$MIGRATE_COPY" ]]; then
                die "legacy nested COPY install detected at $LEGACY_NESTED.
       This may contain user edits. Choose explicitly:
         --migrate-copy keep-user        (keep nested copy intact, install flat alongside;
                                          old copy becomes inert for Claude discovery)
         --migrate-copy prefer-upstream  (archive nested copy to .aris/legacy-copy-backup-<ts>/
                                          AFTER new flat install is verified, then flatten)"
            fi
            # actual handling deferred until after apply (for prefer-upstream)
            return 0 ;;
    esac
}

archive_legacy_copy() {
    local ts; ts="$(date -u +%Y%m%dT%H%M%SZ)"
    local archive="$PROJECT_ARIS_DIR/legacy-copy-backup-$ts"
    log "→ archiving legacy nested copy to: $archive"
    $DRY_RUN || mv "$LEGACY_NESTED" "$archive"
}

# ─── Plan computation ─────────────────────────────────────────────────────────
# Plan is written to a temp file, one line per action: ACTION|kind|name|extra
# Actions: CREATE | UPDATE_TARGET | REUSE | REMOVE | ADOPT | CONFLICT
compute_plan() {
    local upstream_file="$1" manifest_data="$2" out="$3"
    : > "$out"
    local target_path src expected_target current_target line kind name
    # Iterate upstream entries
    while IFS='|' read -r kind name; do
        [[ -z "$name" ]] && continue
        target_path="$PROJECT_SKILLS_DIR/$name"
        expected_target="$SKILLS_DIR_ABS/$name"
        if [[ -L "$target_path" ]]; then
            current_target="$(read_link_target "$target_path")"
            # Convert relative readlink to absolute (relative to symlink's dir)
            if [[ "$current_target" != /* ]]; then
                current_target="$(canonicalize "$PROJECT_SKILLS_DIR/$current_target")"
            fi
            local in_manifest=false
            if [[ -n "$(manifest_lookup_target "$manifest_data" "$name")" ]]; then in_manifest=true; fi
            if [[ "$current_target" == "$expected_target" ]]; then
                if $in_manifest; then echo "REUSE|$kind|$name|" >> "$out"
                else echo "ADOPT|$kind|$name|" >> "$out"
                fi
            else
                # symlink exists but points elsewhere
                if $in_manifest; then
                    # managed symlink with stale target — can update with --replace-link or auto if safely inside repo
                    echo "UPDATE_TARGET|$kind|$name|$current_target" >> "$out"
                else
                    # foreign symlink (user's own?) — conflict
                    echo "CONFLICT|$kind|$name|symlink_to:$current_target" >> "$out"
                fi
            fi
        elif [[ -e "$target_path" ]]; then
            # real file/dir
            echo "CONFLICT|$kind|$name|real_path" >> "$out"
        else
            echo "CREATE|$kind|$name|" >> "$out"
        fi
    done < "$upstream_file"
    # Manifest entries no longer in upstream → REMOVE
    while IFS=$'\t' read -r mkind mname msrc mtarget mmode; do
        [[ -z "$mname" ]] && continue
        # is name in upstream?
        if grep -q "^[^|]*|$mname$" "$upstream_file"; then continue; fi
        echo "REMOVE|$mkind|$mname|" >> "$out"
    done < "$manifest_data"
}

# ─── Plan rendering ───────────────────────────────────────────────────────────
print_plan() {
    local plan="$1"
    local n_create n_update n_reuse n_remove n_adopt n_conflict
    n_create=$(grep -c '^CREATE|' "$plan" || true)
    n_update=$(grep -c '^UPDATE_TARGET|' "$plan" || true)
    n_reuse=$(grep -c '^REUSE|' "$plan" || true)
    n_remove=$(grep -c '^REMOVE|' "$plan" || true)
    n_adopt=$(grep -c '^ADOPT|' "$plan" || true)
    n_conflict=$(grep -c '^CONFLICT|' "$plan" || true)
    log ""
    log "Plan summary:"
    log "  CREATE:        $n_create  (new flat symlinks to add)"
    log "  ADOPT:         $n_adopt   (orphan symlinks already pointing to correct target)"
    log "  UPDATE_TARGET: $n_update  (managed symlinks with stale target)"
    log "  REUSE:         $n_reuse   (already correct, no-op)"
    log "  REMOVE:        $n_remove  (in old manifest, no longer upstream)"
    log "  CONFLICT:      $n_conflict  (must be resolved before apply)"
    if (( n_conflict > 0 )); then
        log ""
        log "Conflicts (need user action):"
        grep '^CONFLICT|' "$plan" | while IFS='|' read -r _ kind name extra; do
            log "  - $name ($kind): $extra"
        done
    fi
}

# ─── Apply ────────────────────────────────────────────────────────────────────
# Order (safer than mine, per codex round 3):
#   1. Write new manifest temp (in-place dir for atomic rename)
#   2. Apply mutations with revalidation (lstat + readlink) right before each
#   3. Copy current manifest to .prev.tmp, rename to .prev
#   4. Rename new manifest temp over current manifest (LAST commit point)
#   5. CLAUDE.md update (best-effort, compare-and-swap, never fails install)

write_manifest_tmp() {
    local plan="$1" out="$2"
    {
        printf "version\t%s\n" "$MANIFEST_VERSION"
        printf "repo_root\t%s\n" "$ARIS_REPO"
        printf "project_root\t%s\n" "$PROJECT_PATH"
        printf "generated\t%s\n" "$(date -u +%Y-%m-%dT%H:%M:%SZ)"
        printf "kind\tname\tsource_rel\ttarget_rel\tmode\n"
        # New manifest = REUSE + ADOPT + CREATE + UPDATE_TARGET (i.e., everything that will exist as a managed symlink after apply)
        awk -F'|' '$1=="REUSE"||$1=="ADOPT"||$1=="CREATE"||$1=="UPDATE_TARGET"{print $0}' "$plan" \
        | while IFS='|' read -r action kind name _; do
            printf "%s\t%s\tskills/%s\t%s/%s\tsymlink\n" "$kind" "$name" "$name" "$SKILLS_REL" "$name"
        done
    } > "$out"
}

# Verify current symlink state matches our expectation immediately before mutating
revalidate_symlink_target() {
    local path="$1" expected="$2"
    is_symlink "$path" || return 1
    local cur; cur="$(read_link_target "$path")"
    [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$path")/$cur")"
    [[ "$cur" == "$expected" ]]
}

apply_plan() {
    local plan="$1" manifest_tmp="$2"
    mkdir -p "$PROJECT_SKILLS_DIR"
    local action kind name extra target_path expected_target
    while IFS='|' read -r action kind name extra; do
        [[ -z "$name" ]] && continue
        target_path="$PROJECT_SKILLS_DIR/$name"
        expected_target="$SKILLS_DIR_ABS/$name"
        case "$action" in
            REUSE|ADOPT)
                : # nothing to do; manifest will record it
                ;;
            CREATE)
                # S4: must not exist
                if [[ -e "$target_path" || -L "$target_path" ]]; then
                    die "S4 violation: $target_path appeared between plan and apply"
                fi
                if $DRY_RUN; then log "  (dry-run) ln -s $expected_target $target_path"
                else ln -s "$expected_target" "$target_path"; log "  + $name"
                fi
                ;;
            UPDATE_TARGET)
                # S11: revalidate current target equals what plan saw
                local plan_saw_target; plan_saw_target="$(read_link_target "$target_path" 2>/dev/null || echo "")"
                [[ "$plan_saw_target" != /* && -n "$plan_saw_target" ]] && plan_saw_target="$(canonicalize "$(dirname "$target_path")/$plan_saw_target")"
                if [[ "$plan_saw_target" != "$extra" ]]; then
                    warn "S11: $target_path target changed since plan ($plan_saw_target vs $extra) — skipping"
                    continue
                fi
                # S2: stale target must point inside aris-repo
                if [[ "$plan_saw_target" != "$ARIS_REPO"/* ]]; then
                    warn "S2: refusing to replace symlink pointing outside aris-repo: $target_path -> $plan_saw_target"
                    continue
                fi
                if $DRY_RUN; then log "  (dry-run) update target: $target_path -> $expected_target"
                else
                    rm -f "$target_path"
                    ln -s "$expected_target" "$target_path"
                    log "  ↻ $name"
                fi
                ;;
            REMOVE)
                # S1: must be a symlink
                is_symlink "$target_path" || { warn "S1: $target_path is not a symlink, refusing to remove"; continue; }
                # S2: target must be inside aris-repo
                local cur; cur="$(read_link_target "$target_path")"
                [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$target_path")/$cur")"
                [[ "$cur" == "$ARIS_REPO"/* ]] || { warn "S2: $target_path target $cur outside aris-repo, refusing"; continue; }
                if $DRY_RUN; then log "  (dry-run) rm $target_path"
                else rm -f "$target_path"; log "  - $name"
                fi
                ;;
            CONFLICT)
                die "BUG: CONFLICT $name reached apply phase"
                ;;
        esac
    done < "$plan"
}

# Phase 0 (#174): ensure project-local `.aris/tools` symlink exists, pointing
# to the canonical aris-repo `tools/` dir. Pure-additive: existing users who
# don't rerun the installer never see this. The symlink is currently inert
# (no SKILL.md references it); it sets up future #177 path-rewrites.
#
# Idempotent. If `.aris/tools` already exists with a different target (or as
# a real file/dir), warn and leave it alone — never replace user content.
# Membership in the "managed" set is determined by exact target match against
# `$ARIS_REPO/tools`, not via the manifest, so we don't need to bump the
# manifest format for this single-link addition (per #174 non-goals).
ensure_tools_symlink() {
    local link_path="$PROJECT_ARIS_DIR/tools"
    local expected_target="$ARIS_REPO/tools"

    if is_symlink "$link_path"; then
        local cur; cur="$(read_link_target "$link_path")"
        [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$link_path")/$cur")"
        if [[ "$cur" == "$expected_target" ]]; then
            return 0
        fi
        warn ".aris/tools already exists with different target ($cur); leaving alone (#174)"
        return 0
    fi

    if [[ -e "$link_path" ]]; then
        warn ".aris/tools already exists as a non-symlink path; leaving alone (#174)"
        return 0
    fi

    if $DRY_RUN; then
        log "  (dry-run) ln -s $expected_target $link_path"
    else
        ln -s "$expected_target" "$link_path"
        log "  + .aris/tools -> tools/ (Phase 0, #174)"
    fi
}

# Counterpart for uninstall: only remove `.aris/tools` if it is exactly the
# managed symlink (target == $ARIS_REPO/tools). User-created directories /
# files / different symlinks are untouched.
remove_tools_symlink() {
    local link_path="$PROJECT_ARIS_DIR/tools"
    local expected_target="$ARIS_REPO/tools"

    is_symlink "$link_path" || return 0
    local cur; cur="$(read_link_target "$link_path")"
    [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$link_path")/$cur")"
    if [[ "$cur" != "$expected_target" ]]; then
        return 0
    fi

    if $DRY_RUN; then
        log "  (dry-run) rm $link_path"
    else
        rm -f "$link_path"
        log "  - .aris/tools (managed symlink)"
    fi
}

# F5: Deploy Copilot agent profiles from <aris-repo>/.github/agents/ to
# <project>/.github/agents/. Each .agent.md file is symlinked individually;
# user-created files/dirs/symlinks at the target path are left alone.
# Pure-additive — existing users who don't rerun the installer never see
# this. Idempotent across re-runs.
record_managed_agent_profile() {
    local name="$1" tmp="$AGENT_MANIFEST_PATH.tmp.$$" unsorted="$AGENT_MANIFEST_PATH.unsorted.$$"
    mkdir -p "$PROJECT_ARIS_DIR"
    if [[ -L "$AGENT_MANIFEST_PATH" ]]; then
        warn "$AGENT_MANIFEST_PATH is a symlink; refusing to record agent ownership"
        return 1
    fi
    if [[ -f "$AGENT_MANIFEST_PATH" ]]; then
        cp "$AGENT_MANIFEST_PATH" "$unsorted" || { rm -f "$unsorted" "$tmp"; return 1; }
    else
        : > "$unsorted" || return 1
    fi
    printf '%s\n' "$name" >> "$unsorted" || { rm -f "$unsorted" "$tmp"; return 1; }
    sort -u "$unsorted" > "$tmp" || { rm -f "$unsorted" "$tmp"; return 1; }
    rm -f "$unsorted"
    mv -f "$tmp" "$AGENT_MANIFEST_PATH"
}

ensure_agent_profiles() {
    local src_dir="$ARIS_REPO/$AGENT_PROFILES_SRC"
    [[ -d "$src_dir" ]] || return 0  # no profiles to deploy
    [[ ! -L "$src_dir" ]] || { warn "skipping symlinked upstream agents directory: $src_dir"; return 0; }
    local target_dir="$PROJECT_PATH/.github/agents"
    local deployed=0 name src target

    for src in "$src_dir"/*.agent.md; do
        [[ -f "$src" ]] || continue
        # Resolve symlink and verify it's within the expected directory
        local resolved; resolved="$(canonicalize "$src")"
        local src_canon; src_canon="$(canonicalize "$src_dir")"
        [[ "$resolved" == "$src_canon"/* ]] || { warn "skipping external symlink: $src -> $resolved"; continue; }
        name="$(basename "$src")"
        target="$target_dir/$name"

        if is_symlink "$target"; then
            local cur; cur="$(read_link_target "$target")"
            [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$target")/$cur")"
            if [[ "$cur" == "$src" ]]; then
                continue  # already correct
            fi
            warn ".github/agents/$name already exists with different target ($cur); leaving alone"
            continue
        fi

        if [[ -e "$target" ]]; then
            warn ".github/agents/$name already exists as a non-symlink path; leaving alone"
            continue
        fi

        if $DRY_RUN; then
            log "  (dry-run) ln -s $src $target"
        else
            mkdir -p "$target_dir"
            ln -s "$src" "$target"
            if ! record_managed_agent_profile "$name"; then
                rm -f "$target"
                die "could not record ownership for .github/agents/$name"
            fi
            deployed=$((deployed + 1))
        fi
    done

    if ! $DRY_RUN && (( deployed > 0 )); then
        log "  + .github/agents/ ($deployed copilot profile(s) deployed)"
    fi
}

# Counterpart for uninstall: only remove agent profile symlinks explicitly
# recorded when this installer created them. An identical pre-existing link is
# user-owned and must survive uninstall.
remove_agent_profiles() {
    local target_dir="$PROJECT_PATH/.github/agents"
    [[ -d "$target_dir" || -L "$target_dir" ]] || return 0
    [[ -f "$AGENT_MANIFEST_PATH" ]] || return 0
    [[ ! -L "$AGENT_MANIFEST_PATH" ]] || { warn "$AGENT_MANIFEST_PATH is a symlink; refusing agent cleanup"; return 0; }
    local src_dir="$ARIS_REPO/$AGENT_PROFILES_SRC"
    local name target removed=0

    while IFS= read -r name; do
        [[ "$name" =~ $SAFE_NAME_REGEX && "$name" == *.agent.md ]] || { warn "invalid agent manifest entry: $name"; continue; }
        target="$target_dir/$name"
        [[ -L "$target" ]] || continue
        local cur; cur="$(read_link_target "$target")"
        [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$target")/$cur")"
        # Revalidate the exact source target before mutation.
        if [[ "$cur" == "$src_dir/$name" ]]; then
            if $DRY_RUN; then
                log "  (dry-run) rm $target"
            else
                rm -f "$target"
                removed=$((removed + 1))
            fi
        fi
    done < "$AGENT_MANIFEST_PATH"

    if ! $DRY_RUN && (( removed > 0 )); then
        log "  - .github/agents/ ($removed copilot profile(s) removed)"
        # Remove directory if empty after cleanup
        rmdir "$target_dir" 2>/dev/null || true
    fi
    if ! $DRY_RUN; then
        rm -f "$AGENT_MANIFEST_PATH"
    fi
}

# #431: the profiles only serve auto-review-loop's Copilot backend, and
# .github/ is the user's namespace — so deploy them only while that skill is
# installed, and let the user say no outright. The opt-out is remembered in
# .aris/ so a later reconcile does not bring the links back.
agent_profiles_wanted() {  # $1 = selected file
    case "$AGENT_PROFILES_FLAG" in
        off) return 1 ;;
        on)  ;;
        *)   [[ ! -f "$AGENT_PROFILES_OPT_OUT_PATH" ]] || return 1 ;;
    esac
    in_file "auto-review-loop" "$1"
}

persist_agent_profiles_choice() {
    $DRY_RUN && return 0
    case "$AGENT_PROFILES_FLAG" in
        off) mkdir -p "$PROJECT_ARIS_DIR"; : > "$AGENT_PROFILES_OPT_OUT_PATH" ;;
        on)  rm -f "$AGENT_PROFILES_OPT_OUT_PATH" ;;
    esac
}

sync_agent_profiles() {  # $1 = selected file
    if agent_profiles_wanted "$1"; then
        ensure_agent_profiles
    elif [[ -f "$AGENT_MANIFEST_PATH" ]]; then
        if [[ "$AGENT_PROFILES_FLAG" == "off" || -f "$AGENT_PROFILES_OPT_OUT_PATH" ]]; then
            log "  Copilot profiles opted out — removing the ones this installer created"
        else
            log "  auto-review-loop not installed — removing the Copilot profiles this installer created"
        fi
        remove_agent_profiles
    fi
}

commit_manifest() {
    local manifest_tmp="$1"
    if $DRY_RUN; then log "  (dry-run) would commit manifest"; return; fi
    # Backup current manifest if exists
    if [[ -f "$MANIFEST_PATH" ]]; then
        cp -p "$MANIFEST_PATH" "$MANIFEST_PREV.tmp"
        mv -f "$MANIFEST_PREV.tmp" "$MANIFEST_PREV"
    fi
    # Atomic rename from temp (same dir → atomic on same FS)
    mv -f "$manifest_tmp" "$MANIFEST_PATH"
}

# ─── CLAUDE.md best-effort update (compare-and-swap) ──────────────────────────
update_claude_doc() {
    local installed_names_file="$1"
    [[ -f "$DOC_FILE" ]] || { log "  (skip CLAUDE.md: file not present)"; return 0; }
    if $NO_DOC; then return 0; fi

    local original new_block tmp
    original="$(cat "$DOC_FILE")"
    # Build new block
    local count; count="$(wc -l < "$installed_names_file" | tr -d ' ')"
    new_block="$BLOCK_BEGIN
## ARIS Skill Scope
ARIS skills installed in this project: $count entries.
Manifest: \`$ARIS_DIR_NAME/$MANIFEST_NAME\` (lists every skill ARIS installed and its upstream target).
For ARIS workflows, prefer the project-local skills under \`$SKILLS_REL/\` over global skills.
Do not modify or delete files inside any skill that is a symlink (symlinks point into \`$ARIS_REPO\`).
Update with: \`bash $ARIS_REPO/tools/install_aris.sh\`  (re-runnable; reconciles new/removed skills).
$BLOCK_END"

    # Compute new content
    local new_content
    if printf '%s' "$original" | grep -qF "$BLOCK_BEGIN"; then
        new_content="$(python3 - "$DOC_FILE" "$BLOCK_BEGIN" "$BLOCK_END" "$new_block" <<'PYEOF'
import re, sys, pathlib
path, begin, end, body = sys.argv[1], sys.argv[2], sys.argv[3], sys.argv[4]
text = pathlib.Path(path).read_text()
pattern = re.compile(re.escape(begin) + r".*?" + re.escape(end), re.DOTALL)
matches = pattern.findall(text)
if len(matches) > 1:
    sys.stderr.write("ARIS:WARN multiple ARIS blocks found in CLAUDE.md; skipping update\n")
    sys.stdout.write(text)
else:
    sys.stdout.write(pattern.sub(body, text))
PYEOF
        )" || { warn "CLAUDE.md update failed (best-effort, continuing)"; return 0; }
    else
        new_content="$original"
        [[ -n "$original" ]] && new_content="${new_content}"$'\n'
        new_content="${new_content}${new_block}"$'\n'
    fi

    # Compare-and-swap: re-read file, only commit if unchanged from snapshot
    if $DRY_RUN; then log "  (dry-run) would update CLAUDE.md ARIS block"; return 0; fi
    tmp="$DOC_FILE.aris-tmp.$$"
    printf '%s' "$new_content" > "$tmp"
    local current; current="$(cat "$DOC_FILE")"
    if [[ "$current" != "$original" ]]; then
        rm -f "$tmp"
        warn "CLAUDE.md changed during install — skipping doc update (rerun to retry)"
        return 0
    fi
    mv -f "$tmp" "$DOC_FILE"
    log "  ✓ updated CLAUDE.md (ARIS managed block)"
}

# ─── Uninstall ────────────────────────────────────────────────────────────────
do_uninstall() {
    [[ -f "$MANIFEST_PATH" ]] || die "no manifest at $MANIFEST_PATH; nothing to uninstall"
    local manifest_data; manifest_data="$(mktemp -t aris-manifest.XXXX)"
    load_manifest "$MANIFEST_PATH" "$manifest_data"
    log ""
    log "Uninstall plan:"
    while IFS=$'\t' read -r kind name src target mode; do
        [[ -z "$name" ]] && continue
        log "  - $name ($kind)"
    done < "$manifest_data"
    if ! $DRY_RUN && ! $QUIET; then
        prompt "Proceed?" || { log "aborted"; exit 0; }
    fi
    while IFS=$'\t' read -r kind name src target mode; do
        [[ -z "$name" ]] && continue
        local target_path="$PROJECT_PATH/$target"
        local expected="$SKILLS_DIR_ABS/$name"
        # S1: must be symlink
        is_symlink "$target_path" || { warn "S1: $target_path not a symlink, skipping"; continue; }
        # S8 + S11: revalidate target
        local cur; cur="$(read_link_target "$target_path")"
        [[ "$cur" != /* ]] && cur="$(canonicalize "$(dirname "$target_path")/$cur")"
        if [[ "$cur" != "$expected" ]]; then
            warn "S8: $target_path target $cur != expected $expected, skipping"
            continue
        fi
        if $DRY_RUN; then log "  (dry-run) rm $target_path"
        else rm -f "$target_path"; log "  - removed $name"
        fi
    done < "$manifest_data"
    rm -f "$manifest_data"
    # #174 Phase 0: best-effort cleanup of `.aris/tools` symlink, only if it
    # is exactly the managed symlink. Anything else (user-created dir, custom
    # symlink target) is left alone.
    remove_tools_symlink
    # F5: best-effort cleanup of managed agent profile symlinks.
    remove_agent_profiles
    if ! $DRY_RUN; then
        # Keep .prev for forensics, remove current manifest
        [[ -f "$MANIFEST_PATH" ]] && mv -f "$MANIFEST_PATH" "$MANIFEST_PREV"
        log "  ✓ uninstalled (manifest preserved as $MANIFEST_PREV)"
    fi
}

# ─── Main flow ────────────────────────────────────────────────────────────────
log ""
log "ARIS Project Install"
log "  Project:    $PROJECT_PATH"
log "  ARIS repo:  $ARIS_REPO"
log "  Action:     $ACTION$($DRY_RUN && echo ' (dry-run)')"
log ""

check_no_symlinked_parents
acquire_lock

if [[ "$ACTION" == "uninstall" ]]; then
    do_uninstall
    exit 0
fi

# Migration check (only for install/reconcile)
LEGACY_KIND="$(detect_legacy)"
if [[ "$LEGACY_KIND" != "none" ]]; then
    if ! $FROM_OLD; then
        log "Legacy nested install detected: $LEGACY_NESTED ($LEGACY_KIND)"
        log "→ to migrate, rerun with --from-old"
        log "  for COPY-style legacy installs, also pass --migrate-copy keep-user|prefer-upstream"
        exit 1
    fi
    migrate_legacy
fi

# If --reconcile but no manifest, fail
if [[ "$ACTION" == "reconcile" && ! -f "$MANIFEST_PATH" ]]; then
    die "--reconcile requires existing manifest; none found at $MANIFEST_PATH"
fi

# Build inventories
UPSTREAM_FILE="$(mktemp -t aris-upstream.XXXX)"
build_upstream_inventory "$ARIS_REPO" > "$UPSTREAM_FILE"
[[ -s "$UPSTREAM_FILE" ]] || die "upstream inventory empty (broken aris-repo?)"

MANIFEST_DATA="$(mktemp -t aris-manifest.XXXX)"
load_manifest "$MANIFEST_PATH" "$MANIFEST_DATA"

# Selective install (#366): build the selected set, then plan against it.
SELECTED_FILE="$(mktemp -t aris-selected.XXXX)"
DECLINED_CANDIDATES="$(mktemp -t aris-declined.XXXX)"
build_selection "$UPSTREAM_FILE" "$DECLINED_CANDIDATES" "$SELECTED_FILE"
SELECTED_UPSTREAM="$(mktemp -t aris-upstream-sel.XXXX)"
filter_upstream_by_selection "$UPSTREAM_FILE" "$SELECTED_FILE" "$SELECTED_UPSTREAM"
N_SELECTED=$(grep -c '^skill|' "$SELECTED_UPSTREAM" || true)
N_UPSTREAM=$(grep -c '^skill|' "$UPSTREAM_FILE" || true)
log ""
log "Selection: $N_SELECTED of $N_UPSTREAM upstream skills"

PLAN_FILE="$(mktemp -t aris-plan.XXXX)"
compute_plan "$SELECTED_UPSTREAM" "$MANIFEST_DATA" "$PLAN_FILE"
print_plan "$PLAN_FILE"

# Conflict resolution
N_CONFLICT=$(grep -c '^CONFLICT|' "$PLAN_FILE" || true)
if (( N_CONFLICT > 0 )); then
    # Check if any can be auto-resolved by --adopt-existing (where current target == expected)
    # (Already handled by ADOPT classification — anything still in CONFLICT is a real conflict.)
    # Apply --replace-link allowlist for symlink-to-other-repo-entry conflicts.
    # awk (string compare on field 3 = name) instead of sed: plan lines are
    # pipe-delimited, and only symlink conflicts may convert — a real_path
    # CONFLICT must never become UPDATE_TARGET. Converting also strips the
    # symlink_to: prefix so field 4 matches the shape of native UPDATE_TARGET rows.
    if [[ ${#REPLACE_LINK_NAMES[@]} -gt 0 ]]; then
        for n in "${REPLACE_LINK_NAMES[@]}"; do
            PLAN_TMP="${PLAN_FILE}.tmp"
            awk -F'|' -v OFS='|' -v n="$n" \
                '$1=="CONFLICT" && $3==n && $4 ~ /^symlink_to:/ { sub(/^symlink_to:/, "", $4); $1="UPDATE_TARGET" } { print }' \
                "$PLAN_FILE" > "$PLAN_TMP" && mv "$PLAN_TMP" "$PLAN_FILE"
        done
        N_CONFLICT=$(grep -c '^CONFLICT|' "$PLAN_FILE" || true)
    fi
    if (( N_CONFLICT > 0 )); then
        log ""
        log "Aborting due to $N_CONFLICT unresolved conflicts."
        log "Resolve options per name:"
        log "  - back up & remove the conflicting path manually, then rerun"
        log "  - if it's a foreign symlink that should be replaced: --replace-link NAME"
        exit 1
    fi
fi

if $DRY_RUN; then
    # #174 preview: print the planned `.aris/tools` symlink action (function
    # is idempotent + DRY_RUN-aware, so it just logs in this mode)
    ensure_tools_symlink
    # F5 preview: print planned agent profile symlinks (or their removal).
    sync_agent_profiles "$SELECTED_FILE"
    log ""
    log "(dry-run) no changes made"
    exit 0
fi

# Confirm if any mutations
N_CHANGES=$(awk -F'|' '$1=="CREATE"||$1=="UPDATE_TARGET"||$1=="REMOVE"' "$PLAN_FILE" | wc -l | tr -d ' ')
if (( N_CHANGES > 0 )) && ! $QUIET; then
    prompt "Apply these $N_CHANGES changes?" || { log "aborted"; exit 0; }
fi

# Apply
MANIFEST_TMP="$MANIFEST_PATH.tmp.$$"   # S12: same dir as destination
mkdir -p "$PROJECT_ARIS_DIR"
write_manifest_tmp "$PLAN_FILE" "$MANIFEST_TMP"
log ""
log "Applying:"
apply_plan "$PLAN_FILE" "$MANIFEST_TMP"
commit_manifest "$MANIFEST_TMP"

# #174 Phase 0: ensure project-local .aris/tools symlink (purely additive).
# Runs after manifest commit so a failure here doesn't roll back skill links.
ensure_tools_symlink
# F5 / #431: Copilot agent profiles from <aris-repo>/.github/agents/ — only
# while auto-review-loop is installed and not opted out; otherwise clean ours up.
persist_agent_profiles_choice
sync_agent_profiles "$SELECTED_FILE"


# #366: persist declined skills + global repo pointer (both best-effort,
# after manifest commit for the same reason as above).
save_declined "$DECLINED_CANDIDATES" "$SELECTED_FILE"
ensure_global_pointer

# Handle prefer-upstream legacy archive AFTER successful apply
if [[ "$LEGACY_KIND" == "real_dir" && "$MIGRATE_COPY" == "prefer-upstream" ]]; then
    archive_legacy_copy
fi

# CLAUDE.md best-effort
INSTALLED_NAMES="$(mktemp -t aris-names.XXXX)"
awk -F'|' '$1=="REUSE"||$1=="ADOPT"||$1=="CREATE"||$1=="UPDATE_TARGET"{print $3}' "$PLAN_FILE" > "$INSTALLED_NAMES"
update_claude_doc "$INSTALLED_NAMES"
rm -f "$INSTALLED_NAMES"

# Verify
if ! $DRY_RUN; then
    BAD=0
    while IFS=$'\t' read -r v_kind v_name v_src v_target v_mode; do
        [[ -z "$v_name" ]] && continue
        VTARGET="$PROJECT_PATH/$v_target"
        if ! is_symlink "$VTARGET"; then warn "verify: $VTARGET missing"; BAD=$((BAD+1)); fi
    done < <(awk -F'\t' '
        BEGIN { in_body=0 }
        /^kind\tname\tsource_rel\ttarget_rel\tmode$/ { in_body=1; next }
        in_body && NF==5 { print }
    ' "$MANIFEST_PATH")
    (( BAD == 0 )) && log "" && log "✓ Install complete. $N_CHANGES changes applied."
fi

# Cleanup
rm -f "$UPSTREAM_FILE" "$MANIFEST_DATA" "$PLAN_FILE" "$SELECTED_FILE" "$SELECTED_UPSTREAM" "$DECLINED_CANDIDATES"