import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js"; import { z } from "zod/v4"; import { parseAliasFilter } from "./alias-filter.js"; import { createHash } from "node:crypto"; import { db, uuidv4, logTaskEvent, chainReplyToParent, hashToken, generateId, generateNetworkToken, syncScheduledRunForTask } from "./db.js"; import { getSSEStats, pushEvent, pushNetworkObserverEvent } from "./push.js"; import { assertNodeActive } from "./lifecycle-guard.js"; import { getUserNetworkRole, createNetworkTokenForNode } from "./auth.js"; import { canRestWriteNetwork, getUserNetworkIds, singleNetworkId } from "./network-scope.js"; import { buildAnetArgs as _unused_buildAnetArgs, // ensure module is loaded validateName as validateChildName, validateRuntime, validateModel, validateChannelsP1, validateEnvRefs, FLAG_KEYS, validateFlagValue, ValidationError, } from "./create-node-validate.js"; import { putPendingEnvBlob, takePendingEnvBlob, newRequestId, finalizeCreateOnFirstRegister, startPendingEnvGcTimer, startSweeperTimer, auditCreateNode, auditCreateNodeStrict, resolveCallerDaemonTokenBound as _resolveCallerDaemonTokenBound, } from "./create-node.js"; import { vaultUpsert, vaultGet, vaultListKeys, vaultDelete, VaultError, } from "./vault.js"; import { stripHostLocalPathsForCrossHostSafe, validateAttachments } from "./uploads.js"; import { validateBaseUrl as _validateBaseUrl, SUPPORTED_VENDORS, ProbeValidationError, } from "./probe-validate.js"; import { putPendingProbeSecret, newProbeId, finalizeProbeAck, startPendingProbeGcTimer, startProbeSweeperTimer, } from "./probe.js"; import { canonicalAliasExists, cleanupRenamedAliasSession, resolveCanonicalAlias } from "./rename.js"; import { ALLOWED_FLAGS, SECURITY_SENSITIVE_FLAGS, EDITABLE_CHANNELS, computeApplyMode, validatePatch, narrowChannelsPatch, isAllowedToChangeFlag, } from "./config-apply-validate.js"; import { sharedSendDedup, buildDuplicateSendPayload } from "./send_dedup.js"; import { clientRequestIdFromMeta, idempotentTaskId, idempotentTaskMatches, type StoredIdempotentTask } from "./task-idempotency.js"; import { stampTaskAuthOrigin, type TaskAuthOrigin } from "./task-auth-origin.js"; function ts(): string { return new Date().toTimeString().slice(0, 8); } function parseMetaJson(value: unknown): unknown | null { if (!value || typeof value !== "string") return null; try { return JSON.parse(value); } catch { return null; } } function normalizeMetaJson(meta: unknown): string | null { if (!meta || typeof meta !== "object") return null; // #222 cross-host safety — strip `path` from meta.attachments[] when // `file_id` is also present. Shared helper lives in uploads.ts so the // REST handler in index.ts can apply the identical sanitization // (otherwise REST and MCP transports would have different meta_json // shapes for the same send). try { return JSON.stringify(stripHostLocalPathsForCrossHostSafe(meta)); } catch { return null; } } export function registerTools(server: McpServer, clientIP?: string, enforceNetworkId?: string | null, enforceUserId?: string | null, callerAlias?: string | null, callerTokenIsNetwork = false, callerTokenId?: string | null) { // Default from_session for outbound tools — extracted from the calling // token's binding (ntok_ → node alias, utok_ → username). Without this, // an agent's send_task call always claimed from='hub' and peer agents // couldn't tell who actually asked them. Network-bound node tokens are an // identity boundary: they must not spoof another node via from_session. const defaultFrom = (clientFrom?: string) => (callerTokenIsNetwork && callerAlias) ? callerAlias : (clientFrom || callerAlias || "hub"); const fromIdentityMismatchReply = (clientFrom?: string) => { const requestedFrom = clientFrom?.trim(); if (!callerTokenIsNetwork || !callerAlias || !requestedFrom || requestedFrom === callerAlias) return null; return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "from_session_identity_mismatch", message: "network token from_session does not match token-bound node alias", token_alias: callerAlias, requested_from_session: requestedFrom, }), }], }; }; // MCP-side auth context in the shape network-scope.ts helpers take. // null = legacy global-token / open-dev mode (unscoped, allow-all). const mcpAuthCtx = enforceUserId ? { userId: enforceUserId, networkId: enforceNetworkId ?? null } : null; // If enforceNetworkId is set (ntok_), override any client-supplied // network_id. #517: for utok_ with no explicit network_id, fall back to // the user's single membership via the SAME singleNetworkId used by REST // POST /api/task (network-scope.ts) — utok_ rows carry network_id=null by // design, so without this fallback single-network nodes could read // everything but write nothing. Multi-network stays null (ambiguous) and // canWrite rejects with network_id_required. const getNetworkId = (clientNetId?: string | null) => { const explicit = enforceNetworkId ?? clientNetId ?? null; if (explicit !== null || !enforceUserId) return explicit; return singleNetworkId({ networkId: null, networkIds: getUserNetworkIds(enforceUserId) }); }; // Check write access — delegates to the shared canRestWriteNetwork so MCP // and REST cannot drift again (#517). isAdmin=false: MCP has no admin // bypass today; keep behavior identical to before the extraction. const canWrite = (effectiveNetworkId?: string | null): boolean => { const netId = enforceNetworkId ?? effectiveNetworkId ?? null; return canRestWriteNetwork(mcpAuthCtx, netId, false); }; // #517: name the REAL cause. The old catch-all blamed permissions for // what was actually an unresolvable network, sending operators down the // wrong debugging path (roles/membership) for hours. const writeDeniedReply = (effectiveNetworkId?: string | null, action = "write") => { const netId = enforceNetworkId ?? effectiveNetworkId ?? null; let error: string; let message: string; if (!netId) { const memberships = enforceUserId ? getUserNetworkIds(enforceUserId) : []; error = "network_id_required"; message = memberships.length === 0 ? "user token has no network memberships; join or create a network first" : `user token spans ${memberships.length} networks; pass network_id explicitly (see /api/auth/me networks[].network_id)`; } else if (enforceUserId && !getUserNetworkRole(enforceUserId, netId)) { error = "access_denied"; message = "access denied to requested network (not a member)"; } else { error = "permission_denied"; message = action === "send_task" ? "Viewer role cannot send tasks" : "Viewer role cannot write to this network"; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error, message }) }] }; }; const skillHubReply = (value: Record) => ({ content: [{ type: "text" as const, text: JSON.stringify(value) }], }); // SkillHub is a network registry, not a public filesystem. Content is an // immutable SKILL.md snapshot; identity comes only from the authenticated // MCP principal (never from request fields). server.tool( "submit_skill", "Submit an immutable SKILL.md version to the caller's network SkillHub. Node identity is token-bound. New submissions require review.", { slug: z.string().min(2).max(80).regex(/^[a-z0-9]+(?:-[a-z0-9]+)*$/), name: z.string().min(1).max(120), description: z.string().max(1000).optional(), version: z.string().min(1).max(40).regex(/^[0-9A-Za-z]+(?:[._-][0-9A-Za-z]+)*$/), content: z.string().min(1).max(128 * 1024).refine(value => !value.includes("\0"), "content must not contain NUL bytes"), network_id: z.string().max(200).optional(), }, async ({ slug, name, description, version, content, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); if (!effectiveNetId) return writeDeniedReply(effectiveNetId, "write"); const sourceType = callerTokenIsNetwork ? "node" : "user"; if (sourceType === "node" && !callerAlias) return skillHubReply({ ok: false, error: "node_identity_unbound" }); const contentHash = createHash("sha256").update(content, "utf8").digest("hex"); const existing = db.get( `SELECT skill_id, content_hash, status FROM skillhub_skills WHERE network_id = ?1 AND slug = ?2 AND version = ?3`, effectiveNetId, slug, version, ); if (existing) { if (existing.content_hash === contentHash) { return skillHubReply({ ok: true, idempotent: true, skill_id: existing.skill_id, status: existing.status }); } return skillHubReply({ ok: false, error: "skill_version_conflict", hint: "publish changed content under a new version" }); } const skillId = `skill_${uuidv4()}`; try { db.run( `INSERT INTO skillhub_skills (skill_id, network_id, slug, name, description, version, content, content_hash, status, source_type, source_alias, created_by_user) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, 'pending', ?9, ?10, ?11)`, [skillId, effectiveNetId, slug, name.trim(), description?.trim() || "", version, content, contentHash, sourceType, callerAlias, enforceUserId || null], ); } catch (error: any) { // Two submitters may pass the preflight SELECT together. Resolve the // UNIQUE race into the same deterministic idempotent/conflict contract // instead of leaking a storage exception as HTTP/MCP 500. if (!/unique|duplicate key/i.test(error?.message || "")) throw error; const winner = db.get( `SELECT skill_id, content_hash, status FROM skillhub_skills WHERE network_id = ?1 AND slug = ?2 AND version = ?3`, effectiveNetId, slug, version, ); if (!winner) throw error; if (winner.content_hash === contentHash) { return skillHubReply({ ok: true, idempotent: true, skill_id: winner.skill_id, status: winner.status }); } return skillHubReply({ ok: false, error: "skill_version_conflict", hint: "publish changed content under a new version" }); } db.run( `INSERT INTO audit_log (user_id, username, action, target_type, target_id, detail, network_id) VALUES (?1, ?2, 'skill_submit', 'skill', ?3, ?4, ?5)`, [enforceUserId || null, callerAlias || null, skillId, JSON.stringify({ slug, version, source_type: sourceType }), effectiveNetId], ); return skillHubReply({ ok: true, skill_id: skillId, status: "pending", source_type: sourceType, source_alias: callerAlias }); }, ); server.tool( "list_skills", "List published skills in a network. Owners/admins may include pending review items.", { network_id: z.string().max(200).optional(), include_pending: z.boolean().optional(), query: z.string().max(120).optional(), limit: z.number().int().min(1).max(200).optional(), }, async ({ network_id: clientNetId, include_pending, query, limit }) => { const effectiveNetId = getNetworkId(clientNetId); if (!effectiveNetId) return writeDeniedReply(effectiveNetId, "read"); const role = enforceUserId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (enforceUserId && !role) return writeDeniedReply(effectiveNetId, "read"); // An ntok_ belongs to a node even when it was minted by the network // owner. Never inherit the owner's review power through that token. const reviewer = !callerTokenIsNetwork && (role === "owner" || role === "admin"); const showPending = !!include_pending && reviewer; const params: unknown[] = [effectiveNetId]; let sql = `SELECT skill_id, slug, name, description, version, status, source_type, source_alias, created_at, updated_at, reviewed_at, review_note FROM skillhub_skills WHERE network_id = ?1`; if (!showPending) sql += ` AND status = 'published'`; if (query?.trim()) { params.push(`%${query.trim()}%`); sql += ` AND (slug LIKE ?${params.length} OR name LIKE ?${params.length} OR description LIKE ?${params.length})`; } sql += ` ORDER BY updated_at DESC LIMIT ${limit ?? 100}`; return skillHubReply({ ok: true, reviewer, skills: db.all(sql, ...params) }); }, ); server.tool( "get_skill", "Read one SkillHub SKILL.md. Pending content is visible only to owners/admins.", { skill_id: z.string().regex(/^skill_[A-Za-z0-9_-]+$/).max(200), network_id: z.string().max(200).optional() }, async ({ skill_id, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!effectiveNetId) return writeDeniedReply(effectiveNetId, "read"); const role = enforceUserId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (enforceUserId && !role) return writeDeniedReply(effectiveNetId, "read"); const row = db.get( `SELECT skill_id, slug, name, description, version, content, status, source_type, source_alias, created_at, updated_at, reviewed_at, review_note FROM skillhub_skills WHERE skill_id = ?1 AND network_id = ?2`, skill_id, effectiveNetId, ); if (!row) return skillHubReply({ ok: false, error: "skill_not_found" }); const reviewer = !callerTokenIsNetwork && (role === "owner" || role === "admin"); if (row.status !== "published" && !reviewer) { return skillHubReply({ ok: false, error: "skill_not_found" }); } return skillHubReply({ ok: true, skill: row }); }, ); server.tool( "review_skill", "Publish or reject a pending SkillHub submission. Network owner/admin only.", { skill_id: z.string().regex(/^skill_[A-Za-z0-9_-]+$/).max(200), decision: z.enum(["published", "rejected"]), note: z.string().max(1000).optional(), network_id: z.string().max(200).optional(), }, async ({ skill_id, decision, note, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!effectiveNetId) return writeDeniedReply(effectiveNetId, "write"); const role = enforceUserId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerTokenIsNetwork || (role !== "owner" && role !== "admin")) return skillHubReply({ ok: false, error: "skill_review_admin_required" }); const row = db.get(`SELECT status FROM skillhub_skills WHERE skill_id = ?1 AND network_id = ?2`, skill_id, effectiveNetId); if (!row) return skillHubReply({ ok: false, error: "skill_not_found" }); if (row.status !== "pending") return skillHubReply({ ok: false, error: "skill_not_pending", status: row.status }); const updated = db.run( `UPDATE skillhub_skills SET status = ?1, review_note = ?2, reviewed_by_user = ?3, reviewed_at = datetime('now'), updated_at = datetime('now') WHERE skill_id = ?4 AND network_id = ?5 AND status = 'pending'`, [decision, note?.trim() || null, enforceUserId || null, skill_id, effectiveNetId], ); if (updated.changes !== 1) return skillHubReply({ ok: false, error: "skill_not_pending" }); db.run( `INSERT INTO audit_log (user_id, username, action, target_type, target_id, detail, network_id) VALUES (?1, ?2, 'skill_review', 'skill', ?3, ?4, ?5)`, [enforceUserId || null, callerAlias || null, skill_id, JSON.stringify({ decision }), effectiveNetId], ); return skillHubReply({ ok: true, skill_id, status: decision }); }, ); const addScope = (sql: string, params: any[], networkId?: string | null, column = "network_id"): string => { if (!networkId) return sql; sql += ` AND ${column} = ?${params.length + 1}`; params.push(networkId); return sql; }; type ReadScope = { networkId?: string | null; networkIds?: string[] | null; denied?: string }; // Delegates to the shared membership query (network-scope.ts) — was a // byte-for-byte duplicate of getUserNetworkIds before #517. const getReadableNetworkIds = (): string[] => enforceUserId ? getUserNetworkIds(enforceUserId) : []; const resolveReadScope = (clientNetId?: string | null): ReadScope => { if (!enforceUserId) return { networkId: clientNetId ?? null, networkIds: null }; if (enforceNetworkId) { const role = getUserNetworkRole(enforceUserId, enforceNetworkId); return role ? { networkId: enforceNetworkId, networkIds: null } : { denied: "not a member of token network" }; } if (clientNetId) { const role = getUserNetworkRole(enforceUserId, clientNetId); return role ? { networkId: clientNetId, networkIds: null } : { denied: "access denied to requested network" }; } return { networkId: null, networkIds: getReadableNetworkIds() }; }; // RFC-027 §2.3 race-free invariant — assertNodeActive lives in // server/src/lifecycle-guard.ts so REST handlers in server/src/index.ts // can use the SAME code path. PR1.1 had it inline here; PR1.2a // (#346 review catch) extracted because the closure scope made it // unreachable from REST and left the §2.3 race open on dashboard // Dispatch (POST /api/task + /api/broadcast). Per // per team rule: grep every write site (MCP tools.ts AND REST index.ts) before adding a guard, and extract the helper into a shared module so both transports import it. const addReadScope = (sql: string, params: any[], scope: ReadScope, column = "network_id"): string => { if (scope.networkId) { sql += ` AND ${column} = ?${params.length + 1}`; params.push(scope.networkId); return sql; } if (scope.networkIds) { if (scope.networkIds.length === 0) return `${sql} AND 1=0`; const placeholders = scope.networkIds.map((_, i) => `?${params.length + i + 1}`).join(", "); sql += ` AND ${column} IN (${placeholders})`; params.push(...scope.networkIds); } return sql; }; type DeliveryTarget = | { state: "online"; alias: string; session: any } | { state: "offline"; alias: string; session: any; message: string } | { state: "not_found"; alias: string; message: string }; // Only call after the authenticated, network-scoped lookup resolved a // concrete target. Error paths intentionally omit this identity object. const actualTo = (target: Exclude, networkId?: string | null) => ({ alias: target.alias, to_node_id: target.session?.node_id ?? null, network_id: networkId ?? null, }); const scopedSessionStatus = (alias: string, networkId?: string | null) => { const params: any[] = [alias]; let sql = "SELECT status, updated_at, last_seen_at, node_id FROM sessions WHERE alias = ?1"; sql = addScope(sql, params, networkId); return db.get(sql, ...params); }; const resolveNodeIdForAlias = (alias: string, networkId?: string | null): string | null => { if (!alias || alias === "hub" || alias === "api") return null; const canonical = resolveCanonicalAlias(networkId, alias); const session = scopedSessionStatus(canonical.alias, networkId); return session?.node_id ?? null; }; const resolveDeliveryTarget = (alias: string, networkId?: string | null): DeliveryTarget => { const session = scopedSessionStatus(alias, networkId); if (!session) { return { state: "not_found", alias, message: `alias not found: ${alias}`, }; } const lastSeen = session.last_seen_at || session.updated_at; const lastSeenAt = lastSeen ? new Date(String(lastSeen).replace(" ", "T") + "Z").getTime() : 0; const stale = !lastSeenAt || Date.now() - lastSeenAt > 5 * 60 * 1000; if (String(session.status || "").toLowerCase() === "offline" || stale) { return { state: "offline", alias, session, message: `alias is offline; message queued in inbox: ${alias}`, }; } return { state: "online", alias, session }; }; const deliveryTargetReply = (target: DeliveryTarget, ids: Record = {}) => { if (target.state === "not_found") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_not_found", message: target.message, alias: target.alias, queued: false, ...ids, }), }], }; } if (target.state === "offline") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_offline", message: target.message, alias: target.alias, queued: true, session_status: target.session.status ?? "offline", ...ids, }), }], }; } return null; }; // ═══════════════════════════════════════════ // Child Agent Tools (4) // ═══════════════════════════════════════════ server.tool( "report_status", "Report agent status. Returns inbox_count so you know if there are pending tasks.", { resume_id: z.string().min(1).max(200).describe("Claude Code session UUID (unique per session)"), alias: z.string().min(1).max(200).describe("Human-readable session name for dispatching (e.g. 指挥室/知识哥)"), status: z.enum(["working", "idle", "blocked", "error", "waiting_input", "offline"]), task: z.string().max(10000).optional().describe("Current task description"), output: z.string().max(50000).optional().describe("Recent output (max 4000 chars stored)"), score: z.number().min(0).max(10).optional().describe("Self-score 1-10"), progress: z.number().min(0).max(100).optional().describe("Progress 0-100"), server: z.string().max(200).optional().describe("Server identifier"), hostname: z.string().max(200).optional().describe("Agent hostname"), agent: z.string().max(100).optional().describe("Agent type (claude-code / codex / opencode)"), project_dir: z.string().max(1000).optional().describe("Agent working directory"), version: z.string().max(100).optional().describe("Agent version"), tmux_name: z.string().max(200).optional().describe("tmux session name"), // V2 fields node_id: z.string().max(200).optional().describe("Stable node identifier"), session_id: z.string().max(200).optional().describe("Runtime session/thread ID"), config_path: z.string().max(1000).optional().describe("Config file path"), channels: z.string().max(2000).optional().describe("JSON array of channels"), model: z.string().max(200).optional().describe("AI model name"), node_name: z.string().max(200).optional().describe("Stable node display name (may differ from alias)"), network_id: z.string().max(200).optional().describe("Network this agent belongs to"), host: z.object({ hostname: z.string().max(200).optional(), ip: z.string().max(200).optional(), cpu_load_1min: z.number().nullable().optional(), cpu_cores: z.number().nullable().optional(), mem_total_gb: z.number().nullable().optional(), mem_used_gb: z.number().nullable().optional(), mem_avail_gb: z.number().nullable().optional(), disk_total_gb: z.number().nullable().optional(), disk_used_gb: z.number().nullable().optional(), disk_avail_gb: z.number().nullable().optional(), }).optional().describe("Host telemetry reported by agent-node"), process_telemetry: z.object({ rss_bytes: z.number().nullable().optional(), rss_mb: z.number().nullable().optional(), rss: z.number().nullable().optional(), cpu_pct: z.number().nullable().optional(), uptime_seconds: z.number().nullable().optional(), in_flight_count: z.number().nullable().optional(), }).optional().describe("Per-agent process telemetry reported by agent-node"), external_schedules: z.object({ observed_at: z.string().datetime({ offset: true }).max(64), schedules: z.array(z.object({ id: z.string().regex(/^[A-Za-z0-9][A-Za-z0-9._-]{0,127}$/), name: z.string().min(1).max(200), kind: z.enum(["cron", "systemd", "tmux", "playwright", "custom"]), frequency: z.string().min(1).max(120), last_run_at: z.string().datetime({ offset: true }).max(64).nullable(), last_status: z.enum(["success", "failed", "running", "unknown"]), last_error: z.string().max(500).nullable(), next_run_at: z.string().datetime({ offset: true }).max(64).nullable(), log_ref: z.string().min(1).max(255).nullable(), enabled: z.boolean(), // RFC-036 — only agent-node managed cron markers advertise write // capability. Legacy/other kinds omit these fields and stay read-only. editable: z.boolean().optional(), revision: z.number().int().min(0).optional(), }).strict()).max(64), error: z.enum(["invalid_manifest", "unsafe_manifest", "read_failed"]).optional(), }).strict().optional().describe("Bounded node-reported external schedule snapshot; never includes host paths or commands"), // RFC-024 B6 — masked snapshot of the node's effective config // (model + 6 dashboard-editable flags). Secrets ARE NOT in this // shape (env._envRef stays on host); the dashboard reads this // verbatim for the snapshot path without touching node files. // config_update_capable signals whether the node runs under a // supervisor wrapper that honours the sentinel-75 restart path // (W1) — bare-spawned agent-nodes set this to false so dashboard // can grey out remote-restart for them. config_snapshot: z.object({ model: z.string().max(200).optional().nullable(), flags: z.record(z.unknown()).optional(), config_revision: z.number().int().min(0).optional(), config_update_capable: z.boolean().optional(), peer_reply_inbox_capable: z.literal(true).optional(), // RFC-026 P2 / #338 — daemon role surfaced for hub /api/nodes // discovery (#337 extracts this field). "host_supervisor" = // anet daemon. Default-stripping zod would drop this otherwise. role: z.string().max(64).optional().nullable(), // RFC-026 §9.3 / #338 PR3 — daemon self-declare nested under // `daemon_capabilities` (canonical shape per existing hub reads // at tools.ts:2010/2075 — PR1/PR2 placed these top-level, hub // never saw them, max_concurrent_children stayed default + the // allowlists stayed unenforced. PR3 nit ① per 通信龙). // Soft caps avoid abuse via attacker daemon. daemon_capabilities: z.object({ runtimes_supported: z.array(z.string().max(64)).max(16).optional(), allowed_secret_keys: z.array(z.string().max(64)).max(64).optional(), max_concurrent_children: z.number().int().min(1).max(1000).optional(), }).optional(), }).optional().describe("RFC-024 — masked node config snapshot"), }, async ({ resume_id, alias, status, task, output, score, progress, server: srv, hostname: hn, agent: ag, project_dir: pd, version: ver, tmux_name: tmux, node_id, session_id, config_path, channels, model: mdl, node_name: nn, network_id: netId, host, process_telemetry: proc, external_schedules: externalSchedules, config_snapshot: cfgSnap }) => { const effectiveNetId = getNetworkId(netId); const sessionNetId = effectiveNetId ?? "default"; if (!callerTokenIsNetwork || !enforceNetworkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "network_token_required" }) }] }; } if (!canWrite(effectiveNetId)) { return writeDeniedReply(effectiveNetId); } const canonical = resolveCanonicalAlias(sessionNetId, alias); let effectiveAlias = canonical.alias; if (canonical.renamed) { // A stale process may keep heartbeating with the old alias after a // committed rename. If the new alias is already active, ignore the // stale report and clean the old row instead of letting it recreate // a red/orphan dashboard node (#146/#172). If not active yet, rewrite // the incoming report to the canonical alias so startup can converge. if (canonicalAliasExists(sessionNetId, effectiveAlias, resume_id)) { cleanupRenamedAliasSession(sessionNetId, alias, effectiveAlias); const pendingParams: any[] = [effectiveAlias]; let pendingSql = "SELECT COUNT(*) as cnt FROM inbox WHERE session_name = ?1 AND acked = 0"; pendingSql = addScope(pendingSql, pendingParams, effectiveNetId); const pending = db.get<{ cnt: number }>(pendingSql, ...pendingParams); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, resume_id, alias: effectiveAlias, renamed_from: alias, ignored_stale_alias: true, inbox_count: pending?.cnt ?? 0, }), }], }; } } // #203 identity guard — network tokens must not silently rebind their // own name via report_status. Without this, a runtime whose ALIAS // drifted (env leak / wrong --alias / CurrentAliasResolver seeded from // the wrong node_id) could rewrite api_tokens.name and cause every // subsequent send_task from this token to be attributed to the drifted // alias — the observed #203 symptom (grokB's send arriving as // from=grokA). Only the legit rename path (rename.ts) may cross the // token→alias binding. Symmetric to fromIdentityMismatchReply on the // send side (test198). if (callerTokenIsNetwork && callerAlias && !canonical.renamed && effectiveAlias !== callerAlias) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_identity_mismatch", message: "report_status alias does not match the token-bound node alias; use anet node rename to change identity", token_alias: callerAlias, reported_alias: effectiveAlias, }), }], }; } console.log(`[${ts()}] ${effectiveAlias} (${resume_id.slice(0, 8)}) → report_status: ${status}${task ? " | " + task.slice(0, 60) : ""}${effectiveNetId ? " [net]" : ""}${canonical.renamed ? ` [renamed from ${alias}]` : ""}`); if (callerTokenIsNetwork && callerTokenId) { try { db.run("UPDATE api_tokens SET name = ?1 WHERE token_id = ?2", [`node:${effectiveAlias}`, callerTokenId]); } catch {} } const trimmedOutput = output?.slice(0, 4000); const hostHostname = host?.hostname || hn || null; const hostIp = host?.ip || clientIP || null; const cpuLoad1m = typeof host?.cpu_load_1min === "number" ? host.cpu_load_1min : null; const cpuCores = typeof host?.cpu_cores === "number" ? host.cpu_cores : null; const memTotalGb = typeof host?.mem_total_gb === "number" ? host.mem_total_gb : null; const memUsedGb = typeof host?.mem_used_gb === "number" ? host.mem_used_gb : null; const memAvailGb = typeof host?.mem_avail_gb === "number" ? host.mem_avail_gb : null; const diskTotalGb = typeof host?.disk_total_gb === "number" ? host.disk_total_gb : null; const diskUsedGb = typeof host?.disk_used_gb === "number" ? host.disk_used_gb : null; const diskAvailGb = typeof host?.disk_avail_gb === "number" ? host.disk_avail_gb : null; const processRssBytes = typeof proc?.rss_bytes === "number" ? proc.rss_bytes : (typeof proc?.rss === "number" ? proc.rss : null); const processRssMb = typeof proc?.rss_mb === "number" ? proc.rss_mb : (typeof processRssBytes === "number" ? Math.round((processRssBytes / 1024 / 1024) * 10) / 10 : null); const processCpuPct = typeof proc?.cpu_pct === "number" ? proc.cpu_pct : null; const processUptimeSeconds = typeof proc?.uptime_seconds === "number" ? proc.uptime_seconds : null; const processInFlightCount = typeof proc?.in_flight_count === "number" ? proc.in_flight_count : null; const externalSchedulesJson = externalSchedules === undefined ? null : JSON.stringify(externalSchedules); const trustedCurrentSnapshot = node_id ? trustedConfigSnapshotForNode(cfgSnap ?? null, callerTokenId ?? null, node_id) : null; const peerReplyInboxCapable = !!( trustedCurrentSnapshot && typeof trustedCurrentSnapshot === "object" && (trustedCurrentSnapshot as Record).peer_reply_inbox_capable === true ); const statusHostTelemetry = host ? { hostname: hostHostname, ip: hostIp, cpu_load_1min: cpuLoad1m, cpu_cores: cpuCores, mem_total_gb: memTotalGb, mem_used_gb: memUsedGb, mem_avail_gb: memAvailGb, disk_total_gb: diskTotalGb, disk_used_gb: diskUsedGb, disk_avail_gb: diskAvailGb, } : null; const statusProcessTelemetry = proc ? { rss_bytes: processRssBytes, rss_mb: processRssMb, cpu_pct: processCpuPct, uptime_seconds: processUptimeSeconds, in_flight_count: processInFlightCount, } : null; db.transaction(() => { // Only delete same-alias sessions within the same network db.run("DELETE FROM sessions WHERE alias = ?1 AND resume_id != ?2 AND network_id = ?3", [effectiveAlias, resume_id, sessionNetId]); db.run( `INSERT INTO sessions (resume_id, alias, tmux_name, server, ip, hostname, agent, project_dir, version, status, task, output, progress, score, node_id, session_id, config_path, channels, network_id, model, cpu_load_1min, cpu_cores, mem_total_gb, mem_used_gb, mem_avail_gb, disk_total_gb, disk_used_gb, disk_avail_gb, process_rss_bytes, process_rss_mb, process_cpu_pct, process_uptime_seconds, process_in_flight_count, external_schedules, peer_reply_inbox_capable, last_seen_at, updated_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11, ?12, ?13, ?14, ?15, ?16, ?17, ?18, ?19, ?20, ?21, ?22, ?23, ?24, ?25, ?26, ?27, ?28, ?29, ?30, ?31, ?32, ?33, ?34, ?35, datetime('now'), datetime('now')) ON CONFLICT(resume_id) DO UPDATE SET alias = COALESCE(?2, sessions.alias), tmux_name = COALESCE(?3, sessions.tmux_name), server = COALESCE(?4, sessions.server), ip = COALESCE(?5, sessions.ip), hostname = COALESCE(?6, sessions.hostname), agent = COALESCE(?7, sessions.agent), project_dir = COALESCE(?8, sessions.project_dir), version = COALESCE(?9, sessions.version), status = ?10, task = COALESCE(?11, sessions.task), output = COALESCE(?12, sessions.output), progress = COALESCE(?13, sessions.progress), score = COALESCE(?14, sessions.score), node_id = COALESCE(?15, sessions.node_id), session_id = COALESCE(?16, sessions.session_id), config_path = COALESCE(?17, sessions.config_path), channels = COALESCE(?18, sessions.channels), network_id = COALESCE(?19, sessions.network_id), model = COALESCE(?20, sessions.model), cpu_load_1min = COALESCE(?21, sessions.cpu_load_1min), cpu_cores = COALESCE(?22, sessions.cpu_cores), mem_total_gb = COALESCE(?23, sessions.mem_total_gb), mem_used_gb = COALESCE(?24, sessions.mem_used_gb), mem_avail_gb = COALESCE(?25, sessions.mem_avail_gb), disk_total_gb = COALESCE(?26, sessions.disk_total_gb), disk_used_gb = COALESCE(?27, sessions.disk_used_gb), disk_avail_gb = COALESCE(?28, sessions.disk_avail_gb), process_rss_bytes = COALESCE(?29, sessions.process_rss_bytes), process_rss_mb = COALESCE(?30, sessions.process_rss_mb), process_cpu_pct = COALESCE(?31, sessions.process_cpu_pct), process_uptime_seconds = COALESCE(?32, sessions.process_uptime_seconds), process_in_flight_count = COALESCE(?33, sessions.process_in_flight_count), external_schedules = COALESCE(?34, sessions.external_schedules), peer_reply_inbox_capable = ?35, last_seen_at = datetime('now'), updated_at = datetime('now')`, [resume_id, effectiveAlias, tmux ?? null, srv ?? null, hostIp, hostHostname, ag ?? null, pd ?? null, ver ?? null, status, task ?? null, trimmedOutput ?? null, progress ?? null, score ?? null, node_id ?? null, session_id ?? null, config_path ?? null, channels ?? null, sessionNetId, mdl ?? null, cpuLoad1m, cpuCores, memTotalGb, memUsedGb, memAvailGb, diskTotalGb, diskUsedGb, diskAvailGb, processRssBytes, processRssMb, processCpuPct, processUptimeSeconds, processInFlightCount, externalSchedulesJson, peerReplyInboxCapable ? 1 : 0] ); if (host || proc) { db.run( `INSERT INTO agent_telemetry (id, network_id, resume_id, alias, hostname, ip, cpu_load_1min, cpu_cores, mem_total_gb, mem_used_gb, mem_avail_gb, disk_total_gb, disk_used_gb, disk_avail_gb, process_rss_bytes, process_rss_mb, process_cpu_pct, process_uptime_seconds, process_in_flight_count, created_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11, ?12, ?13, ?14, ?15, ?16, ?17, ?18, ?19, datetime('now'))`, [uuidv4(), sessionNetId, resume_id, effectiveAlias, hostHostname, hostIp, cpuLoad1m, cpuCores, memTotalGb, memUsedGb, memAvailGb, diskTotalGb, diskUsedGb, diskAvailGb, processRssBytes, processRssMb, processCpuPct, processUptimeSeconds, processInFlightCount] ); } }); pushEvent(effectiveAlias, { type: "status_update", alias: effectiveAlias, ...(canonical.renamed ? { renamed_from: alias } : {}), status, progress: progress ?? null, host: statusHostTelemetry, process_telemetry: statusProcessTelemetry, }, sessionNetId); // V2: sync tasks table — report_status(working) → tasks.running if (status === "working" && task) { try { const runParams: any[] = [effectiveAlias, task]; let runSql = `UPDATE tasks SET status = 'running', started_at = datetime('now') WHERE to_name = ?1 AND status IN ('delivered', 'acked') AND content = ?2`; runSql = addScope(runSql, runParams, effectiveNetId); const runResult = db.run(runSql, runParams); if (runResult.changes > 0) { // Find task_id for logging const findParams: any[] = [effectiveAlias, task]; let findSql = "SELECT task_id FROM tasks WHERE to_name = ?1 AND content = ?2 AND status = 'running'"; findSql = addScope(findSql, findParams, effectiveNetId); findSql += " ORDER BY started_at DESC LIMIT 1"; const t = db.get<{ task_id: string }>(findSql, ...findParams); if (t) logTaskEvent(t.task_id, null, "running", effectiveAlias); } } catch {} } // V2: upsert nodes table for persistent node identity. SEC-1 // gate (PR A #287 follow-up, 通信牛 catch 2026-06-28): delegate // to upsertNodeWithSec1Guard so production + test exercise the // exact same code path. See helper below registerTools. if (node_id) { try { const nodeRuntime = ag?.includes(":") ? ag.split(":")[1] + "-sdk" : ag ?? null; upsertNodeWithSec1Guard({ node_id, callerNetworkId: effectiveNetId ?? null, callerUserId: enforceUserId ?? null, callerTokenId: callerTokenId ?? null, node_name: nn || effectiveAlias, alias: effectiveAlias, runtime: nodeRuntime, model: mdl ?? null, config_path: config_path ?? null, channels: channels ?? null, server: srv ?? null, hostname: hn ?? null, config_snapshot: cfgSnap ?? null, }); } catch {} } // inbox uses alias for routing const inboxParams: any[] = [effectiveAlias]; let inboxSql = "SELECT COUNT(*) as cnt FROM inbox WHERE session_name = ?1 AND acked = 0"; inboxSql = addScope(inboxSql, inboxParams, effectiveNetId); const row = db.get<{ cnt: number }>(inboxSql, ...inboxParams); return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, resume_id, alias: effectiveAlias, ...(canonical.renamed ? { renamed_from: alias } : {}), inbox_count: row?.cnt ?? 0, }), }, ], }; } ); server.tool( "report_completion", "Report task completion with results and optional artifacts.", { alias: z.string().min(1).max(200).describe("Session alias"), task: z.string().min(1).max(10000).describe("Completed task description"), result: z.string().min(1).max(50000).describe("Result summary"), artifacts: z.array(z.string().max(2000)).max(50).optional().describe("Output URLs or file paths"), score: z.number().min(0).max(10).optional(), duration_minutes: z.number().min(0).optional(), network_id: z.string().max(200).optional().describe("Network scope"), }, async ({ alias, task, result, artifacts, score, duration_minutes, network_id: netId }) => { const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) { return writeDeniedReply(effectiveNetId); } console.log(`[${ts()}] ${alias} → report_completion: ${task.slice(0, 60)}${effectiveNetId ? " [net]" : ""}`); const id = uuidv4(); let updatedTaskId: string | null = null; db.transaction(() => { db.run( `INSERT INTO completions (id, session_name, task, result, artifacts, score, duration_minutes, network_id) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8)`, [id, alias, task, result, artifacts ? JSON.stringify(artifacts) : null, score ?? null, duration_minutes ?? null, effectiveNetId ?? null] ); const sessionParams: any[] = [alias]; let sessionSql = `UPDATE sessions SET status = 'idle', task = NULL, progress = 0, updated_at = datetime('now') WHERE alias = ?1`; sessionSql = addScope(sessionSql, sessionParams, effectiveNetId); db.run(sessionSql, sessionParams); // V2: sync tasks table — try by task_id first, then by content const taskParams: any[] = [result.slice(0, 4000), task]; let taskSql = `UPDATE tasks SET status = 'replied', result = ?1, completed_at = datetime('now') WHERE task_id = ?2 AND status IN ('delivered', 'acked', 'running')`; taskSql = addScope(taskSql, taskParams, effectiveNetId); const tu = db.run(taskSql, taskParams); if (tu.changes === 0) { const matchParams: any[] = [alias, task]; let matchSql = `SELECT task_id FROM tasks WHERE to_name = ?1 AND content = ?2 AND status IN ('delivered', 'acked', 'running')`; matchSql = addScope(matchSql, matchParams, effectiveNetId); matchSql += " ORDER BY created_at DESC LIMIT 1"; const match = db.get<{ task_id: string }>(matchSql, ...matchParams); if (match) { const matchUpdateParams: any[] = [result.slice(0, 4000), match.task_id]; let matchUpdateSql = "UPDATE tasks SET status = 'replied', result = ?1, completed_at = datetime('now') WHERE task_id = ?2"; matchUpdateSql = addScope(matchUpdateSql, matchUpdateParams, effectiveNetId); db.run(matchUpdateSql, matchUpdateParams); updatedTaskId = match.task_id; } } else { updatedTaskId = task; } if (updatedTaskId) syncScheduledRunForTask(updatedTaskId, effectiveNetId); }); // Log event after transaction if (updatedTaskId) logTaskEvent(updatedTaskId, null, "replied", alias, "report_completion"); // Auto-chain to parent lineage (mirror of send_reply path). // round5 F2: pass caller's effectiveNetId so the chain refuses // to write across tenants if some upstream parent links to a // foreign network. // // round5 follow-up (通信牛 SSE leak catch): gate the SSE push on // `result.chained` — if the chain refused (cross-network), the // subsequent SELECT of `parent.from_name` + `pushEvent(..., // parent.task_id)` would leak the foreign parent's task_id into // the caller's network via the SSE payload. Skip the push when // the chain didn't actually write. if (updatedTaskId) { try { const chainResult = chainReplyToParent(updatedTaskId, result, "replied", 5, effectiveNetId); if (chainResult.chained) { const parentChain = db.get<{ parent_task_id: string | null }>( "SELECT parent_task_id FROM tasks WHERE task_id = ?1", [updatedTaskId] ); if (parentChain?.parent_task_id) { const parent = db.get<{ from_name: string; task_id: string }>( "SELECT from_name, task_id FROM tasks WHERE task_id = ?1", [parentChain.parent_task_id] ); if (parent?.from_name && parent.from_name !== "hub" && parent.from_name !== "api") { pushEvent(parent.from_name, { type: "chained_reply", parent_task_id: parent.task_id, child_task_id: updatedTaskId, child_alias: alias }, effectiveNetId); } } } } catch (e: any) { console.log(`[${ts()}] ⚠ chainReplyToParent (completion) failed: ${e.message}`); } } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, completion_id: id }) }], }; } ); server.tool( "get_inbox", "Get pending commands for your session.", { alias: z.string().min(1).max(200).describe("Session alias"), limit: z.number().min(1).max(100).optional().default(10), }, async ({ alias, limit }) => { const readScope = resolveReadScope(null); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; const countParams: any[] = [alias]; let countSql = "SELECT COUNT(*) as cnt FROM inbox WHERE session_name = ?1 AND acked = 0"; countSql = addReadScope(countSql, countParams, readScope); const rows0 = db.get<{ cnt: number }>(countSql, ...countParams); console.log(`[${ts()}] ${alias} → get_inbox: ${rows0?.cnt ?? 0} pending messages`); const rowsParams: any[] = [alias]; let rowsSql = `SELECT id, type, priority, content, context, from_session, created_at, network_id, meta_json, CASE WHEN type = 'task' THEN COALESCE(task_id, id) ELSE task_id END AS task_id FROM inbox WHERE session_name = ?1 AND acked = 0`; rowsSql = addReadScope(rowsSql, rowsParams, readScope); rowsSql += ` ORDER BY CASE priority WHEN 'high' THEN 0 WHEN 'normal' THEN 1 ELSE 2 END, created_at LIMIT ?${rowsParams.length + 1}`; rowsParams.push(limit); const rows = db.all(rowsSql, ...rowsParams).map((row: any) => ({ ...row, meta: parseMetaJson(row.meta_json), })); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, messages: rows }) }], }; } ); server.tool( "ack_inbox", "Acknowledge receipt of a command.", { alias: z.string().min(1).max(200).describe("Session alias"), message_id: z.string().min(1).max(200), response: z.string().max(10000).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ alias, message_id, response, network_id: netId }) => { const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] ${alias} → ack_inbox: ${message_id.slice(0, 8)}`); // New task consumers ACK by the logical tasks.task_id exposed by // get_inbox. Keep exact inbox.id support for legacy consumers and for // non-task messages. Restrict the lookup to pending rows: after a retry // the original row can have id == task_id but is already ACKed, while // the current row has a fresh transport id and the same logical task_id. const inboxTaskParams: any[] = [message_id, alias]; let inboxTaskSql = `SELECT id, type, COALESCE(task_id, id) AS task_id FROM inbox WHERE session_name = ?2 AND acked = 0 AND (id = ?1 OR (type = 'task' AND task_id = ?1))`; inboxTaskSql = addScope(inboxTaskSql, inboxTaskParams, effectiveNetId); inboxTaskSql += " ORDER BY created_at DESC LIMIT 1"; const inboxTask = db.get<{ id: string; type: string; task_id: string }>(inboxTaskSql, ...inboxTaskParams); if (!inboxTask) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "message not found or already acknowledged" }) }], }; } const ackParams: any[] = [inboxTask.id, alias]; let ackSql = "UPDATE inbox SET acked = 1 WHERE id = ?1 AND session_name = ?2 AND acked = 0"; ackSql = addScope(ackSql, ackParams, effectiveNetId); const result = db.run(ackSql, ackParams); if (result.changes === 0) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "message not found or not yours" }) }], }; } // V2: sync tasks table — ack_inbox means delivered→acked try { if (inboxTask?.type !== "task") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true }) }] }; } const taskParams: any[] = [inboxTask.task_id]; let taskSql = "UPDATE tasks SET status = 'acked' WHERE task_id = ?1 AND status = 'delivered'"; taskSql = addScope(taskSql, taskParams, effectiveNetId); const ackResult = db.run(taskSql, taskParams); if (ackResult.changes > 0) logTaskEvent(inboxTask.task_id, "delivered", "acked", alias); } catch {} return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true }) }], }; } ); // #520 — two monotonic runtime-evidence levels for exact tasks. // // runtime_submitted_at means agent-node handed the body to the vendor // runtime. consumed_at is stronger: an attributable turn-start or first // activity event came back. Merely fetching/acking an inbox row sets neither. // Node identity comes exclusively from the ntok; callers cannot self-report // an alias or node_id. A consumed mark also fills runtime_submitted_at because // that stronger fact logically implies submission. const markTaskRuntimeEvidence = ( taskIds: string[], level: "submitted" | "consumed", ) => { const task_ids = taskIds; if (!callerTokenIsNetwork || !callerAlias || !enforceNetworkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "node_token_required" }) }], }; } // PgAdapter.transaction currently opens a fresh subprocess/connection // per statement. The all-or-nothing batch promise cannot be made there; // refuse evidence rather than publish a partially stamped batch. if (db.dialect !== "sqlite") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "task_runtime_evidence_backend_unsupported", }) }], }; } const uniqueTaskIds = [...new Set(task_ids)]; if (uniqueTaskIds.length !== task_ids.length) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "duplicate_task_id" }) }], }; } const placeholders = uniqueTaskIds.map((_, i) => `?${i + 2}`).join(", "); // Keep ownership preflight and every stamp in one SQLite transaction. // This closes the cross-process preflight→UPDATE race: no other writer // can reassign a task between the identity decision and the write. const outcome = db.transaction(() => { const canonicalCaller = resolveCanonicalAlias(enforceNetworkId, callerAlias).alias; const callerSession = db.get<{ node_id: string | null }>( `SELECT node_id FROM sessions WHERE network_id = ?1 AND alias = ?2 ORDER BY updated_at DESC LIMIT 1`, enforceNetworkId, canonicalCaller, ); const rows = db.all<{ task_id: string; to_node_id: string | null; to_name: string }>( `SELECT task_id, to_node_id, to_name FROM tasks WHERE network_id = ?1 AND task_id IN (${placeholders})`, enforceNetworkId, ...uniqueTaskIds, ); const owned = new Map(rows.map((row) => [row.task_id, row])); const rejectedTaskId = uniqueTaskIds.find((taskId) => { const row = owned.get(taskId); if (!row) return true; // Prefer immutable node identity whenever the task has one. Direct // and legacy token-bound sessions legitimately have NULL node_id; // only that shape may fall back to the canonical token alias. if (row.to_node_id) return row.to_node_id !== callerSession?.node_id; return resolveCanonicalAlias(enforceNetworkId, row.to_name).alias !== canonicalCaller; }); if (rejectedTaskId) { return { ok: false as const, error: "task_not_owned", task_id: rejectedTaskId }; } for (const taskId of uniqueTaskIds) { const row = owned.get(taskId)!; const ownershipSql = row.to_node_id ? "to_node_id = ?3" : "to_node_id IS NULL AND to_name = ?3"; const ownerValue = row.to_node_id ?? row.to_name; let updateResult; if (level === "consumed") { updateResult = db.run( `UPDATE tasks SET runtime_submitted_at = COALESCE(runtime_submitted_at, datetime('now')), consumed_at = COALESCE(consumed_at, datetime('now')) WHERE network_id = ?1 AND task_id = ?2 AND ${ownershipSql}`, [enforceNetworkId, taskId, ownerValue], ); } else { updateResult = db.run( `UPDATE tasks SET runtime_submitted_at = COALESCE(runtime_submitted_at, datetime('now')) WHERE network_id = ?1 AND task_id = ?2 AND ${ownershipSql}`, [enforceNetworkId, taskId, ownerValue], ); } if (updateResult.changes !== 1) { // A zero-row write after a successful preflight is an invariant // failure, never a successful evidence report. throw new Error(`task_runtime_evidence_write_race:${taskId}`); } } const evidenceRows = db.all<{ task_id: string; runtime_submitted_at: string; consumed_at: string | null; }>( `SELECT task_id, runtime_submitted_at, consumed_at FROM tasks WHERE network_id = ?1 AND task_id IN (${placeholders})`, enforceNetworkId, ...uniqueTaskIds, ); return { ok: true as const, tasks: evidenceRows }; }); return { content: [{ type: "text" as const, text: JSON.stringify(outcome), }], }; }; const taskRuntimeEvidenceSchema = { task_ids: z.array(z.string().min(1).max(200)).min(1).max(100), }; server.tool( "mark_tasks_runtime_submitted", "Internal agent-node signal: exact task bodies were submitted to this token-bound node's vendor runtime.", taskRuntimeEvidenceSchema, async ({ task_ids }) => markTaskRuntimeEvidence(task_ids, "submitted"), ); server.tool( "mark_tasks_consumed", "Internal agent-node signal: exact tasks produced attributable turn-start/activity evidence in this token-bound node's runtime.", taskRuntimeEvidenceSchema, async ({ task_ids }) => markTaskRuntimeEvidence(task_ids, "consumed"), ); // ═══════════════════════════════════════════ // Hub Tools (5) // ═══════════════════════════════════════════ server.tool( "get_all_status", "Get status of all sessions. Hub uses this for the patrol loop. " + "Pass filter_alias (comma-separated) when you only care about specific " + "nodes — the unfiltered result is one row per session with 31 columns and " + "is large enough on a real fleet that callers cannot read it.", { filter_status: z.string().max(50).optional(), filter_server: z.string().max(200).optional(), // 2026-08-17: on a 222-session hub the unfiltered response is ~259 KB, past // what an MCP client can take in one result — so the caller that wanted the // status of THREE nodes could not get it from this tool at all. The patrol // loop still wants everything, hence optional rather than required. filter_alias: z.string().max(2000).optional() .describe("One alias, or several separated by commas. Exact matches only."), network_id: z.string().max(200).optional().describe("Filter by network"), }, async ({ filter_status, filter_server, filter_alias, network_id: netId }) => { const readScope = resolveReadScope(netId); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; console.log(`[${ts()}] hub → get_all_status${filter_status ? ": filter=" + filter_status : ""}${filter_alias ? " alias=" + filter_alias.slice(0, 80) : ""}${readScope.networkId ? " net=" + readScope.networkId.slice(0, 12) : ""}`); // Round-2/4 review ③: stale-marking moved to startStaleSessionSweeper() // (background timer, ~60s cadence). Read path no longer fires UPDATE. let sql = "SELECT * FROM sessions WHERE 1=1"; const params: any[] = []; sql = addReadScope(sql, params, readScope); if (filter_status) { sql += " AND status = ?"; params.push(filter_status); } if (filter_server) { sql += " AND server = ?"; params.push(filter_server); } const aliasFilter = parseAliasFilter(filter_alias); const aliases = aliasFilter.aliases; if (aliasFilter.sql) { sql += aliasFilter.sql; params.push(...aliases); } sql += " ORDER BY updated_at DESC"; const sessions = db.all(sql, ...params); // `summary` has always counted every session in the read scope, ignoring // filter_status / filter_server — and now filter_alias. That is fine for // the patrol loop, but a caller who asked about three aliases and gets // back three rows plus "idle: 96" can easily read the 96 as being about // their three. A count that does not say what it counted invites exactly // that. So the response now says so, rather than the semantics changing // under existing callers. const summaryParams: any[] = []; let summarySql = "SELECT status, COUNT(*) as count FROM sessions WHERE 1=1"; summarySql = addReadScope(summarySql, summaryParams, readScope); summarySql += " GROUP BY status"; const summary = db.all(summarySql, ...summaryParams); const filtered = !!(filter_status || filter_server || aliases.length > 0); return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, sessions, summary, summary_scope: filtered ? "every session in the read scope — NOT narrowed by the filters applied to `sessions`" : "every session in the read scope", sessions_returned: sessions.length, }), }, ], }; } ); server.tool( "get_session_status", "Get detailed status of a specific session by alias.", { alias: z.string().min(1).max(200).describe("Session alias") }, async ({ alias }) => { const readScope = resolveReadScope(null); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; console.log(`[${ts()}] hub → get_session_status: ${alias}`); const sessionParams: any[] = [alias]; let sessionSql = "SELECT * FROM sessions WHERE alias = ?1"; sessionSql = addReadScope(sessionSql, sessionParams, readScope); const session = db.get(sessionSql, ...sessionParams); const pendingParams: any[] = [alias]; let pendingSql = "SELECT COUNT(*) as cnt FROM inbox WHERE session_name = ?1 AND acked = 0"; pendingSql = addReadScope(pendingSql, pendingParams, readScope); const pending = db.get<{ cnt: number }>(pendingSql, ...pendingParams); const recentParams: any[] = [alias]; let recentSql = "SELECT * FROM completions WHERE session_name = ?1"; recentSql = addReadScope(recentSql, recentParams, readScope); recentSql += " ORDER BY completed_at DESC LIMIT 5"; const recent = db.all(recentSql, ...recentParams); return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, session, inbox_pending: pending?.cnt ?? 0, recent_completions: recent }), }, ], }; } ); server.tool( "send_task", "Dispatch a task to a session's inbox (by alias).", { alias: z.string().min(1).max(200).describe("Target session alias"), task: z.string().min(1).max(10000).describe("Task content"), priority: z.enum(["high", "normal", "low"]).optional().default("normal"), context: z.string().max(10000).optional(), from_session: z.string().max(200).optional(), ttl_seconds: z.number().min(1).max(86400).optional().describe("Task TTL in seconds (default: 3600)"), network_id: z.string().max(200).optional().describe("Network scope"), parent_task_id: z.string().max(200).optional().describe("Parent task this dispatch is on behalf of. When the child task replies the hub will auto-chain the answer to the parent task's originator, so the user sees the final result even if the intermediate session ends."), meta: z.any().optional().describe("Optional structured task metadata, e.g. { attachments: [{ type, path, url, mime, name, size }] }."), }, async ({ alias, task, priority, context, from_session: _fromIn, ttl_seconds, network_id: netId, parent_task_id: parentIn, meta }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); const authOrigin: TaskAuthOrigin = callerTokenIsNetwork ? "node" : enforceUserId ? "user" : "legacy"; const metaJson = normalizeMetaJson(stampTaskAuthOrigin(meta, authOrigin)); // Role check FIRST — round5 follow-up (通信牛 oracle catch): // the explicit-parent verification below distinguishes // `cross_network_parent` from `permission_denied`. If we ran the // parent lookup before canWrite, a viewer role could probe parent // existence + ownership of foreign parents via the difference in // error codes. Run canWrite first so a viewer ALWAYS gets the // same `permission_denied` regardless of parent state. if (!canWrite(effectiveNetId)) { return writeDeniedReply(effectiveNetId, "send_task"); } // Resolve parent_task_id: explicit > inferred (caller's most recent // delivered/started inbox task that's still open). Inference is the // safety net for when the LLM forgets to pass parent_task_id. // // round5 F1 fix: the inference SELECT MUST be network-scoped. Without // it, a caller in network B can pick up the parent_task_id of a // network A dispatch and chain-reply into the wrong tenant. The // explicit-parent path is verified below in F2. let parentTaskId: string | null = parentIn ?? null; if (!parentTaskId && from_session && from_session !== "hub" && from_session !== "api") { try { const recentParams: any[] = [from_session]; let recentSql = "SELECT task_id FROM tasks WHERE to_name = ?1 AND status IN ('delivered','started')"; recentSql = addScope(recentSql, recentParams, effectiveNetId); recentSql += " ORDER BY created_at DESC LIMIT 1"; const recent = db.get<{ task_id: string }>(recentSql, ...recentParams); if (recent?.task_id) parentTaskId = recent.task_id; } catch {} } // round5 F2 fix: an explicit parent_task_id must belong to the // caller's network. Otherwise a malicious caller in network B can // hand us a parent id from network A and have chainReplyToParent // (db.ts) write back into A's task result + inbox — cross-tenant // write. Verify ownership, reject on mismatch. if (parentIn) { const parentRow = db.get<{ network_id: string | null }>( "SELECT network_id FROM tasks WHERE task_id = ?1", [parentIn] ); if (!parentRow) { // Parent doesn't exist (LLM hallucination, race with retention // sweep, etc.). Drop the link silently so the dispatch can // still proceed; the LLM may have meant to dispatch fresh. console.log(`[${ts()}] ⚠ send_task: parent_task_id=${parentIn.slice(0, 8)} not found, dropping parent link`); parentTaskId = null; } else if ((parentRow.network_id ?? null) !== (effectiveNetId ?? null)) { console.log(`[${ts()}] 🚫 send_task: cross-network parent rejected, parent=${parentIn.slice(0, 8)} parent-net=${parentRow.network_id ?? "null"} caller-net=${effectiveNetId ?? "null"}`); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_parent", message: "parent_task_id belongs to a different network", }) }] }; } } // License check const license = db.get("SELECT type, expires_at FROM licenses ORDER BY created_at LIMIT 1"); if (license?.expires_at) { const now = new Date().toISOString().replace("T", " ").slice(0, 19); if (license.expires_at < now) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "license_expired", message: "Trial expired. Activate a license: anet activate ", }) }] }; } } const canonical = resolveCanonicalAlias(effectiveNetId, alias); const targetAlias = canonical.alias; const target = resolveDeliveryTarget(targetAlias, effectiveNetId); if (target.state === "not_found") return deliveryTargetReply(target)!; // Dashboard sends carry a random client_request_id inside meta. Derive // the task primary key from authenticated scope + that request id so a // lost HTTP response can be retried safely, even after a hub restart. // The existing row must match the full request; key reuse with changed // content/target fails closed instead of silently returning another task. const clientRequestId = clientRequestIdFromMeta(meta); const id = clientRequestId ? idempotentTaskId(effectiveNetId ?? null, from_session, clientRequestId) : uuidv4(); if (clientRequestId) { const existing = db.get( "SELECT task_id, from_name, to_node_id, to_name, priority, content, network_id, meta_json, status FROM tasks WHERE task_id = ?1", [id], ); if (existing) { if (!idempotentTaskMatches(existing, { fromName: from_session, toName: targetAlias, priority, content: task, networkId: effectiveNetId ?? null, metaJson, })) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "idempotency_conflict", message: "client_request_id was already used with a different task payload", }) }] }; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, message_id: existing.task_id, task_id: existing.task_id, task_status: existing.status, idempotent_replay: true, // A replay acknowledges the already-persisted dispatch. Use that // row rather than today's session record so alias reuse or a // restarted process cannot rewrite historical recipient identity. actual_to: { alias: existing.to_name, to_node_id: existing.to_node_id ?? null, network_id: existing.network_id ?? null, }, }) }] }; } } // #212 dedup guardrail. If this exact (from, to, content) has already // been delivered within COMMHUB_SEND_DEDUP_WINDOW_MS (default 5 min) // we refuse the call and surface a structured `duplicate_send` // error. The LLM receives the Chinese hint inside details.message // and can act on it (rewrite the task or wait). See A站Grok #212 // incident: 50+ identical dispatches across 5 LLM turns ignored // three STOP replies — the LLM cannot be trusted to debounce // itself, so the runtime layer must. const dedup = sharedSendDedup.check(from_session, targetAlias, task); if (dedup.duplicate) { const payload = buildDuplicateSendPayload({ from: from_session, to: targetAlias, ageMs: dedup.ageMs, windowMs: sharedSendDedup.windowMs, }); console.log(`[${ts()}] ${from_session} → send_task → ${targetAlias}: DROPPED duplicate (age=${dedup.ageMs}ms, window=${sharedSendDedup.windowMs}ms)`); return { content: [{ type: "text" as const, text: JSON.stringify(payload) }] }; } // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 1/6). { const lc = assertNodeActive(targetAlias, effectiveNetId ?? null); if (!lc.ok) return { content: [{ type: "text" as const, text: JSON.stringify(lc) }] }; } console.log(`[${ts()}] ${from_session} → send_task → ${targetAlias}: ${task.slice(0, 60)}${priority === "high" ? " [HIGH]" : ""}${canonical.renamed ? ` [renamed from ${alias}]` : ""}`); const fromNodeId = resolveNodeIdForAlias(from_session, effectiveNetId); const targetNodeId = target.session?.node_id ?? null; const resolvedActualTo = actualTo(target, effectiveNetId); // 事务:inbox + tasks 双写 + 触碰目标 session 的 task/updated_at(让 // dashboard 在派任务一刻就反映出"任务已下发",不再等 agent 的 // report_status 心跳;status 字段交给 agent,避免与 working/idle // 报告冲突)。 db.transaction(() => { db.run( `INSERT INTO inbox (id, task_id, session_name, node_id, type, priority, content, context, from_session, requires_response, network_id, meta_json) VALUES (?1, ?1, ?2, ?3, 'task', ?4, ?5, ?6, ?7, 'reply', ?8, ?9)`, [id, targetAlias, targetNodeId, priority, task, context ?? null, from_session, effectiveNetId ?? null, metaJson] ); db.run( `INSERT INTO tasks (task_id, from_node_id, from_name, to_node_id, to_name, priority, status, content, requires_response, created_at, delivered_at, expires_at, network_id, parent_task_id, meta_json) VALUES (?1, ?2, ?3, ?4, ?5, ?6, 'delivered', ?7, 'reply', datetime('now'), datetime('now'), datetime('now', ?8), ?9, ?10, ?11)`, [id, fromNodeId, from_session, targetNodeId, targetAlias, priority, task, `+${ttl_seconds || 3600} seconds`, effectiveNetId ?? null, parentTaskId, metaJson] ); const touchParams: any[] = [task.slice(0, 200), targetAlias]; let touchSql = "UPDATE sessions SET task = ?1, updated_at = datetime('now') WHERE alias = ?2"; touchSql = addScope(touchSql, touchParams, effectiveNetId); db.run(touchSql, touchParams); }); logTaskEvent(id, null, "delivered", from_session, parentTaskId ? `→ ${targetAlias} (parent=${parentTaskId.slice(0,8)})` : `→ ${targetAlias}`); // Only stamp the dedup index after the inbox/tasks transaction // succeeds, so a failed insert never silently shadows a legitimate // retry. sharedSendDedup.record(from_session, targetAlias, task); // SSE push by alias. // The SSE channel is keyed by alias (subscribers connected to /events/), // not by network_id. Earlier we gated the push on a network-scoped session // lookup, which silently dropped pushes whenever an agent registered with // network_id=null but the sender supplied an explicit network_id (the // exact mismatch hit by Dashboard tasks). Push unconditionally; the // subscriber's own auth (ntok_) constrains who can listen. const pendingParams: any[] = [targetAlias]; let pendingSql = "SELECT COUNT(*) as cnt FROM inbox WHERE session_name = ?1 AND acked = 0"; pendingSql = addScope(pendingSql, pendingParams, effectiveNetId); const pending = db.get<{ cnt: number }>(pendingSql, ...pendingParams); if (target.state === "online") { pushEvent(targetAlias, { type: "new_task", inbox_count: pending?.cnt ?? 1, priority, from: from_session, ...(canonical.renamed ? { renamed_from: alias } : {}) }, effectiveNetId); } // #461 network observer summary — unconditional (task row exists // even when the target is offline/queued), metadata only. pushNetworkObserverEvent(effectiveNetId, { type: "new_task", task_id: id, from: from_session, to: targetAlias, status: target.state === "online" ? "delivered" : "queued", priority }); if (target.state === "offline") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_offline", message: target.message, alias: targetAlias, queued: true, task_id: id, message_id: id, session_status: target.session.status ?? "offline", actual_to: resolvedActualTo, ...(canonical.renamed ? { renamed_from: alias, renamed_to: targetAlias } : {}), }), }], }; } return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, message_id: id, actual_to: resolvedActualTo, ...(canonical.renamed ? { renamed_from: alias, renamed_to: targetAlias } : {}), session_status: target.session?.status ?? "unknown", }), }, ], }; } ); server.tool( "send_message", "Send a message to a session (no task lifecycle, just chat). Use for replies, status updates, or casual communication.", { alias: z.string().min(1).max(200).describe("Target session alias"), message: z.string().min(1).max(10000).describe("Message content"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ alias, message, from_session: _fromIn, network_id: netId }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); const canonical = resolveCanonicalAlias(effectiveNetId, alias); const targetAlias = canonical.alias; const target = resolveDeliveryTarget(targetAlias, effectiveNetId); if (target.state === "not_found") return deliveryTargetReply(target)!; // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 2/6). { const lc = assertNodeActive(targetAlias, effectiveNetId ?? null); if (!lc.ok) return { content: [{ type: "text" as const, text: JSON.stringify(lc) }] }; } console.log(`[${ts()}] ${from_session} → send_message → ${targetAlias}: ${message.slice(0, 60)}${canonical.renamed ? ` [renamed from ${alias}]` : ""}`); const id = uuidv4(); db.run( `INSERT INTO inbox (id, session_name, node_id, type, priority, content, from_session, network_id) VALUES (?1, ?2, ?3, 'message', 'normal', ?4, ?5, ?6)`, [id, targetAlias, target.session?.node_id ?? null, message, from_session, effectiveNetId ?? null] ); if (target.state === "online") { pushEvent(targetAlias, { type: "new_message", from: from_session, message_id: id, ...(canonical.renamed ? { renamed_from: alias } : {}) }, effectiveNetId); } const offlineReply = deliveryTargetReply(target, { message_id: id }); if (offlineReply) { const payload = JSON.parse(offlineReply.content[0].text); offlineReply.content[0].text = JSON.stringify({ ...payload, ...(canonical.renamed ? { renamed_from: alias, renamed_to: targetAlias } : {}), }); return offlineReply; } return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, message_id: id, ...(canonical.renamed ? { renamed_from: alias, renamed_to: targetAlias } : {}), session_status: target.session?.status ?? "unknown", }), }, ], }; } ); // ── V2/V3 reply primitives ── const replyToolSchema = { alias: z.string().min(1).max(200).describe("Target session alias"), text: z.string().min(1).max(10000).describe("Reply content"), in_reply_to: z.string().max(200).optional().describe("Original task/message ID"), status: z.enum(["replied", "failed", "cancelled"]).optional().default("replied").describe("Task outcome"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), // #507 — top-level attachments (parity with REST /api/task L506). MCP Zod // otherwise silently strips unknown fields, so a caller passing // `attachments` before this schema entry existed would see `ok:true` // and never learn the attachments were dropped. Validated by // validateAttachments (uploads.ts) — the same helper the REST path uses. attachments: z.any().optional().describe("Optional attachment array; parity with send_task's meta.attachments. Each item: {type:'file', file_id, name?, mime?, size?}. Persisted into tasks.meta_json + inbox.meta_json."), // #507 — optional structured metadata (parity with send_task L837). If // both `attachments` (top-level) and `meta.attachments` are supplied, // top-level wins (same rule as REST /api/task L2101). meta: z.any().optional().describe("Optional structured reply metadata, e.g. { attachments: [...] }."), }; const handleReply = async (args: any, peerCapabilityRequired: boolean) => { const { alias, text, in_reply_to, status: replyStatus = "replied", from_session: _fromIn, network_id: netId, attachments, meta } = args; const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); if (peerCapabilityRequired && !in_reply_to) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "peer_reply_task_required" }) }] }; } // #507 — validate attachments BEFORE any DB write. Rejects malformed // input (bad file_id, >20 items, size > cap, non-object item, wrong // type field) with an explicit error the caller can act on. Empty / // absent attachments return { ok: true, attachments: [] } — the // reverse-(e) invariant (no attachments → behavior unchanged) is // pinned by tests that assert byte-identical response shape // before/after this validation runs. const attachmentsResult = validateAttachments(attachments ?? (meta && typeof meta === "object" ? (meta as any).attachments : undefined)); if (!attachmentsResult.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "bad_attachments", message: attachmentsResult.error, }), }], }; } const mergedMeta = attachmentsResult.attachments.length ? { ...(meta && typeof meta === "object" ? meta : {}), attachments: attachmentsResult.attachments } : meta; const metaJson = normalizeMetaJson(mergedMeta); const canonicalReplyTarget = resolveCanonicalAlias(effectiveNetId, alias); const replyTargetAlias = canonicalReplyTarget.alias; console.log(`[${ts()}] ${from_session} → send_reply (${replyStatus}) → ${replyTargetAlias}: ${text.slice(0, 60)}${attachmentsResult.attachments.length ? ` [+${attachmentsResult.attachments.length} attachments]` : ""}${canonicalReplyTarget.renamed ? ` [renamed from ${alias}]` : ""}`); const id = uuidv4(); const replyTargetNodeId = resolveNodeIdForAlias(replyTargetAlias, effectiveNetId); // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 3/6). { const lc = assertNodeActive(replyTargetAlias, effectiveNetId ?? null); if (!lc.ok) return { content: [{ type: "text" as const, text: JSON.stringify(lc) }] }; } const replyOutcome = db.transaction(() => { type ReplyTask = { status: string; from_node_id: string | null; from_name: string; to_name: string; to_node_id: string | null; }; let taskBefore: ReplyTask | null = null; let callerNodeId: string | null = null; if (in_reply_to) { const taskParams: any[] = [in_reply_to]; let taskSql = "SELECT status, from_node_id, from_name, to_name, to_node_id FROM tasks WHERE task_id = ?1"; taskSql = addScope(taskSql, taskParams, effectiveNetId); taskBefore = db.get(taskSql, ...taskParams) ?? null; if (!taskBefore) return { ok: false as const, error: "reply_task_not_found" as const }; if (!["created", "delivered", "acked", "running"].includes(taskBefore.status)) { return { ok: false as const, error: "reply_task_terminal" as const, taskStatus: taskBefore.status }; } // V3 atomic peer replies are capability-negotiated. Both identity // bindings and the recipient capability are re-read inside this // transaction before any inbox/task/run write. Legacy/unbound rows // fail toward compatibility send_reply, which terminalizes the // original task instead of creating a second response-requiring row. if (peerCapabilityRequired) { if (!taskBefore.from_node_id) { // Origin type is an intrinsic property of the task and must be // decided before caller capability. A Dashboard/human task still // needs the established send_reply terminalization path when the // replying node uses a legacy/unbound token. return { ok: false as const, error: "peer_reply_origin_not_node" as const }; } if (!callerTokenIsNetwork || !callerTokenId || !enforceNetworkId) { return { ok: false as const, error: "peer_reply_node_token_required" as const }; } const token = db.get<{ bound_node_id: string | null }>( "SELECT bound_node_id FROM api_tokens WHERE token_id = ?1 AND network_id = ?2", callerTokenId, enforceNetworkId, ); if (!token?.bound_node_id || !taskBefore.to_node_id) { return { ok: false as const, error: "peer_reply_unsupported" as const }; } if (token.bound_node_id !== taskBefore.to_node_id) { return { ok: false as const, error: "reply_task_not_owned" as const }; } callerNodeId = token.bound_node_id; const canonicalTarget = replyTargetAlias; const canonicalOrigin = resolveCanonicalAlias(enforceNetworkId, taskBefore.from_name).alias; if (canonicalTarget !== canonicalOrigin) { return { ok: false as const, error: "reply_target_mismatch" as const }; } const recipient = db.get<{ peer_reply_inbox_capable: number }>( `SELECT peer_reply_inbox_capable FROM sessions WHERE node_id = ?1 AND network_id = ?2 AND alias = ?3 ORDER BY updated_at DESC LIMIT 1`, taskBefore.from_node_id, enforceNetworkId, canonicalOrigin, ); if (recipient?.peer_reply_inbox_capable !== 1) { return { ok: false as const, error: "peer_reply_unsupported" as const }; } } else if (callerTokenIsNetwork && enforceNetworkId) { // Compatibility send_reply is still an exact task transition for // node callers. Bind it to the token-authenticated assignee alias // and immutable original sender. Alias binding survives a // legitimate node-id rotation without letting another node close // the task. const canonicalCaller = resolveCanonicalAlias(enforceNetworkId, from_session).alias; const canonicalAssignee = resolveCanonicalAlias(enforceNetworkId, taskBefore.to_name).alias; if (canonicalCaller !== canonicalAssignee) { return { ok: false as const, error: "reply_task_not_owned" as const }; } const canonicalOrigin = resolveCanonicalAlias(enforceNetworkId, taskBefore.from_name).alias; if (replyTargetAlias !== canonicalOrigin) { return { ok: false as const, error: "reply_target_mismatch" as const }; } } } // #507 — write meta_json on inbox insert (parity with send_task L952). // Prior to this the attachments field on a send_reply call was // silently stripped by MCP Zod, leaving `ok:true` with no persisted // meta. db.run( `INSERT INTO inbox (id, session_name, node_id, type, priority, content, from_session, in_reply_to, requires_response, network_id, meta_json) VALUES (?1, ?2, ?3, 'reply', 'normal', ?4, ?5, ?6, 'none', ?7, ?8)`, [id, replyTargetAlias, replyTargetNodeId, text, from_session, in_reply_to ?? null, effectiveNetId ?? null, metaJson] ); // 更新 tasks 表 if (in_reply_to) { // #507 — persist meta_json onto the tasks row too, so // dashboard's task view sees the reply's attachments alongside // the reply text (parity with send_task L957/959 which writes // meta_json into both inbox and tasks). The COALESCE guards // against clobbering pre-existing meta_json when this reply // brings no attachments (metaJson === null → keep the existing // task meta_json unchanged). Reverse-(e) invariant. const updateParams: any[] = [replyStatus, text, metaJson, in_reply_to]; let updateSql = `UPDATE tasks SET status = ?1, result = ?2, completed_at = datetime('now'), meta_json = COALESCE(?3, meta_json) WHERE task_id = ?4 AND status IN ('created', 'delivered', 'acked', 'running')`; if (peerCapabilityRequired && callerTokenIsNetwork && taskBefore) { if (taskBefore.to_node_id) { updateParams.push(callerNodeId); updateSql += ` AND to_node_id = ?${updateParams.length}`; } else { updateParams.push(taskBefore.to_name); updateSql += ` AND to_node_id IS NULL AND to_name = ?${updateParams.length}`; } } updateSql = addScope(updateSql, updateParams, effectiveNetId); const result = db.run(updateSql, updateParams); if (result.changes === 0) { throw new Error(`reply_atomic_cas_failed:${in_reply_to}`); } syncScheduledRunForTask(in_reply_to, effectiveNetId); return { ok: true as const, replyLogged: true }; } return { ok: true as const, replyLogged: false }; }); if (!replyOutcome.ok) { const taskStatus = "taskStatus" in replyOutcome ? replyOutcome.taskStatus : undefined; const messages: Record = { reply_task_not_found: `cannot apply reply: task not found (${in_reply_to})`, reply_task_terminal: `cannot apply reply: task is already terminal (${taskStatus})`, peer_reply_node_token_required: "atomic peer reply requires a node token", peer_reply_unsupported: "recipient or caller does not support atomic peer replies", peer_reply_origin_not_node: "original task sender is not a node; use send_reply", reply_node_identity_unbound: "cannot apply reply: node identity is not token-bound", reply_task_not_owned: "cannot apply reply: task is not owned by this node", reply_target_mismatch: "cannot apply reply: target is not the original task sender", }; return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: replyOutcome.error, message: messages[replyOutcome.error], in_reply_to, ...(taskStatus ? { task_status: taskStatus } : {}), reply_queued: false, }), }], }; } const replyLogged = replyOutcome.replyLogged; // Log event after commit (outside transaction) if (replyLogged && in_reply_to) logTaskEvent(in_reply_to, null, replyStatus, from_session, text.slice(0, 200)); // Auto-chain reply up to parent task lineage so admin sees the final // answer even if the intermediate session has died. // round5 F2: pass caller's effectiveNetId so the chain refuses // to write across tenants if some upstream parent links to a // foreign network. // // round5 follow-up (通信牛 SSE leak catch): gate the SSE push on // `result.chained`. See report_completion path above for the // full reasoning — same leak, same gate. if (replyLogged && in_reply_to) { try { const chainResult = chainReplyToParent(in_reply_to, text, replyStatus, 5, effectiveNetId); if (chainResult.chained) { const parentChain = db.get<{ parent_task_id: string | null; from_name: string }>( "SELECT parent_task_id, from_name FROM tasks WHERE task_id = ?1", [in_reply_to] ); if (parentChain?.parent_task_id) { const parent = db.get<{ from_name: string; task_id: string }>( "SELECT from_name, task_id FROM tasks WHERE task_id = ?1", [parentChain.parent_task_id] ); if (parent?.from_name && parent.from_name !== "hub" && parent.from_name !== "api") { pushEvent(parent.from_name, { type: "chained_reply", parent_task_id: parent.task_id, child_task_id: in_reply_to, child_alias: alias }, effectiveNetId); } } } } catch (e: any) { console.log(`[${ts()}] ⚠ chainReplyToParent failed: ${e.message}`); } } const session = scopedSessionStatus(replyTargetAlias, effectiveNetId); pushEvent(replyTargetAlias, { type: "new_reply", from: from_session, message_id: id, in_reply_to, status: replyStatus }, effectiveNetId); // #461 network observer summary — ids + routing only, no reply text. pushNetworkObserverEvent(effectiveNetId, { type: "new_reply", task_id: in_reply_to ?? null, message_id: id, from: from_session, to: replyTargetAlias, status: replyStatus }); // #498 compatibility tripwire. Legacy send_reply is intentionally kept // for old agents and Dashboard callers during rollout, but it is not the // capability-negotiated atomic peer primitive. Warn only for an actual // agent target; Dashboard hub/api replies remain quiet. New agents call // send_peer_reply and never see this warning. const targetIsAgent = replyTargetNodeId !== null && replyTargetAlias !== "hub" && replyTargetAlias !== "api"; const warning = !peerCapabilityRequired && targetIsAgent ? `Target "${replyTargetAlias}" is an agent node. Legacy commhub_reply/send_reply terminalized the original task; upgraded peers should prefer commhub_send_peer_reply for capability-negotiated delivery. (RFC-030 mixed-version rollout.)` : undefined; // #507 — echo attachments READ BACK FROM DB (lead 2b5f6634): the point // of the echo is to prove attachments actually landed in storage, not // to reflect the in-memory variable we tried to write. Reading // `attachmentsResult.attachments` here would still show `ok:true` + // full echo if the UPDATE failed with `changes=0` (e.g. task moved to // terminal between the pre-check and the transaction). SELECT from // inbox.meta_json (always written, uses the id we just generated) so // the echo means "these attachments are on disk now". Absent field // when the caller sent no attachments — reverse-(e) invariant: a // no-attachment call returns the exact same response shape as before // this PR. Persisted-attachments field is only added when the caller // actually asked for attachments. let attachmentsSaved: unknown[] | null = null; if (attachmentsResult.attachments.length > 0) { const persistedRow = db.get<{ meta_json: string | null }>( "SELECT meta_json FROM inbox WHERE id = ?1", [id] ); const persistedMeta = parseMetaJson(persistedRow?.meta_json ?? null); attachmentsSaved = persistedMeta && typeof persistedMeta === "object" && Array.isArray((persistedMeta as any).attachments) ? (persistedMeta as any).attachments : []; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, message_id: id, session_status: session?.status ?? "unknown", ...(warning ? { warning } : {}), ...(attachmentsSaved !== null ? { attachments_saved: attachmentsSaved } : {}), }), }], }; }; server.tool( "send_reply", "Reply to a Dashboard/UI-originated task. Also serves as the terminal legacy fallback when atomic peer reply capability is unavailable.", replyToolSchema, (args) => handleReply(args, false), ); server.tool( "send_peer_reply", "Atomically finalize one node-owned task and enqueue one no-response result when the exact recipient advertises peer_reply_inbox_capable. Stored capability survives transient SSE disconnects; legacy peers return peer_reply_unsupported with zero writes.", replyToolSchema, (args) => handleReply(args, true), ); // ── V2: send_ack (不入 inbox,仅更新状态) ── server.tool( "send_ack", "Acknowledge receipt of a task. Does NOT enter inbox. Updates task status only.", { task_id: z.string().min(1).max(200).describe("Task ID to acknowledge"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ task_id, from_session: _fromIn, network_id: netId }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] ${from_session} → send_ack → task ${task_id.slice(0, 8)}`); const updateParams: any[] = [task_id]; let updateSql = "UPDATE tasks SET status = 'acked' WHERE task_id = ?1 AND status IN ('created', 'delivered')"; updateSql = addScope(updateSql, updateParams, effectiveNetId); const result = db.run(updateSql, updateParams); if (result.changes > 0) logTaskEvent(task_id, "delivered", "acked", from_session); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: result.changes > 0, task_id, updated: result.changes }), }], }; } ); // ── V2: retry_task (重新投递失败/过期任务) ── server.tool( "retry_task", "Retry a failed, expired, or cancelled task. Resets status to delivered and re-queues in inbox.", { task_id: z.string().min(1).max(200).describe("Task ID to retry"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ task_id, from_session: _fromIn, network_id: netId }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] ${from_session} → retry_task → ${task_id.slice(0, 8)}`); // Find the original task const taskParams: any[] = [task_id]; let taskSql = "SELECT * FROM tasks WHERE task_id = ?1"; taskSql = addScope(taskSql, taskParams, effectiveNetId); const task = db.get(taskSql, ...taskParams); if (!task) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "task not found" }) }] }; } if (!["failed", "expired", "cancelled"].includes(task.status)) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: `task status is ${task.status}, not retryable` }) }] }; } // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 4/6). { const lc = assertNodeActive(task.to_name, effectiveNetId ?? task.network_id ?? null); if (!lc.ok) return { content: [{ type: "text" as const, text: JSON.stringify(lc) }] }; } db.transaction(() => { // Reset task status const updateParams: any[] = [task_id]; let updateSql = `UPDATE tasks SET status = 'delivered', result = NULL, completed_at = NULL, started_at = NULL, delivered_at = datetime('now'), expires_at = datetime('now', '+1 hour') WHERE task_id = ?1`; updateSql = addScope(updateSql, updateParams, effectiveNetId); db.run(updateSql, updateParams); syncScheduledRunForTask(task_id, effectiveNetId ?? task.network_id ?? null); // Re-queue in inbox with new ID (original ID may already exist) const retryInboxId = uuidv4(); db.run( `INSERT INTO inbox (id, task_id, session_name, node_id, type, priority, content, from_session, requires_response, network_id) VALUES (?1, ?2, ?3, ?4, 'task', ?5, ?6, ?7, 'reply', ?8)`, [retryInboxId, task_id, task.to_name, task.to_node_id ?? resolveNodeIdForAlias(task.to_name, effectiveNetId ?? task.network_id ?? null), task.priority, task.content, from_session, effectiveNetId ?? task.network_id ?? null] ); }); logTaskEvent(task_id, task.status, "delivered", from_session, "retry"); // SSE push (unconditional — channel is keyed by alias, not network) pushEvent(task.to_name, { type: "new_task", inbox_count: 1, priority: task.priority, from: from_session }, effectiveNetId ?? task.network_id ?? null); pushNetworkObserverEvent(effectiveNetId ?? task.network_id ?? null, { type: "new_task", task_id, from: from_session, to: task.to_name, status: "delivered", priority: task.priority }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, task_id, retried_to: task.to_name }) }], }; } ); // ── V2: get_task (查询任务状态) ── server.tool( "get_task", "Get task details by task_id. Returns status, result, timestamps.", { task_id: z.string().min(1).max(200).describe("Task ID to query"), }, async ({ task_id }) => { const readScope = resolveReadScope(null); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; const params: any[] = [task_id]; let sql = "SELECT * FROM tasks WHERE task_id = ?1"; sql = addReadScope(sql, params, readScope); const task = db.get(sql, ...params); return { content: [{ type: "text" as const, text: JSON.stringify(task ? { ok: true, task } : { ok: false, error: "task not found" }), }], }; } ); // ── V2: list_tasks (查询任务列表) ── server.tool( "list_tasks", "List tasks with filters. Agents can query their own pending/running tasks.", { alias: z.string().max(200).optional().describe("Filter by to_name (target agent)"), status: z.string().max(50).optional().describe("Filter by status"), from_name: z.string().max(200).optional().describe("Filter by sender"), from_node_id: z.string().max(200).optional().describe("Filter by immutable sender node_id"), network_id: z.string().max(200).optional().describe("Filter by network"), before_created_at: z.string().max(64).optional().describe("Pagination cursor timestamp"), before_task_id: z.string().max(200).optional().describe("Pagination cursor task id"), durable_cursor: z.boolean().optional().describe("Require immutable node-scoped cursor protocol"), durable_terminal_cursor: z.boolean().optional().describe("Read terminal outbound journal in monotonic order"), after_terminal_seq: z.number().int().min(0).optional().describe("Exclusive terminal journal watermark"), limit: z.number().min(1).max(100).optional().default(20), }, async ({ alias, status, from_name, from_node_id, network_id: netId, before_created_at, before_task_id, durable_cursor, durable_terminal_cursor, after_terminal_seq, limit }) => { const readScope = resolveReadScope(netId); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; if (durable_cursor) { if (!callerTokenIsNetwork) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "node_token_required" }) }] }; const boundNodeId = callerTokenId && enforceNetworkId ? db.get<{ bound_node_id: string | null }>( "SELECT bound_node_id FROM api_tokens WHERE token_id = ?1 AND network_id = ?2", callerTokenId, enforceNetworkId, )?.bound_node_id ?? null : null; if (!boundNodeId || from_node_id !== boundNodeId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "from_node_id_identity_mismatch" }) }] }; } } if (durable_terminal_cursor) { if (!durable_cursor) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "durable_cursor_required" }) }] }; const params: any[] = [enforceNetworkId, from_node_id, after_terminal_seq ?? 0, limit]; const tasks = db.all( `SELECT t.task_id, t.from_node_id, t.from_name, t.to_node_id, t.to_name, t.priority, t.status, t.content, t.result, t.created_at, t.runtime_submitted_at, t.consumed_at, t.completed_at, e.terminal_seq FROM task_terminal_events e JOIN tasks t ON t.task_id = e.task_id WHERE COALESCE(e.network_id, 'default') = COALESCE(?1, 'default') AND e.from_node_id = ?2 AND e.terminal_seq > ?3 ORDER BY e.terminal_seq ASC LIMIT ?4`, ...params, ); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, capability: "list_tasks.immutable-terminal-sequence.v2", tasks, count: tasks.length, next_terminal_seq: tasks.length ? tasks[tasks.length - 1]?.terminal_seq : (after_terminal_seq ?? 0), has_more: tasks.length === limit, }) }] }; } let sql = "SELECT task_id, from_node_id, from_name, to_node_id, to_name, priority, status, content, result, created_at, runtime_submitted_at, consumed_at, completed_at FROM tasks WHERE 1=1"; const params: any[] = []; sql = addReadScope(sql, params, readScope); if (alias) { sql += ` AND to_name = ?${params.length + 1}`; params.push(alias); } if (status) { sql += ` AND status = ?${params.length + 1}`; params.push(status); } if (from_name) { sql += ` AND from_name = ?${params.length + 1}`; params.push(from_name); } if (from_node_id) { sql += ` AND from_node_id = ?${params.length + 1}`; params.push(from_node_id); } if (before_created_at && before_task_id) { sql += ` AND (created_at < ?${params.length + 1} OR (created_at = ?${params.length + 1} AND task_id < ?${params.length + 2}))`; params.push(before_created_at, before_task_id); } sql += ` ORDER BY created_at DESC, task_id DESC LIMIT ?${params.length + 1}`; params.push(limit); const tasks = db.all(sql, ...params); // Stats const statsParams: any[] = []; let statsSql = "SELECT status, COUNT(*) as count FROM tasks WHERE 1=1"; statsSql = addReadScope(statsSql, statsParams, readScope); statsSql += " GROUP BY status"; const stats = db.all(statsSql, ...statsParams); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, ...(durable_cursor ? { capability: "list_tasks.immutable-node-cursor.v1" } : {}), tasks, count: tasks.length, next_cursor: tasks.length === limit ? { before_created_at: tasks[tasks.length - 1]?.created_at, before_task_id: tasks[tasks.length - 1]?.task_id, } : null, stats, }), }], }; } ); // ── V2: cancel_task (取消任务) ── server.tool( "cancel_task", "Cancel a pending task. Works on delivered/acked/running tasks.", { task_id: z.string().min(1).max(200).describe("Task ID to cancel"), reason: z.string().max(1000).optional().describe("Cancellation reason"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ task_id, reason, from_session: _fromIn, network_id: netId }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] ${from_session} → cancel_task → ${task_id.slice(0, 8)}`); const updateParams: any[] = [reason || "cancelled by " + from_session, task_id]; let updateSql = `UPDATE tasks SET status = 'cancelled', result = ?1, completed_at = datetime('now') WHERE task_id = ?2 AND status IN ('created', 'delivered', 'acked', 'running')`; updateSql = addScope(updateSql, updateParams, effectiveNetId); const result = db.transaction(() => { const updated = db.run(updateSql, updateParams); // Also ack the inbox entry to prevent agent from picking it up. if (updated.changes > 0) { const inboxParams: any[] = [task_id]; let inboxSql = "UPDATE inbox SET acked = 1 WHERE COALESCE(task_id, id) = ?1 AND acked = 0"; inboxSql = addScope(inboxSql, inboxParams, effectiveNetId); db.run(inboxSql, inboxParams); syncScheduledRunForTask(task_id, effectiveNetId); } return updated; }); if (result.changes > 0) logTaskEvent(task_id, null, "cancelled", from_session, reason || undefined); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: result.changes > 0, task_id, cancelled: result.changes > 0 }) }], }; } ); // ── V2: reassign_task (转移任务到另一个 agent) ── server.tool( "reassign_task", "Reassign a task to a different agent. Works on any non-terminal task (delivered/acked/running).", { task_id: z.string().min(1).max(200).describe("Task ID to reassign"), new_alias: z.string().min(1).max(200).describe("Target agent alias"), from_session: z.string().max(200).optional(), network_id: z.string().max(200).optional().describe("Network scope (auto-resolved for single-network user tokens)"), }, async ({ task_id, new_alias, from_session: _fromIn, network_id: netId }) => { const fromMismatch = fromIdentityMismatchReply(_fromIn); if (fromMismatch) return fromMismatch; const from_session = defaultFrom(_fromIn); const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] ${from_session} → reassign_task → ${task_id.slice(0, 8)} → ${new_alias}`); const taskParams: any[] = [task_id]; let taskSql = "SELECT * FROM tasks WHERE task_id = ?1"; taskSql = addScope(taskSql, taskParams, effectiveNetId); const task = db.get(taskSql, ...taskParams); if (!task) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "task not found" }) }] }; if (["replied", "failed", "cancelled", "expired"].includes(task.status)) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: `task is terminal (${task.status})` }) }] }; } const oldAlias = task.to_name; const canonical = resolveCanonicalAlias(effectiveNetId ?? task.network_id ?? null, new_alias); const reassignedAlias = canonical.alias; const target = resolveDeliveryTarget(reassignedAlias, effectiveNetId ?? task.network_id ?? null); const newNodeId = target.state === "not_found" ? null : (target.session?.node_id ?? null); // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 5/6). { const lc = assertNodeActive(reassignedAlias, effectiveNetId ?? task.network_id ?? null); if (!lc.ok) return { content: [{ type: "text" as const, text: JSON.stringify(lc) }] }; } db.transaction(() => { // Ack old inbox to prevent original agent from picking it up const inboxParams: any[] = [task_id]; let inboxSql = "UPDATE inbox SET acked = 1 WHERE COALESCE(task_id, id) = ?1 AND acked = 0"; inboxSql = addScope(inboxSql, inboxParams, effectiveNetId); db.run(inboxSql, inboxParams); const updateParams: any[] = [reassignedAlias, newNodeId, task_id]; let updateSql = "UPDATE tasks SET to_name = ?1, to_node_id = ?2, status = 'delivered', started_at = NULL, delivered_at = datetime('now') WHERE task_id = ?3"; updateSql = addScope(updateSql, updateParams, effectiveNetId); db.run(updateSql, updateParams); const newInboxId = uuidv4(); db.run("INSERT INTO inbox (id, task_id, session_name, node_id, type, priority, content, from_session, requires_response, network_id) VALUES (?1, ?2, ?3, ?4, 'task', ?5, ?6, ?7, 'reply', ?8)", [newInboxId, task_id, reassignedAlias, newNodeId, task.priority, task.content, from_session, effectiveNetId ?? task.network_id ?? null]); }); logTaskEvent(task_id, task.status, "delivered", from_session, `reassign: ${oldAlias} → ${reassignedAlias}`); pushEvent(reassignedAlias, { type: "new_task", inbox_count: 1, priority: task.priority, from: from_session, ...(canonical.renamed ? { renamed_from: new_alias } : {}) }, effectiveNetId ?? task.network_id ?? null); pushNetworkObserverEvent(effectiveNetId ?? task.network_id ?? null, { type: "new_task", task_id, from: from_session, to: reassignedAlias, status: "delivered", priority: task.priority }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, task_id, reassigned_from: oldAlias, reassigned_to: reassignedAlias, ...(canonical.renamed ? { renamed_from: new_alias, renamed_to: reassignedAlias } : {}) }) }] }; } ); server.tool( "broadcast", "Send a message to multiple sessions.", { message: z.string().min(1).max(10000), filter_server: z.string().max(200).optional(), filter_status: z.string().max(50).optional(), network_id: z.string().max(200).optional().describe("Broadcast within a specific network"), }, async ({ message, filter_server, filter_status, network_id: netId }) => { const effectiveNetId = getNetworkId(netId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId); console.log(`[${ts()}] hub → broadcast: ${message.slice(0, 60)}${effectiveNetId ? " [net=" + effectiveNetId.slice(0, 12) + "]" : ""}`); let sql = "SELECT alias, node_id, network_id FROM sessions WHERE alias IS NOT NULL"; const params: any[] = []; sql = addScope(sql, params, effectiveNetId); if (filter_server) { sql += " AND server = ?"; params.push(filter_server); } if (filter_status) { sql += " AND status = ?"; params.push(filter_status); } const targets = db.all<{ alias: string; node_id: string | null; network_id: string | null }>(sql, ...params); const ids: string[] = []; for (const t of targets) { // RFC-027 §2.3 inbox-enqueue lifecycle guard (PR1.1 site 6/6). // Broadcast skips non-active recipients silently rather than // failing the entire send — broadcast semantics are best-effort // per-recipient and a stopped node simply gets nothing. const lc = assertNodeActive(t.alias, effectiveNetId ?? t.network_id ?? null); if (!lc.ok) continue; const id = uuidv4(); db.run( `INSERT INTO inbox (id, session_name, node_id, type, priority, content, from_session, network_id) VALUES (?1, ?2, ?3, 'broadcast', 'normal', ?4, 'hub', ?5)`, [id, t.alias, t.node_id ?? null, message, effectiveNetId ?? t.network_id ?? null] ); ids.push(id); } for (const t of targets) { pushEvent(t.alias, { type: "broadcast", inbox_count: 1 }, effectiveNetId ?? t.network_id ?? null); } return { content: [ { type: "text" as const, text: JSON.stringify({ ok: true, recipients: targets.length, message_ids: ids }), }, ], }; } ); server.tool( "get_completions", "Get recent task completions.", { since: z.string().optional().describe("ISO 8601 datetime, default last 24h"), alias: z.string().max(200).optional().describe("Filter by session alias"), network_id: z.string().max(200).optional().describe("Filter by network"), limit: z.number().min(1).max(500).optional().default(50), }, async ({ since, alias, network_id: netId, limit }) => { const readScope = resolveReadScope(netId); if (readScope.denied) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; console.log(`[${ts()}] hub → get_completions${alias ? ": " + alias : ""}`); const cutoff = since ?? new Date(Date.now() - 24 * 60 * 60 * 1000).toISOString(); let sql = "SELECT * FROM completions WHERE completed_at >= ?1"; const params: any[] = [cutoff]; sql = addReadScope(sql, params, readScope); if (alias) { sql += ` AND session_name = ?${params.length + 1}`; params.push(alias); } const paramIdx = params.length + 1; sql += ` ORDER BY completed_at DESC LIMIT ?${paramIdx}`; params.push(limit); const rows = db.all(sql, ...params); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, completions: rows }) }], }; } ); // ────────────────────────────────────────────────────────────────── // RFC-024 (2026-06-28) — node config-apply MCP tools. // // Three contract tools (update / get / ack) + one lifecycle tool // (restart_node, Vincent 2026-06-28 increment). All four enforce // SEC-1 (network-scoped, never trust upstream dashboard routing — // every tool re-checks caller→token→network. Mirrors the #275 // cross-tenant write防护带 pattern). update_node_config additionally // enforces SEC-2 — security-sensitive flags (permissionMode, // dangerouslySkipPermissions, teammateMode) are fail-CLOSED pending // Vincent's policy decision (see SECURITY_SENSITIVE_FLAGS below). // // See docs/rfcs/RFC-024-dashboard-node-config-apply.md for the // contract + sequence diagrams + guards. // ────────────────────────────────────────────────────────────────── // Helpers — ALLOWED_FLAGS, SECURITY_SENSITIVE_FLAGS, computeApplyMode, // validatePatch, isAllowedToChangeFlag live in // ./config-apply-validate.ts so the contract is unit-testable without // standing up an MCP server. /** * Resolve the node row that update_node_config / restart_node targets. * Returns the row + the SEC-1 verdict (network match against caller). * Network mismatch is the cross-tenant write防护带 from #275 — every * tool re-checks this even if dashboard already did, because curl * can talk directly to /mcp. */ const resolveTargetNode = ( nodeId: string, callerNetworkId: string | null, ): { row: any | null; sec1Ok: boolean } => { const row = db.get( "SELECT node_id, alias, network_id, config_revision, config_snapshot FROM nodes WHERE node_id = ?1", nodeId, ); if (!row) return { row: null, sec1Ok: false }; // Use the same null/undefined → "default" normalization as the // report_status upsert guard (norm() helper) — `||` would also // coerce `""` to "default", which is unreachable in the V3 model // today but better aligned to avoid drift if any future migration // ever introduces empty-string network_ids. Single source of // truth: nullish-only. const nodeNet = row.network_id === null || row.network_id === undefined ? "default" : row.network_id; const callerNet = callerNetworkId === null || callerNetworkId === undefined ? "default" : callerNetworkId; return { row, sec1Ok: nodeNet === callerNet }; }; server.tool( "update_node_config", "Set the desired per-node config (model + flags) and push a doorbell to the node. The node pulls + validates + applies (hot or restart per field tier). RFC-024.", { node_id: z.string().min(1).max(200).describe("Target node ID (not alias). Must be in caller's network."), base_revision: z.number().int().min(0).describe("Current revision per the dashboard's last GET — 409 if hub's current revision differs."), patch: z.object({ model: z.string().max(200).optional(), flags: z.record(z.unknown()).optional(), // #260 P5 — channel enable/disable. Restart-tier field (agent-node // reads config.channels once at boot to fork per-channel workers, // so the swap takes effect via process restart). Not // SECURITY_SENSITIVE — this is a lifecycle op, gated by SEC-1 // (network scope) only. // // Deliberately `z.array(z.unknown()).max(16)` (mirrors flags's // `z.record(z.unknown())`): trust nothing at the wire boundary, // narrow the same way `narrowChannelsPatch` narrows raw untrusted // JSON (typeof + allowlist + dedup + case-fold). A strict // `z.array(z.string())` would fail-fast on a single non-string // entry, but the wire contract wants junk silently dropped so a // dashboard fat-finger doesn't turn into a 400 the user has to // interpret. validatePatch then re-rejects if the caller bypassed // narrowing. channels: z.array(z.unknown()).max(16).optional(), }).describe("Fields to update. Empty patch → no-op (use restart_node for that)."), network_id: z.string().max(200).optional(), }, async ({ node_id: nodeId, base_revision: baseRev, patch, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const { row: node, sec1Ok } = resolveTargetNode(nodeId, effectiveNetId); if (!node) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "node_not_found", node_id: nodeId }) }] }; } if (!sec1Ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_node", message: "node belongs to another network" }) }] }; } const model = typeof patch.model === "string" ? patch.model : undefined; const flags = (patch.flags && typeof patch.flags === "object") ? patch.flags as Record : {}; // Narrow untrusted `channels` at the boundary (typeof + allowlist + // dedup + case-fold), and distinguish two very different cases // that both narrow to `[]`: // (a) `patch.channels === []` (explicit "disable all editable // channels"). Downstream must proceed and write channels=[] // so the node's next restart forks no workers. // (b) `patch.channels === ["commhub"]` or similar — the caller // sent items but every single one was invalid (dashboard PR // #31 still ships commhub, and a typo like "telegarm" would // hit the same path). Downstream MUST NOT treat this as // (a) — silently converting to disable-all would nuke the // user's existing telegram/feishu workers. // // The reject error is `channels_all_invalid` so the dashboard // can surface the mismatch instead of showing a false success. let channels: string[] | undefined = undefined; if (patch.channels !== undefined) { if (!Array.isArray(patch.channels)) { // Zod already permits arrays only; belt+braces if it drifts. return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "invalid_patch", field: "channels", reason: "must be an array" }) }], }; } const narrowed = narrowChannelsPatch(patch.channels) ?? []; if (patch.channels.length === 0) { channels = []; // (a) explicit disable-all } else if (narrowed.length === 0) { // (b) every entry was invalid — refuse to write. Distinct // error so the dashboard can surface the failure. return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "channels_all_invalid", requested: patch.channels, message: "every requested channel is unknown or unsupported; use an explicit empty array to disable-all", }), }], }; } else { channels = narrowed; } } // SEC-2 (final policy 2026-06-28) — security-sensitive flags // (permissionMode / dangerouslySkipPermissions / teammateMode) // require admin role on this network. Other flags fall through // to per-field validation. hub-side enforced (dashboard's UI // gate is not trusted; curl direct to /mcp is the attack // vector). See isAllowedToChangeFlag for the policy details. const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; const secCheck = isAllowedToChangeFlag(callerRole, flags); if (secCheck) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "insufficient_role_for_security_flag", field: secCheck.field, required_role: "admin", // or owner — both satisfy message: secCheck.reason, }), }], }; } const validationFail = validatePatch(model, flags, channels); if (validationFail) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "invalid_patch", field: validationFail.field, reason: validationFail.reason, }), }], }; } // Revision conflict. if ((node.config_revision || 0) !== baseRev) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "revision_conflict", current_revision: node.config_revision || 0, base_revision: baseRev, }), }], }; } // F-B (CHANGE_REQ): single-flight with stale-update reaper. // Without TTL, a node that ack'd "restarting" then crashed (lost // power, OOM, killed) leaves a non-terminal row forever — every // subsequent update_node_config / restart_node returns // update_in_flight and the node is admin-bricked. // // Stale threshold = 60_000 ms (2× the §8-confirmed 30s apply ceiling, // chosen so a slow-but-alive node within its own deadline never // false-positives as stale). Stale rows are marked timeout + // superseded by the new update. // // Age anchor = COALESCE(acked_at, created_at) per 通信龙 polish: // a healthy-but-slow restart (drain 60s + respawn time) could // exceed the threshold if anchored on created_at alone (drain // cap and reaper threshold are both 60s — overlap). Anchoring // on acked_at means a node that ack'd "restarting" refreshes // the liveness clock, so an in-progress restart isn't falsely // reaped. const STALE_THRESHOLD_MS = 60_000; const inFlight = db.get<{ update_id: string; created_at: number; acked_at: number | null }>( "SELECT update_id, created_at, acked_at FROM node_config_updates WHERE node_id = ?1 AND status IN ('pending', 'restarting') ORDER BY created_at DESC LIMIT 1", nodeId, ); if (inFlight) { const ageAnchor = inFlight.acked_at ?? inFlight.created_at; const age = Date.now() - ageAnchor; if (age <= STALE_THRESHOLD_MS) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "update_in_flight", existing_update_id: inFlight.update_id, age_ms: age, }), }], }; } // Stale — supersede. db.run( "UPDATE node_config_updates SET status = 'timeout', acked_at = ?1, error = ?2 WHERE update_id = ?3", [Date.now(), `superseded by new update after ${age}ms stale (> ${STALE_THRESHOLD_MS}ms threshold)`, inFlight.update_id], ); } // Compute apply_mode + persist + push doorbell. const updateId = `cu_${uuidv4()}`; const applyMode = computeApplyMode(model, flags, channels); const patchJson = JSON.stringify({ ...(model !== undefined ? { model } : {}), flags, ...(channels !== undefined ? { channels } : {}), }); const networkId = node.network_id || "default"; db.run( `INSERT INTO node_config_updates (update_id, node_id, network_id, patch_json, apply_mode, base_revision, status, created_at, created_by_token) VALUES (?1, ?2, ?3, ?4, ?5, ?6, 'pending', ?7, ?8)`, [updateId, nodeId, networkId, patchJson, applyMode, baseRev, Date.now(), callerTokenId || "unknown"], ); pushEvent(node.alias, { type: "config_update", update_id: updateId }, networkId); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, update_id: updateId, apply_mode: applyMode }), }], }; }, ); server.tool( "get_config_update", "Node pulls its pending config update (called from agent-node when SSE config_update doorbell arrives). RFC-024.", {}, async () => { // F-A (CHANGE_REQ): require ntok_ + non-null enforceNetworkId. // Mirror report_status's guard (tools.ts:251-253) — utok_ has // enforceNetworkId=null and callerAlias=username, so without // this gate a utok_ whose username happens to match a node alias // could pull that node's pending update across network scope // (network filter would be silently dropped, since old code had // a conditional WHERE). Hub doesn't trust upstream gates — every // node-private tool must independently require a network-bound // token. if (!callerTokenIsNetwork || !enforceNetworkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "network_token_required" }) }] }; } if (!callerAlias) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_required" }) }] }; } // Unconditional network_id filter (was previously conditional on // enforceNetworkId being set; the new ntok guard above guarantees // it's non-null so the filter is always applied). const node = db.get( "SELECT node_id, network_id FROM nodes WHERE alias = ?1 AND network_id = ?2", callerAlias, enforceNetworkId, ); if (!node) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, update: null }) }] }; } const update = db.get( "SELECT update_id, patch_json, apply_mode, base_revision FROM node_config_updates WHERE node_id = ?1 AND status = 'pending' ORDER BY created_at DESC LIMIT 1", node.node_id, ); if (!update) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, update: null }) }] }; } let patch: any = {}; try { patch = JSON.parse(update.patch_json); } catch { patch = {}; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, update: { update_id: update.update_id, patch, apply_mode: update.apply_mode, base_revision: update.base_revision, }, }), }], }; }, ); server.tool( "ack_config_update", "Node acknowledges a config update — applied / rejected / restarting / timeout. RFC-024.", { update_id: z.string().min(1).max(200), status: z.enum(["applied", "rejected", "restarting", "timeout"]), new_revision: z.number().int().min(0).optional(), error: z.string().max(2000).optional(), }, async ({ update_id: updateId, status, new_revision: newRev, error: ackError }) => { // F-A (CHANGE_REQ): same ntok_ guard as get_config_update. Without // this, a utok_ whose username matches a node alias could ack // arbitrary updates within the alias-collision; the new ntok guard // closes that. if (!callerTokenIsNetwork || !enforceNetworkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "network_token_required" }) }] }; } if (!callerAlias) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "alias_required" }) }] }; } // Cross-tenant guard: the ack-er must own the update being acked. // Resolve node by caller's alias under the enforced network. // Network filter is unconditional (guard above guarantees non-null). const node = db.get( "SELECT node_id FROM nodes WHERE alias = ?1 AND network_id = ?2", callerAlias, enforceNetworkId, ); if (!node) { // Silently ignore stale ack — return ok so the node doesn't retry forever. return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, ignored: "alias_unknown" }) }] }; } const update = db.get( "SELECT update_id, node_id, status FROM node_config_updates WHERE update_id = ?1", updateId, ); if (!update || update.node_id !== node.node_id) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, ignored: "unknown_or_foreign_update" }) }] }; } // Reject ack for already-terminal updates (idempotency). if (update.status === "applied" || update.status === "rejected" || update.status === "timeout") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, ignored: "already_terminal", current_status: update.status }) }] }; } const ackedAt = Date.now(); if (status === "applied") { // Promote the node's config_revision to the new revision, atomically. const nextRev = (typeof newRev === "number" && newRev > 0) ? newRev : ((db.get<{ config_revision: number }>("SELECT config_revision FROM nodes WHERE node_id = ?1", node.node_id)?.config_revision || 0) + 1); db.run( `UPDATE node_config_updates SET status = 'applied', acked_at = ?1, new_revision = ?2 WHERE update_id = ?3`, [ackedAt, nextRev, updateId], ); db.run(`UPDATE nodes SET config_revision = ?1 WHERE node_id = ?2`, [nextRev, node.node_id]); } else { db.run( `UPDATE node_config_updates SET status = ?1, acked_at = ?2, error = ?3 WHERE update_id = ?4`, [status, ackedAt, ackError || null, updateId], ); } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, status }) }] }; }, ); server.tool( "restart_node", "Trigger a node restart without changing config. RFC-024 Vincent 2026-06-28 increment. Network-scoped (SEC-1); member+ role suffices (lifecycle ops are not privilege elevation).", { node_id: z.string().min(1).max(200), network_id: z.string().max(200).optional(), }, async ({ node_id: nodeId, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const { row: node, sec1Ok } = resolveTargetNode(nodeId, effectiveNetId); if (!node) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "node_not_found", node_id: nodeId }) }] }; } if (!sec1Ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_node" }) }] }; } // F-B reaper: same stale-supersede semantics as update_node_config, // with same acked_at-anchored liveness clock (see update_node_config // for the 通信龙 polish reasoning). const STALE_THRESHOLD_MS_R = 60_000; const inFlight = db.get<{ update_id: string; created_at: number; acked_at: number | null }>( "SELECT update_id, created_at, acked_at FROM node_config_updates WHERE node_id = ?1 AND status IN ('pending', 'restarting') ORDER BY created_at DESC LIMIT 1", nodeId, ); if (inFlight) { const ageAnchor = inFlight.acked_at ?? inFlight.created_at; const age = Date.now() - ageAnchor; if (age <= STALE_THRESHOLD_MS_R) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "update_in_flight", existing_update_id: inFlight.update_id, age_ms: age }) }] }; } db.run( "UPDATE node_config_updates SET status = 'timeout', acked_at = ?1, error = ?2 WHERE update_id = ?3", [Date.now(), `superseded by restart_node after ${age}ms stale`, inFlight.update_id], ); } const updateId = `cu_${uuidv4()}`; const networkId = node.network_id || "default"; // RFC-027 PR1.2a latent fix (#346 ack): restart_node must reset // lifecycle_state to 'active'. Otherwise a node that was previously // stop_node'd → 'stopped' would, after restart, stay marked // 'stopped' in the nodes table → the 6 MCP + 2 REST inbox guards // would refuse every routing attempt → node silently unreachable // (no error to operator, just no traffic). Pair the schema flip // with the config_updates INSERT inside one tx so we don't // half-commit if the dispatch INSERT throws. db.transaction(() => { db.run( `INSERT INTO node_config_updates (update_id, node_id, network_id, patch_json, apply_mode, base_revision, status, created_at, created_by_token) VALUES (?1, ?2, ?3, '{}', 'restart_only', ?4, 'pending', ?5, ?6)`, [updateId, nodeId, networkId, node.config_revision || 0, Date.now(), callerTokenId || "unknown"], ); db.run( `UPDATE nodes SET lifecycle_state = 'active' WHERE node_id = ?1`, [nodeId], ); }); pushEvent(node.alias, { type: "restart", update_id: updateId }, networkId); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, update_id: updateId, apply_mode: "restart_only" }) }], }; }, ); // ── RFC-026 P1 — create-node + host-daemon (3 MCP tools) ────────── // Background timers (GC + sweeper) are idempotent + cheap; safe to // call on every registerTools invocation (statless mode re-registers // per request). They unref themselves so don't hold the event loop. startPendingEnvGcTimer(); startSweeperTimer(); // §4.1.4 C2 — caller daemon resolved via token-bound identity (NOT // alias). Thin closure over the module-level helper so callers in // this scope can use the captured request-level vars. The pure // helper lives in create-node.ts so unit tests call exactly the // same code path the tools do (per 通信龙 PR #299 nit 1 — no inline- // mirror SQL in tests). const resolveCallerDaemonTokenBound = () => _resolveCallerDaemonTokenBound({ callerTokenIsNetwork, callerTokenId, enforceNetworkId }); // Helper — map a ValidationError thrown from create-node-validate // into the MCP-tool-call JSON reply shape. const validationFailReply = (e: unknown) => { if (e instanceof ValidationError) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: e.code, ...(e.detail || {}) }) }] }; } throw e; }; // RFC-026 §9.2.1 / #338 PR2 — list_host_supervisors. // Surfaces host_supervisor daemons in the caller's network with // online flag + declared capabilities. Replaces the prior `node_daemon_` // prefix heuristic (dashboard /api/anet/node-create) + the role-extract // path on /api/nodes (#337). Member脱敏 strips host_telemetry IP / // cpu / mem (per RFC-026 §6 #3 — daemons can leak internal topology // to non-admin readers). Revoked daemon ntoks filtered out via // join on api_tokens.revoked_at. server.tool( "list_host_supervisors", "List host_supervisor daemon nodes in the caller's network (online status + runtimes_supported + allowed_secret_keys + telemetry; member-脱敏). RFC-026 §9.2.1.", { network_id: z.string().max(200).optional(), }, async ({ network_id: clientNetId }) => { // SEC-1 — use resolveReadScope, NOT getNetworkId. getNetworkId is // for write-tool helpers and pairs with `canWrite`; READ tools that // bypass canWrite and trust getNetworkId leak across tenants // (PR2 v1 BLOCKER per 通信龙 audit — utok_ caller with // enforceNetworkId=null could pass any network_id and read daemon // names + allowed_secret_keys for tenants they're not a member of). // resolveReadScope checks network_members for the user + denies // on non-membership, mirroring REST resolveRestNetworkScope. const readScope = resolveReadScope(clientNetId); if (readScope.denied) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: readScope.denied }) }] }; } // Caller role for 脱敏 decision (admin/owner = full, others = masked). // Use the resolved scope's networkId (the verified one), not the // unchecked clientNetId. const scopedNetId = readScope.networkId ?? null; const callerRole = enforceUserId && scopedNetId ? getUserNetworkRole(enforceUserId, scopedNetId) : null; // Network-bound tokens get full telemetry within their bound network // (already gate-locked by enforceNetworkId path of resolveReadScope). const isPrivileged = callerRole === "admin" || callerRole === "owner" || (!enforceUserId); // Pull candidate daemons. Active-token EXISTS subquery handles BOTH // revoked daemon ntoks (revoked_at set) AND DELETEd token rows // (the standard revokeToken path deletes the row, not flagging // revoked_at — PR2 v1 SHOULD-FIX per 通信龙 audit). EXISTS naturally // dedupes if a daemon ever had multiple tokens (e.g. rotation; nit ⚪). let sql = ` SELECT n.node_id, n.alias, n.hostname, n.network_id, n.runtimes_supported, n.allowed_secret_keys, n.created_at, n.updated_at, s.last_seen_at AS session_last_seen, s.status AS session_status, s.cpu_cores AS session_cpu_cores, s.mem_total_gb AS session_mem_total_gb, s.ip AS session_ip, n.config_snapshot FROM nodes n LEFT JOIN sessions s ON s.alias = n.alias AND (s.network_id = n.network_id OR s.network_id IS NULL) WHERE EXISTS ( SELECT 1 FROM api_tokens t WHERE t.network_id = n.network_id AND t.name = 'node:' || n.alias AND t.revoked_at IS NULL ) `; const sqlParams: any[] = []; sql = addReadScope(sql, sqlParams, readScope, "n.network_id"); sql += ` ORDER BY n.updated_at DESC`; const rows = db.all>(sql, ...sqlParams); // Filter to role=host_supervisor (read from config_snapshot; // schema-promoted columns runtimes_supported/allowed_secret_keys // are pre-extracted but role isn't a first-class column). const nowMs = Date.now(); const ONLINE_MS = 60_000; const daemons = rows .map(r => { let snapRole: string | null = null; if (r.config_snapshot) { try { const parsed = typeof r.config_snapshot === "string" ? JSON.parse(r.config_snapshot) : r.config_snapshot; snapRole = typeof parsed?.role === "string" ? parsed.role : null; } catch { /* malformed snapshot — role stays null */ } } return { row: r, role: snapRole }; }) .filter(({ role }) => role === "host_supervisor") .map(({ row: r }) => { // online = sessions.last_seen_at within ONLINE_MS let online = false; let lastSeenAt: string | null = null; if (r.session_last_seen) { lastSeenAt = r.session_last_seen; const t = Date.parse(r.session_last_seen); if (!isNaN(t)) online = (nowMs - t) <= ONLINE_MS; } // Parse self-declare arrays (default to [] for pre-PR2 daemons) let runtimes: string[] = []; let secrets: string[] = []; try { if (r.runtimes_supported) { const parsed = JSON.parse(r.runtimes_supported); runtimes = Array.isArray(parsed) ? parsed.filter((s: unknown) => typeof s === "string") : []; } } catch { /* malformed — empty */ } try { if (r.allowed_secret_keys) { const parsed = JSON.parse(r.allowed_secret_keys); secrets = Array.isArray(parsed) ? parsed.filter((s: unknown) => typeof s === "string") : []; } } catch { /* malformed — empty */ } // host_telemetry — member脱敏 drops IP/cpu/mem const telemetry: Record = { alert_level: online ? "green" : "gray", }; if (isPrivileged) { telemetry.cpu_cores = r.session_cpu_cores ?? null; telemetry.mem_gb = r.session_mem_total_gb ?? null; telemetry.ip_internal = r.session_ip ?? null; } return { daemon_node_id: r.node_id, alias: r.alias, hostname: r.hostname, online, last_seen_at: lastSeenAt, runtimes_supported: runtimes, allowed_secret_keys: secrets, host_telemetry: telemetry, }; }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, daemons, count: daemons.length }) }] }; }, ); // §2.5 step 1+2 — dashboard-facing tool. Validates spec, mint // child-ntok, stash env_blob in pendingEnvBlobs Map, write request // row (metadata only — no env_blob in SQL), pushEvent doorbell. server.tool( "create_node", "Create a node on a host-daemon and start it. Daemon forks `anet node create + start` on the target machine; child reports back to hub. RFC-026.", { daemon_node_id: z.string().min(1).max(200), node_spec: z.object({ name: z.string().min(1).max(64), runtime: z.string().min(1).max(64), model: z.string().min(1).max(100), flags: z.record(z.unknown()).optional(), env_refs: z.array(z.string().max(64)).optional(), channels: z.array(z.unknown()).optional(), }), network_id: z.string().max(200).optional(), }, async ({ daemon_node_id, node_spec, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); // §4.1.1 — admin+ for create_node (creating a node = pulling new // resource + burning API quota, one level above edit single flag) const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerRole !== "admin" && callerRole !== "owner") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "insufficient_role_for_create_node", required_role: "admin", caller_role: callerRole }) }] }; } // Daemon must exist + must be in caller's network + must be // online with role=host_supervisor capability. const { row: daemon, sec1Ok } = resolveTargetNode(daemon_node_id, effectiveNetId); if (!daemon) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "daemon_not_found", daemon_node_id }) }] }; } if (!sec1Ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_node" }) }] }; } // Read daemon's host_supervisor capability + allowlist from its // last reported config_snapshot. PR3 (#338) canonical path is // `daemon_capabilities.runtimes_supported` (RFC-026 §9.3). // Pre-PR3 daemons (preview.10 and earlier) place these at the // TOP level of the snapshot rather than nested — those reads // return undefined here and `daemonAllowedRuntimes` stays null // (permissive — no allowlist enforcement); they fall back to // §4.2.2 structural validation only, identical to pre-PR3 // behavior. No regression on in-flight daemons. let daemonAllowList = new Set(); let daemonAllowedRuntimes: string[] | null = null; try { const snap = daemon.config_snapshot ? JSON.parse(daemon.config_snapshot) : null; const caps = snap?.daemon_capabilities; if (Array.isArray(caps?.allowed_secret_keys)) { daemonAllowList = new Set(caps.allowed_secret_keys); } if (Array.isArray(caps?.runtimes_supported)) { daemonAllowedRuntimes = caps.runtimes_supported; } } catch { /* permissive fallback */ } // §4.2.2 — structural validation (catches name/runtime/model/ // flag injection at the hub edge). Daemon repeats this; double // layer per RFC §4.2.2. try { validateChildName(node_spec.name); validateRuntime(node_spec.runtime); validateModel(node_spec.model); validateChannelsP1((node_spec as any).channels); for (const [k, v] of Object.entries(node_spec.flags || {})) { if (!(FLAG_KEYS as readonly string[]).includes(k)) throw new ValidationError("flag_key_unknown", { field: k }); validateFlagValue(k, v); } } catch (e) { return validationFailReply(e); } // P1 daemon-side allowlist: if daemon publishes allowed_runtimes, // enforce at hub for fast-fail; daemon repeats. if (daemonAllowedRuntimes && !daemonAllowedRuntimes.includes(node_spec.runtime)) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "runtime_not_in_local_allowlist", runtime: node_spec.runtime, allowed: daemonAllowedRuntimes }) }] }; } // §4.4.7 — env_refs strict (7-step gate) + resolve to env_blob. let envBlob: Record = {}; const envRefs = (node_spec as any).env_refs; try { envBlob = validateEnvRefs(envRefs, { callerNetworkId: effectiveNetId || "default", daemonAllowList, networkSecretsGet: (_net: string, _key: string) => undefined, // P1: no vault yet — see note below }); } catch (e) { return validationFailReply(e); } // P1 NOTE — network_secrets vault is RFC §4.4 / §2.4 future // work. For now if dashboard sends env_refs we'll reject as // not-in-vault (above). When the vault lands, replace the // `networkSecretsGet: () => undefined` line with the real DB // lookup; nothing else in this tool needs to change. // Single-flight per (daemon, child_name): partial unique index // uniq_ncr_inflight already prevents racing INSERT, but we // surface a friendly error rather than letting the DB constraint // raise. const existing = db.get<{ request_id: string; status: string }>( `SELECT request_id, status FROM node_create_requests WHERE daemon_node_id = ?1 AND child_name = ?2 AND status IN ('pending', 'delivered') ORDER BY created_at DESC LIMIT 1`, daemon_node_id, node_spec.name, ); if (existing) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "node_name_conflict", existing_request_id: existing.request_id, existing_status: existing.status }) }] }; } // §4.2.4 — daemon_max_children backpressure (best-effort: count // currently-active children for this daemon). const maxChildren = (() => { try { const snap = daemon.config_snapshot ? JSON.parse(daemon.config_snapshot) : null; const m = snap?.daemon_capabilities?.max_concurrent_children; return (typeof m === "number" && m > 0) ? m : 20; } catch { return 20; } })(); const childCount = db.get<{ n: number }>( `SELECT COUNT(*) AS n FROM node_create_requests WHERE daemon_node_id = ?1 AND status IN ('pending', 'delivered', 'succeeded')`, daemon_node_id, )?.n || 0; if (childCount >= maxChildren) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "daemon_max_children", current: childCount, max: maxChildren }) }] }; } // §2.5 step 2 + §4.4 F1 — mint child-ntok + stash env_blob in // Map (NOT in DB). Token row marked role='child' + request_id // for sweeper traceability per §4.4.8 impl note. const childToken = generateNetworkToken(); const childTokenId = generateId("tok"); const networkIdForChild = daemon.network_id || effectiveNetId || "default"; const requestId = newRequestId(); // Use the dashboard caller's user_id as the token's user_id so // resolveToken returns sane role / network on the child's side // (audit trail = whoever created it). if (!enforceUserId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "auth_required" }) }] }; } db.run( `INSERT INTO api_tokens (token_id, token_hash, user_id, network_id, name, scope, role, request_id) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8)`, [childTokenId, hashToken(childToken), enforceUserId, networkIdForChild, `node:${node_spec.name}`, "network", "child", requestId] ); putPendingEnvBlob({ request_id: requestId, daemon_node_id, env_blob: envBlob, child_token: childToken, child_token_id: childTokenId, }); // Write metadata-only row. env_blob field deliberately ABSENT // from the schema (see db.ts CREATE TABLE) — F1 lock. const envKeys = Object.keys(envBlob); db.run( `INSERT INTO node_create_requests (request_id, daemon_node_id, child_name, network_id, runtime, model, flags_json, env_keys, status, child_token_id, created_at, created_by_token) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, 'pending', ?9, ?10, ?11)`, [ requestId, daemon_node_id, node_spec.name, networkIdForChild, node_spec.runtime, node_spec.model, JSON.stringify(node_spec.flags || {}), JSON.stringify(envKeys), childTokenId, Date.now(), callerTokenId || "unknown", ], ); // SSE doorbell — daemon will pull via get_create_request. // Payload carries ONLY request_id (no secret); daemon current // SSE handler resolves the rest via MCP call. pushEvent(daemon.alias, { type: "create_node", request_id: requestId }, networkIdForChild); // §4.5 audit — dispatch succeeded auditCreateNode({ action: "create_node_dispatched", user_id: enforceUserId, network_id: networkIdForChild, target_id: requestId, detail: { daemon_node_id, child_name: node_spec.name, runtime: node_spec.runtime, model: node_spec.model, flag_keys: Object.keys(node_spec.flags || {}), env_keys: envKeys, }, }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, request_id: requestId }) }], }; }, ); // §2.5 step 3 — daemon-facing pull. Returns full spec + env_blob + // child_ntok in one shot. Map evicted on take (one-shot consume). // // §4.1.4 C2 token-bound daemon resolution (PR #299 BLOCKER #1, 通信牛): // We MUST resolve the caller daemon via token-bound identity, NOT // alias. alias is NOT a security boundary — two daemons with the same // alias in different networks (or attacker-named-itself-the-same) // would otherwise resolve to the wrong row. Same class as the prior // report_status cross-tenant re-home bug. // // Resolution chain: caller's ntok (callerTokenId + callerTokenIsNetwork) // → api_tokens row → joins to nodes via name='node:' AND // network_id matches → unique daemon node row scoped to caller's // network. If the ntok isn't bound to a node, or the joined node // isn't a host_supervisor, reject. server.tool( "get_create_request", "Daemon pulls a pending create-node request (called when SSE create_node doorbell arrives). RFC-026.", { request_id: z.string().min(1).max(200), }, async ({ request_id }) => { const callerDaemon = resolveCallerDaemonTokenBound(); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } const row = db.get<{ request_id: string; daemon_node_id: string; status: string; child_token_id: string | null; network_id: string }>( `SELECT request_id, daemon_node_id, status, child_token_id, network_id FROM node_create_requests WHERE request_id = ?1`, request_id, ); if (!row) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_not_found" }) }] }; // §4.1.4 — strict daemon binding by token-derived node_id. if (row.daemon_node_id !== callerDaemon.daemonNodeId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "not_your_request" }) }] }; } // Additional network-scope guard (defense in depth: row's // network_id MUST equal caller's network). if (row.network_id !== callerDaemon.networkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_request" }) }] }; } if (row.status !== "pending") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_not_pending", current_status: row.status }) }] }; } // Take env_blob from Map; this is the one-shot consume per F1. // takePendingEnvBlob ALSO checks daemon binding (belt+braces). const blob = takePendingEnvBlob(request_id, callerDaemon.daemonNodeId); if (!blob) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "env_blob_unavailable" }) }] }; } // Hydrate spec from row. const specRow = db.get<{ child_name: string; runtime: string; model: string; flags_json: string }>( `SELECT child_name, runtime, model, flags_json FROM node_create_requests WHERE request_id = ?1`, request_id, ); if (!specRow) { // Should never happen given the earlier row read. return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_vanished" }) }] }; } // Mark delivered (so sweeper distinguishes F-1 from F-2). db.run( `UPDATE node_create_requests SET status = 'delivered', delivered_at = ?1 WHERE request_id = ?2 AND status = 'pending'`, [Date.now(), request_id], ); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, request_id, node_spec: { name: specRow.child_name, runtime: specRow.runtime, model: specRow.model, flags: JSON.parse(specRow.flags_json), channels: [], }, child_token: blob.child_token, env_blob: blob.env_blob, }) }], }; }, ); // §2.5 step 4 — daemon reports outcome. Note: 'succeeded' is set // automatically by hub when the child first registers (content-match // in upsertNodeWithSec1Guard); daemon's ack here is for explicit // failures (fork crashed, etc.). Daemon should still call this on // success too — it's a useful idempotent confirmation + lets hub // record fork-side info. server.tool( "ack_create_request", "Daemon acks a create-node request (called after fork). status='started' | 'failed' | 'rejected' | 'runtime_capability_check_failed'. RFC-026 §9.3 D2.", { request_id: z.string().min(1).max(200), // RFC-026 §9.3 D2 — runtime_capability_check_failed signals the // daemon spawned the child OK but it died within FAIL_FAST_MS // (5s in agent-node v2.5.0-preview.11+), indicating a // declaration↔reality gap on this daemon's runtimes_supported. // Treated terminal like 'failed' but fires a distinct audit_log // action so dashboards can highlight "lying daemons" separately // from generic spawn failures. status: z.enum(["started", "failed", "rejected", "runtime_capability_check_failed"]), error: z.string().max(1000).optional(), child_pid: z.number().int().optional(), runtime: z.string().max(64).optional(), // populated by daemon when status=runtime_capability_check_failed }, async ({ request_id, status, error: ackError, child_pid: _pid, runtime: ackRuntime }) => { const callerDaemon = resolveCallerDaemonTokenBound(); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } const row = db.get<{ daemon_node_id: string; status: string; child_token_id: string | null; network_id: string }>( `SELECT daemon_node_id, status, child_token_id, network_id FROM node_create_requests WHERE request_id = ?1`, request_id, ); if (!row) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_not_found" }) }] }; if (row.daemon_node_id !== callerDaemon.daemonNodeId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "not_your_request" }) }] }; } if (row.network_id !== callerDaemon.networkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_request" }) }] }; } const ackedAt = Date.now(); if (status === "started") { // Don't flip to 'succeeded' here — that happens via content- // match when the child actually registers. We just stamp ack. db.run( `UPDATE node_create_requests SET acked_at = ?1 WHERE request_id = ?2 AND status IN ('delivered', 'pending')`, [ackedAt, request_id], ); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, status: "awaiting_register" }) }] }; } // failed / rejected / runtime_capability_check_failed — revoke // child-ntok + mark request terminal. if (row.child_token_id) { db.run(`UPDATE api_tokens SET revoked_at = datetime('now') WHERE token_id = ?1 AND revoked_at IS NULL`, [row.child_token_id]); } db.run( `UPDATE node_create_requests SET status = ?1, error = ?2, acked_at = ?3 WHERE request_id = ?4 AND status IN ('pending', 'delivered')`, [status, ackError || null, ackedAt, request_id], ); // RFC-026 §9.3 D2 — surface declaration↔reality gap on a // distinct audit_log action so dashboards / operators can spot // chronically-lying daemons separate from generic spawn-failed. if (status === "runtime_capability_check_failed") { auditCreateNode({ action: "daemon_capability_lied", user_id: null, network_id: row.network_id, target_id: request_id, detail: { daemon_node_id: row.daemon_node_id, runtime: ackRuntime || null, error: ackError ? ackError.slice(0, 500) : null, acked_at: ackedAt, }, }); } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, status }) }] }; }, ); // ─── RFC-027 §2 — stop/delete node lifecycle ─────────────────────── // // Two user-facing MCP tools (stop_node, delete_node) + two daemon- // facing tools (get_stop_request, ack_stop_request). State machine // per §2.3 — nodes.lifecycle_state ∈ {active, stopping, stopped, // deleting}. row-gone implies deleted. Security per §4: // §4.1 SEC-1: trust-root SQL join, not getNetworkId // §4.2 D6: delete_node refuses target.role==host_supervisor // §4.3 D4: in-flight inbox default-refuse + force+audit // §4.4 D7: daemon writes backup chmod 700, sweeper真删 // §4.5 D8: audit_log in same SQLite tx as state UPDATE // // The dispatcher logic shared by stop_node + delete_node lives in // dispatchStopOrDelete; the two tool handlers thin-wrap it with // their respective action discriminator. type DispatchAction = "stop" | "delete"; type DispatchArgs = { action: DispatchAction; child_node_id: string; daemon_node_id: string; force: boolean; grace_seconds: number; delete_config: boolean; confirm_alias?: string; }; // RFC-027 PR2 prereq — auto-resolve daemon_node_id from child_node_id. // The dashboard (and most callers of stop_node / delete_node) shouldn't // need to track the daemon→child mapping themselves; the hub has it on // node_create_requests at child creation time. Returns null when no // creation record exists (orphan node row OR pre-RFC-026 node) — caller // must then pass daemon_node_id explicitly. node_id derivation: // `node_${request_id.replace(/^cr_/,"")}` (see create-node-daemon.ts // and PR1 BLOCKER-1 fix), so we reverse it: `cr_${node_id.slice(5)}`. const resolveDaemonForChild = (child_node_id: string): string | null => { if (!child_node_id.startsWith("node_")) return null; const requestId = `cr_${child_node_id.slice(5)}`; const row = db.get<{ daemon_node_id: string }>( `SELECT daemon_node_id FROM node_create_requests WHERE request_id = ?1`, requestId, ); return row?.daemon_node_id ?? null; }; const dispatchStopOrDelete = (args: DispatchArgs, clientNetId?: string | null) => { // §4.1 — SEC-1 trust-root join: resolve target node row WITHIN the // caller's scope. resolveReadScope returns 'denied' if the caller // doesn't belong to clientNetId; for the row-existence test we // re-join with member's networks so an attacker can't probe by // node_id from a network they don't belong to. const scope = resolveReadScope(clientNetId); if (scope.denied) { return { ok: false, error: "forbidden_cross_tenant", message: scope.denied }; } const nodeQ: any[] = [args.child_node_id]; let nodeSql = `SELECT node_id, alias, network_id, lifecycle_state, config_snapshot, runtimes_supported FROM nodes WHERE node_id = ?1`; nodeSql = addReadScope(nodeSql, nodeQ, scope); const node = db.get<{ node_id: string; alias: string; network_id: string; lifecycle_state: string | null; config_snapshot: string | null; }>(nodeSql, ...nodeQ); if (!node) return { ok: false, error: "forbidden_cross_tenant", message: "node not found in your networks" }; // Caller must hold a write-capable role on the resolved network // (admin/owner/member; viewer denied). canWrite walks getUserNetworkRole. if (!canWrite(node.network_id)) { return { ok: false, error: "permission_denied", message: "viewer role cannot stop/delete nodes" }; } // §4.2 D6 — delete refuses targets whose role is host_supervisor. // Stop is allowed against any node per RFC table (host_supervisor's // stop is functionally a no-op anyway: the daemon's children_map // only tracks its child nodes, never the daemon itself). // // PR1 SF-4 (#345 review) — fail-CLOSED on role read. The first cut // parsed config_snapshot and treated parse-fail / missing-field as // role=null which slipped through the gate. A daemon row with a // corrupt snapshot would then be deletable via delete_node. Fix: // - read role via two independent paths (snapshot.role + the // indexed `runtimes_supported` column whose presence ≈ daemon) // - if EITHER path indicates host_supervisor → refuse // - if snapshot parsed but role missing AND the node has any // daemon-shape evidence (non-null runtimes_supported column, // present in any node_create_requests as daemon_node_id) → // refuse defensively. The defense-in-depth daemon-side // children_map miss is the second layer; the hub gate must // itself fail-closed when role is ambiguous. if (args.action === "delete") { let role: string | null = null; let snapshotParseFailed = false; try { const snap = node.config_snapshot ? JSON.parse(node.config_snapshot) : null; role = typeof snap?.role === "string" ? snap.role : null; } catch { snapshotParseFailed = true; } const ambiguous = snapshotParseFailed || (role == null); // Independent corroborating check: nodes flagged as daemons by // create_node dispatchers will show up as daemon_node_id in // node_create_requests. Costs one indexed query. let looksLikeDaemon = false; if (ambiguous) { const m = db.get<{ n: number }>( `SELECT COUNT(*) AS n FROM node_create_requests WHERE daemon_node_id = ?1`, node.node_id, ); if ((m?.n ?? 0) > 0) looksLikeDaemon = true; } if (role === "host_supervisor" || (ambiguous && looksLikeDaemon)) { return { ok: false, error: "cannot_delete_daemon_via_delete_node", message: snapshotParseFailed ? "node config_snapshot unreadable; node is referenced as a daemon — refuse delete defensively (use delete_daemon path)" : "host_supervisor daemons must be removed via the dedicated delete_daemon path (RFC-027.5)", }; } } // delete_node confirm_alias gate: dashboard's二次确认 input must // match the actual alias byte-for-byte. Hub rejects mismatched // input even if dashboard UI claims it's disabled. if (args.action === "delete") { if (typeof args.confirm_alias !== "string" || args.confirm_alias !== node.alias) { return { ok: false, error: "confirm_alias_mismatch", message: "confirm_alias must equal the node's alias" }; } } // Daemon must exist + be in the same network. We do NOT enforce // daemon.role==host_supervisor here: a child whose creator daemon // got demoted should still be stoppable. The daemon will refuse // with noop_not_my_child if children_map doesn't know it. // // PR1.2 e2e catch (BLOCKER): pushEvent keys SSE by clientKey ≈ // `${networkId}:${sessionName}`, and agent-node registers its SSE // connection under its ALIAS (not its node_id). The create_node // doorbell at line ~2197 correctly pushes via `daemon.alias`; // stop_node was pushing via `daemon_node_id` so every doorbell // missed every SSE client → daemon never woke up → request_id // stayed 'pending' forever → child never reaped. The 24 unit tests // in stop-delete-node.test.ts all mock pushEvent and inject the // post-doorbell handler call directly, so single-unit coverage // couldn't surface this — exactly the failure class 通信龙 said // the docker e2e gate exists to catch (BLOCKER-1 同源). Load the // alias along with node_id + network_id and dispatch to the alias. const daemon = db.get<{ node_id: string; alias: string; network_id: string }>( `SELECT node_id, alias, network_id FROM nodes WHERE node_id = ?1`, args.daemon_node_id, ); if (!daemon) return { ok: false, error: "daemon_not_found" }; if (daemon.network_id !== node.network_id) { // Cross-tenant child↔daemon mismatch shouldn't be possible in // normal flow but is a SEC-1 hardening — refuse loud. return { ok: false, error: "daemon_cross_tenant", message: "daemon and child are in different networks" }; } // State machine gate. const state = node.lifecycle_state ?? "active"; if (args.action === "stop" && state !== "active") { return { ok: false, error: state === "stopping" ? "node_already_stopping" : "node_not_active", current_state: state }; } if (args.action === "delete" && state === "deleting") { return { ok: false, error: "node_already_deleting", current_state: state }; } if (args.action === "delete" && state === "stopping") { // Can't start delete while a stop is mid-flight — race-prone. return { ok: false, error: "node_stopping_in_progress", current_state: state }; } // §4.3 D4 — in-flight inbox check. Count unacked tasks routed to // this node's alias (inbox routing uses session_name == alias). // Default refuse with the count surfaced; force=true overrides // and triggers the forced_stop_with_in_flight audit row. // SF-5 (#345 review): legacy inbox rows may have network_id=NULL // and would silently miss a network_id=?2 strict equality match. // Use COALESCE so a NULL inbox row is counted against the same // network as the target node (which is the only safe default // — pre-multi-network rows existed in single-network mode). const inFlightRow = db.get<{ n: number }>( `SELECT COUNT(*) AS n FROM inbox WHERE session_name = ?1 AND acked = 0 AND COALESCE(network_id, ?2) = ?2`, node.alias, node.network_id, ); const inFlight = inFlightRow?.n ?? 0; if (inFlight > 0 && !args.force) { return { ok: false, error: "node_busy_in_flight", in_flight_count: inFlight, hint: "set force=true to override (audit logged)" }; } // ── all gates passed; create request + transition state + push doorbell, transactionally ── const requestId = generateId("sr"); const now = Date.now(); const newState = args.action === "stop" ? "stopping" : "deleting"; // §4.5 D8 — lifecycle UPDATE + audit INSERTs + request INSERT atomic. // PR1.1: use db.transaction() (SQLiteAdapter wraps better-sqlite3's // native transaction; PgAdapter ships a real BEGIN/COMMIT/ROLLBACK // shim). Lets us drop the open-coded BEGIN/COMMIT + makes the // SF-2 failure-injection test (mock db.run throw inside callback) // reliable across both backends. try { db.transaction(() => { db.run( `INSERT INTO node_stop_requests (request_id, network_id, daemon_node_id, child_node_id, child_alias, action, delete_config, grace_seconds, force, in_flight_at_dispatch, created_by_token, status, created_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, ?11, 'pending', ?12)`, [ requestId, node.network_id, args.daemon_node_id, node.node_id, node.alias, args.action, args.delete_config ? 1 : 0, args.grace_seconds, args.force ? 1 : 0, inFlight, callerTokenId || "unknown", now, ], ); db.run( `UPDATE nodes SET lifecycle_state = ?1 WHERE node_id = ?2`, [newState, node.node_id], ); // §4.5 D8 — audit dispatch action. Uses the STRICT variant so a // failed audit INSERT propagates and triggers ROLLBACK (PR1 SF-2 // review catch — auditCreateNode's swallow-and-warn would have // committed the lifecycle UPDATE without an audit row, leaving // exactly the "deleted but no audit" window §4.5 closes). auditCreateNodeStrict({ action: args.action === "stop" ? "stop_node_dispatched" : "delete_node_dispatched", user_id: enforceUserId, network_id: node.network_id, target_id: requestId, detail: { child_node_id: node.node_id, child_alias: node.alias, daemon_node_id: args.daemon_node_id, action: args.action, force: args.force, delete_config: args.delete_config, grace_seconds: args.grace_seconds, in_flight_at_dispatch: inFlight, lifecycle_state_before: state, lifecycle_state_after: newState, ts_request: now, }, }); if (args.force && inFlight > 0) { auditCreateNodeStrict({ action: "forced_stop_with_in_flight", user_id: enforceUserId, network_id: node.network_id, target_id: requestId, detail: { in_flight_count: inFlight, child_alias: node.alias }, }); } }); // end db.transaction } catch (e: any) { return { ok: false, error: "dispatch_tx_failed", message: e?.message || String(e) }; } // SSE doorbell — daemon will pull via get_stop_request. // PR1.2 e2e fix: route by daemon.alias (see SELECT above for the // BLOCKER explanation). Mirrors create_node's pushEvent target at // line ~2197. pushEvent(daemon.alias, { type: "stop_node", request_id: requestId }, node.network_id); return { ok: true, request_id: requestId, action: args.action, lifecycle_state: newState, in_flight_at_dispatch: inFlight, }; }; server.tool( "stop_node", "Stop the agent-node child process; keep config dir intact. Reversible via restart_node. RFC-027 §2.2. daemon_node_id is auto-resolved from child_node_id when omitted (looked up in node_create_requests).", { child_node_id: z.string().min(1).max(200).regex(/^node_[a-z0-9_-]+$/), // PR2 prereq: dashboard rarely knows daemon_node_id directly. // When omitted, hub resolves from the original creation record // (node_create_requests.daemon_node_id keyed by this child). daemon_node_id: z.string().min(1).max(200).regex(/^node_[a-z0-9_-]+$/).optional(), force: z.boolean().optional().default(false), grace_seconds: z.number().int().min(5).max(60).optional().default(10), network_id: z.string().max(200).optional(), }, async ({ child_node_id, daemon_node_id, force, grace_seconds, network_id: clientNetId }) => { const resolved = daemon_node_id ?? resolveDaemonForChild(child_node_id); if (!resolved) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "daemon_not_resolvable", message: "no node_create_requests row found for this child_node_id; pass daemon_node_id explicitly", }) }] }; } const r = dispatchStopOrDelete( { action: "stop", child_node_id, daemon_node_id: resolved, force: force ?? false, grace_seconds: grace_seconds ?? 10, delete_config: false }, clientNetId, ); return { content: [{ type: "text" as const, text: JSON.stringify(r) }] }; }, ); server.tool( "delete_node", "Stop child + revoke ntok + delete hub row + (default) backup config to ~/.anet/deleted/-/ for 30d. confirm_alias must equal the node's alias. daemon_node_id is auto-resolved when omitted. RFC-027 §2.2.", { child_node_id: z.string().min(1).max(200).regex(/^node_[a-z0-9_-]+$/), daemon_node_id: z.string().min(1).max(200).regex(/^node_[a-z0-9_-]+$/).optional(), confirm_alias: z.string().min(1).max(200), force: z.boolean().optional().default(false), grace_seconds: z.number().int().min(5).max(60).optional().default(10), delete_config: z.boolean().optional().default(true), network_id: z.string().max(200).optional(), }, async ({ child_node_id, daemon_node_id, confirm_alias, force, grace_seconds, delete_config, network_id: clientNetId }) => { const resolved = daemon_node_id ?? resolveDaemonForChild(child_node_id); if (!resolved) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "daemon_not_resolvable", message: "no node_create_requests row found for this child_node_id; pass daemon_node_id explicitly", }) }] }; } const r = dispatchStopOrDelete( { action: "delete", child_node_id, daemon_node_id: resolved, force: force ?? false, grace_seconds: grace_seconds ?? 10, delete_config: delete_config ?? true, confirm_alias }, clientNetId, ); return { content: [{ type: "text" as const, text: JSON.stringify(r) }] }; }, ); server.tool( "get_stop_request", "Daemon pulls a pending stop/delete request (called when SSE stop_node doorbell arrives). RFC-027 §2.4.", { request_id: z.string().min(1).max(200), }, async ({ request_id }) => { const callerDaemon = resolveCallerDaemonTokenBound(); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } const row = db.get<{ daemon_node_id: string; status: string; network_id: string; child_node_id: string; child_alias: string; action: string; delete_config: number; grace_seconds: number; force: number; }>(`SELECT daemon_node_id, status, network_id, child_node_id, child_alias, action, delete_config, grace_seconds, force FROM node_stop_requests WHERE request_id = ?1`, request_id); if (!row) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_not_found" }) }] }; if (row.daemon_node_id !== callerDaemon.daemonNodeId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "not_your_request" }) }] }; } if (row.network_id !== callerDaemon.networkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_request" }) }] }; } // Stamp delivered_at on first pull (idempotent — only if still pending). db.run( `UPDATE node_stop_requests SET status = 'delivered', delivered_at = ?1 WHERE request_id = ?2 AND status = 'pending'`, [Date.now(), request_id], ); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, request_id, child_node_id: row.child_node_id, child_alias: row.child_alias, action: row.action, delete_config: row.delete_config === 1, grace_seconds: row.grace_seconds, force: row.force === 1, }) }] }; }, ); server.tool( "ack_stop_request", "Daemon reports stop/delete completion (or per-status failure). On 'stopped' status finalizes the lifecycle: stop→stopped + keep config; delete→DB row gone + revoke ntok. RFC-027 §2.3 + §4.5.", { request_id: z.string().min(1).max(200), status: z.enum(["stopped", "stop_failed", "noop_not_my_child"]), exit_signal: z.string().max(16).optional(), backup_path: z.string().max(500).optional(), error: z.string().max(1000).optional(), }, async ({ request_id, status, exit_signal, backup_path, error: ackError }) => { const callerDaemon = resolveCallerDaemonTokenBound(); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } const row = db.get<{ daemon_node_id: string; status: string; network_id: string; child_node_id: string; child_alias: string; action: string; in_flight_at_dispatch: number; force: number; }>(`SELECT daemon_node_id, status, network_id, child_node_id, child_alias, action, in_flight_at_dispatch, force FROM node_stop_requests WHERE request_id = ?1`, request_id); if (!row) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "request_not_found" }) }] }; if (row.daemon_node_id !== callerDaemon.daemonNodeId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "not_your_request" }) }] }; } if (row.network_id !== callerDaemon.networkId) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_request" }) }] }; } const now = Date.now(); // §4.5 D8 — lifecycle UPDATE + request UPDATE + audit INSERT // (+ DELETE for delete action) atomic via db.transaction(). // PR1.1: replaces hand-rolled BEGIN..COMMIT so PG adapter and // SQLite both get correct rollback semantics from one code path. try { db.transaction(() => { db.run( `UPDATE node_stop_requests SET status = ?1, error = ?2, exit_signal = ?3, backup_path = ?4, acked_at = ?5 WHERE request_id = ?6`, [status, ackError || null, exit_signal || null, backup_path || null, now, request_id], ); if (status === "stopped" && row.action === "stop") { db.run(`UPDATE nodes SET lifecycle_state = 'stopped' WHERE node_id = ?1`, [row.child_node_id]); auditCreateNodeStrict({ action: "stop_node_completed", user_id: null, network_id: row.network_id, target_id: request_id, detail: { child_node_id: row.child_node_id, child_alias: row.child_alias, exit_signal: exit_signal || null, ts_daemon_ack: now, lifecycle_state_after: "stopped", }, }); } else if (status === "stopped" && row.action === "delete") { // Revoke the child's ntok (name='node:') in the daemon's // network, then DELETE the nodes row. Token revoke pattern mirrors // ack_create_request's terminal path. db.run( `UPDATE api_tokens SET revoked_at = datetime('now') WHERE network_id = ?1 AND name = ?2 AND revoked_at IS NULL`, [row.network_id, `node:${row.child_alias}`], ); db.run(`DELETE FROM nodes WHERE node_id = ?1`, [row.child_node_id]); auditCreateNodeStrict({ action: "delete_node_completed", user_id: null, network_id: row.network_id, target_id: request_id, detail: { child_node_id: row.child_node_id, child_alias: row.child_alias, exit_signal: exit_signal || null, backup_path: backup_path || null, ts_daemon_ack: now, lifecycle_state_after: "deleted", }, }); } else if (status === "stop_failed") { db.run(`UPDATE nodes SET lifecycle_state = 'stop_failed' WHERE node_id = ?1`, [row.child_node_id]); // No completion audit; the failure error is on the request row. } // noop_not_my_child: leave lifecycle_state as-is; the hub-side // sweeper / next reconciliation will pick it up. Don't transition. }); } catch (e: any) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "finalize_tx_failed", message: e?.message || String(e) }) }] }; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, status }) }] }; }, ); // RFC-027 PR1.1 — list_my_children: daemon-only query. Returns the // {child_node_id, alias, lifecycle_state} tuples for nodes whose // active create-request has this daemon as daemon_node_id. Used at // daemon boot to rebuild the in-memory childrenMap (PR1 dropped // every entry on daemon restart → stop/delete silently no-op'd). // // Network-scope is the daemon's own (resolveCallerDaemonTokenBound // already binds tokenIsNetwork to a single network). No SEC-1 leak: // returns ONLY children whose request landed under this daemon's // token + network. server.tool( "list_my_children", "Daemon pulls the alias + node_id list of children it spawned (for childrenMap rebuild after restart). RFC-027 PR1.1.", {}, async () => { const callerDaemon = resolveCallerDaemonTokenBound(); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } // node_create_requests carries the canonical authoritative // child→daemon mapping (the row id IS the request, and the // child node_id derives from it deterministically via // `node_${request_id.replace(/^cr_/, "")}`). Filter to children // that completed registration (have a nodes row) so we don't // ask the daemon to pgrep for children that never came up. const rows = db.all<{ request_id: string; child_name: string; child_node_id: string; lifecycle_state: string | null }>( `SELECT ncr.request_id, ncr.child_name, ('node_' || substr(ncr.request_id, 4)) AS child_node_id, n.lifecycle_state FROM node_create_requests ncr LEFT JOIN nodes n ON n.node_id = ('node_' || substr(ncr.request_id, 4)) WHERE ncr.daemon_node_id = ?1 AND ncr.network_id = ?2 AND ncr.status IN ('succeeded', 'delivered') AND n.node_id IS NOT NULL AND COALESCE(n.lifecycle_state, 'active') NOT IN ('stopped', 'stop_failed')`, callerDaemon.daemonNodeId, callerDaemon.networkId, ); const children = rows.map(r => ({ child_node_id: r.child_node_id, alias: r.child_name, lifecycle_state: r.lifecycle_state ?? "active", })); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, count: children.length, children }) }] }; }, ); // ── RFC-028 P1 — Provider & Model Registry + connectivity probe ── // Background timers (probe GC + sweeper) idempotent; safe to call // per registerTools. startPendingProbeGcTimer(); startProbeSweeperTimer(); // Helper: zod to JSON-RPC reply for ProbeValidationError + VaultError const probeFailReply = (e: unknown) => { if (e instanceof ProbeValidationError) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: e.code, ...(e.detail || {}) }) }] }; } if (e instanceof VaultError) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: e.code, message: e.message }) }] }; } throw e; }; // §2.3.4 — upsert_network_secret (OWNER-ONLY; vault write). server.tool( "upsert_network_secret", "Write or replace a secret value in the network's vault (AES-GCM encrypted at rest). OWNER-only. RFC-028.", { key: z.string().min(1).max(64).regex(/^[A-Z][A-Z0-9_]{0,63}$/), value: z.string().min(1).max(16 * 1024), network_id: z.string().max(200).optional(), }, async ({ key, value, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerRole !== "owner") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "secret_owner_only", required_role: "owner", caller_role: callerRole }) }] }; } try { vaultUpsert(effectiveNetId || "default", key, value); auditCreateNode({ action: "create_node_dispatched", // reusing audit_log shape (provider follow-up logs) user_id: enforceUserId, network_id: effectiveNetId, target_id: null, detail: { op: "vault_upsert", key, network_id: effectiveNetId }, }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, key }) }] }; } catch (e) { return probeFailReply(e); } }, ); // §2.3.4b — list_network_secrets (key names only; viewer+). server.tool( "list_network_secrets", "List vault key NAMES (NEVER values) for a network. RFC-028.", { network_id: z.string().max(200).optional() }, async ({ network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId) && enforceUserId) { // viewer-level: allow if caller has any role in network const role = getUserNetworkRole(enforceUserId, effectiveNetId || "default"); if (!role) return writeDeniedReply(effectiveNetId, "read"); } const keys = vaultListKeys(effectiveNetId || "default"); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, keys }) }] }; }, ); // §2.3.1 — upsert_provider (admin+). server.tool( "upsert_provider", "Create or update a provider (vendor + base_url + secret_key_ref + initial models). Admin+. RFC-028.", { name: z.string().min(1).max(100), vendor: z.string().min(1).max(64), base_url: z.string().min(1).max(500), secret_key_ref: z.string().min(1).max(64), models: z.array(z.object({ model_name: z.string().min(1).max(100), display_name: z.string().max(100).optional(), context_window: z.number().int().min(0).optional(), supports_vision: z.boolean().optional(), })).optional(), network_id: z.string().max(200).optional(), }, async ({ name, vendor, base_url, secret_key_ref, models, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerRole !== "admin" && callerRole !== "owner") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "insufficient_role_for_provider", required_role: "admin", caller_role: callerRole }) }] }; } try { _validateBaseUrl(vendor, base_url); } catch (e) { return probeFailReply(e); } // Verify vault key exists (best-effort; just lists names) const vaultKeys = vaultListKeys(effectiveNetId || "default"); if (!vaultKeys.includes(secret_key_ref)) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "secret_not_in_vault", key: secret_key_ref, hint: "upsert_network_secret first" }) }] }; } const providerId = `prov_${uuidv4()}`; try { db.run( `INSERT INTO providers (provider_id, network_id, name, vendor, base_url, secret_key_ref, created_at, created_by, enabled) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, 1)`, [providerId, effectiveNetId || "default", name, vendor, base_url, secret_key_ref, Date.now(), enforceUserId || "unknown"], ); } catch (e: any) { if (/UNIQUE constraint failed/.test(e?.message || "")) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "provider_name_conflict", name }) }] }; } throw e; } const modelIds: string[] = []; if (models) { for (const m of models) { const mid = `pm_${uuidv4()}`; db.run( `INSERT INTO provider_models (model_id, provider_id, model_name, display_name, context_window, supports_vision, enabled, created_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, 1, ?7)`, [mid, providerId, m.model_name, m.display_name ?? null, m.context_window ?? null, m.supports_vision ? 1 : 0, Date.now()], ); modelIds.push(mid); } } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, provider_id: providerId, model_ids: modelIds }) }] }; }, ); // §2.3.2 — update_provider (admin+; patch semantics). RFC-028 P1.5. // Single tool for editing existing providers — patch model: name/base_url/ // models/enabled all optional, at least one required. Vendor and // secret_key_ref are IMMUTABLE via this tool (vendor change = create+delete; // secret change goes through upsert_network_secret first). network_id is // immutable (cross-tenant move forbidden). // // base_url change re-runs validateBaseUrl with vendor read from DB row // (NOT from patch) — defends against trying to widen host allowlist by // smuggling a new vendor name. zod .strict() on the wrapping object // surfaces extras as -32602 at MCP boundary (R3 lock, same as // ack_probe_request per #308 fold-in). // // Audit: every successful update writes audit_log with before/after diff // of the changed fields ONLY (no secret values — secret isn't a patch // field, no leak path). server.registerTool( "update_provider", { description: "Edit existing provider (name/base_url/models/enabled). Patch semantics — at least one field. Vendor/secret/network_id immutable. Admin+. RFC-028 P1.5.", inputSchema: z.object({ provider_id: z.string().regex(/^prov_[a-zA-Z0-9_-]+$/).max(200), network_id: z.string().max(200).optional(), patch: z.object({ name: z.string().min(1).max(100).optional(), base_url: z.string().min(1).max(500).optional(), models: z.array(z.object({ model_name: z.string().min(1).max(100), display_name: z.string().max(100).optional(), context_window: z.number().int().min(0).optional(), supports_vision: z.boolean().optional(), })).optional(), enabled: z.boolean().optional(), }).strict(), }).strict() as any, }, async (args: any) => { const { provider_id, network_id: clientNetId, patch } = args; const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerRole !== "admin" && callerRole !== "owner") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "insufficient_role_for_provider", required_role: "admin", caller_role: callerRole }) }] }; } // Empty patch — surface noop_no_changes (don't silently succeed) const patchKeys = Object.keys(patch || {}); if (patchKeys.length === 0) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "noop_no_changes", hint: "patch must include at least one of: name, base_url, models, enabled" }) }] }; } // SEC-1: row must exist within caller's network (SQL-level enforcement) const row = db.get<{ provider_id: string; vendor: string; name: string; base_url: string; enabled: number }>( `SELECT provider_id, vendor, name, base_url, enabled FROM providers WHERE provider_id = ?1 AND network_id = ?2`, provider_id, effectiveNetId || "default", ); if (!row) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "provider_not_found", provider_id }) }] }; } // base_url change → re-run validateBaseUrl with vendor from DB (not patch) if (patch.base_url !== undefined && patch.base_url !== row.base_url) { try { _validateBaseUrl(row.vendor, patch.base_url); } catch (e) { return probeFailReply(e); } } // Diff staging — collect before/after for audit (NO secret values; secret // isn't a patch field). Skip fields that didn't actually change. const diff: Record = {}; const sets: string[] = []; const params: unknown[] = []; let paramIdx = 1; if (patch.name !== undefined && patch.name !== row.name) { sets.push(`name = ?${paramIdx++}`); params.push(patch.name); diff.name = { before: row.name, after: patch.name }; } if (patch.base_url !== undefined && patch.base_url !== row.base_url) { sets.push(`base_url = ?${paramIdx++}`); params.push(patch.base_url); diff.base_url = { before: row.base_url, after: patch.base_url }; } if (patch.enabled !== undefined) { const newEnabled = patch.enabled ? 1 : 0; if (newEnabled !== row.enabled) { sets.push(`enabled = ?${paramIdx++}`); params.push(newEnabled); diff.enabled = { before: row.enabled === 1, after: patch.enabled }; } } // Replace models list (if supplied) atomically with the providers UPDATE const willReplaceModels = patch.models !== undefined; const newModelIds: string[] = []; // No-op early return (通信牛 nit): all patch fields matched the // existing row values + no models supplied → no real change to // persist. Returning here means we don't write an empty-diff // audit row (audit noise). Audit_log INSERT must only fire when // something actually changed. if (sets.length === 0 && !willReplaceModels) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, provider_id, no_changes: true, hint: "patch fields matched existing row, no-op" }) }] }; } try { db.exec("BEGIN"); if (sets.length > 0) { params.push(provider_id); try { db.run(`UPDATE providers SET ${sets.join(", ")} WHERE provider_id = ?${paramIdx}`, params); } catch (e: any) { if (/UNIQUE constraint failed/.test(e?.message || "")) { db.exec("ROLLBACK"); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "provider_name_conflict", name: patch.name }) }] }; } throw e; } } if (willReplaceModels) { db.run(`DELETE FROM provider_models WHERE provider_id = ?1`, [provider_id]); for (const m of patch.models) { const mid = `pm_${uuidv4()}`; db.run( `INSERT INTO provider_models (model_id, provider_id, model_name, display_name, context_window, supports_vision, enabled, created_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, 1, ?7)`, [mid, provider_id, m.model_name, m.display_name ?? null, m.context_window ?? null, m.supports_vision ? 1 : 0, Date.now()], ); newModelIds.push(mid); } diff.models = { before: "(prior list)", after: `${patch.models.length} models replaced` }; } db.run( `INSERT INTO audit_log (user_id, username, action, target_type, target_id, detail, network_id) VALUES (?1, ?2, 'update_provider', 'provider', ?3, ?4, ?5)`, [enforceUserId || null, callerAlias || null, provider_id, JSON.stringify({ diff, fields_changed: Object.keys(diff) }), effectiveNetId || null], ); db.exec("COMMIT"); } catch (e: any) { try { db.exec("ROLLBACK"); } catch { /* ok */ } throw e; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, provider_id, fields_changed: Object.keys(diff), models_replaced: willReplaceModels ? newModelIds.length : null, }) }] }; }, ); // §2.3.3 — list_providers (viewer+; never returns secret VALUES). server.tool( "list_providers", "List providers + models in the caller's network. Never returns secret VALUES. RFC-028.", { network_id: z.string().max(200).optional() }, async ({ network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); // viewer access: caller must be member of network (read access) if (enforceUserId) { const role = getUserNetworkRole(enforceUserId, effectiveNetId || "default"); if (!role) return writeDeniedReply(effectiveNetId, "read"); } const providers = db.all( `SELECT provider_id, name, vendor, base_url, secret_key_ref, enabled FROM providers WHERE network_id = ?1 AND enabled = 1 ORDER BY name`, effectiveNetId || "default", ); const out = providers.map(p => { const models = db.all( `SELECT model_id, model_name, display_name, context_window, supports_vision, enabled FROM provider_models WHERE provider_id = ?1 AND enabled = 1 ORDER BY model_name`, p.provider_id, ); return { ...p, in_vault: true, models }; // in_vault: true since we required it on upsert }); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, providers: out }) }] }; }, ); // §2.3.5 — probe_provider_model (admin+; dispatches to daemon). server.tool( "probe_provider_model", "Dispatch a connectivity probe to a daemon. Mints ephemeral secret blob; daemon pulls via get_probe_request. Admin+. RFC-028.", { provider_id: z.string().min(1).max(200), model_name: z.string().min(1).max(100), daemon_node_id: z.string().min(1).max(200), network_id: z.string().max(200).optional(), }, async ({ provider_id, model_name, daemon_node_id, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (!canWrite(effectiveNetId)) return writeDeniedReply(effectiveNetId, "write"); const callerRole = enforceUserId && effectiveNetId ? getUserNetworkRole(enforceUserId, effectiveNetId) : null; if (callerRole !== "admin" && callerRole !== "owner") { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "insufficient_role_for_probe", required_role: "admin", caller_role: callerRole }) }] }; } // Resolve provider + model (network-scoped). Distinguish "not found" // from "disabled" so the dashboard can render the right error // (P1.5 dashboard编辑/停用 needs this to explain why probe rejected). const provider = db.get( `SELECT provider_id, vendor, base_url, secret_key_ref, enabled FROM providers WHERE provider_id = ?1 AND network_id = ?2`, provider_id, effectiveNetId || "default", ); if (!provider) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "provider_not_found", provider_id }) }] }; if (provider.enabled !== 1) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "provider_disabled", provider_id, hint: "update_provider with enabled:true to re-enable" }) }] }; const model = db.get( `SELECT model_id, model_name FROM provider_models WHERE provider_id = ?1 AND model_name = ?2 AND enabled = 1`, provider_id, model_name, ); if (!model) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "model_not_found", model_name }) }] }; // Resolve daemon (must be in caller network) const { row: daemon, sec1Ok } = resolveTargetNode(daemon_node_id, effectiveNetId); if (!daemon) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "daemon_not_found" }) }] }; if (!sec1Ok) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "cross_network_node" }) }] }; // Vault decrypt the API key (may throw VaultError) let apiKey: string; try { const v = vaultGet(effectiveNetId || "default", provider.secret_key_ref); if (!v) return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "secret_not_in_vault", key: provider.secret_key_ref }) }] }; apiKey = v; } catch (e) { return probeFailReply(e); } // Mint probe row + stash ephemeral blob const probeId = newProbeId(); db.run( `INSERT INTO probe_results (probe_id, provider_id, model_name, daemon_node_id, network_id, status, probed_at, probed_by_user) VALUES (?1, ?2, ?3, ?4, ?5, 'pending', ?6, ?7)`, [probeId, provider_id, model_name, daemon_node_id, effectiveNetId || "default", Date.now(), enforceUserId || null], ); putPendingProbeSecret({ probe_id: probeId, daemon_node_id, provider_id, vendor: provider.vendor, base_url: provider.base_url, model_name, api_key: apiKey, network_id: effectiveNetId || "default", }); pushEvent(daemon.alias, { type: "probe_provider", probe_id: probeId }, daemon.network_id || effectiveNetId || "default"); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, probe_id: probeId }) }] }; }, ); // §2.3.6 — get_probe_results (viewer+; matrix renderer source). server.tool( "get_probe_results", "Query probe history (optionally filtered by provider/model/daemon). Used by dashboard reachability matrix. RFC-028.", { provider_id: z.string().max(200).optional(), model_name: z.string().max(100).optional(), daemon_node_id: z.string().max(200).optional(), limit: z.number().int().min(1).max(500).optional(), network_id: z.string().max(200).optional(), }, async ({ provider_id, model_name, daemon_node_id, limit, network_id: clientNetId }) => { const effectiveNetId = getNetworkId(clientNetId); if (enforceUserId) { const role = getUserNetworkRole(enforceUserId, effectiveNetId || "default"); if (!role) return writeDeniedReply(effectiveNetId, "read"); } const where: string[] = ["network_id = ?1"]; const params: any[] = [effectiveNetId || "default"]; if (provider_id) { where.push(`provider_id = ?${params.length + 1}`); params.push(provider_id); } if (model_name) { where.push(`model_name = ?${params.length + 1}`); params.push(model_name); } if (daemon_node_id) { where.push(`daemon_node_id = ?${params.length + 1}`); params.push(daemon_node_id); } const sql = `SELECT probe_id, provider_id, model_name, daemon_node_id, status, latency_ms, error_label, probed_at, raw_status_code FROM probe_results WHERE ${where.join(" AND ")} ORDER BY probed_at DESC LIMIT ${limit ?? 100}`; const rows = db.all(sql, ...params); return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, results: rows }) }] }; }, ); // §2.3.7 daemon-facing — get_probe_request. server.tool( "get_probe_request", "Daemon pulls a pending probe request (called when SSE probe_provider doorbell arrives). RFC-028.", { probe_id: z.string().min(1).max(200) }, async ({ probe_id }) => { const callerDaemon = _resolveCallerDaemonTokenBound({ callerTokenIsNetwork, callerTokenId, enforceNetworkId }); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } // takePendingProbeSecret enforces daemon binding + evicts const blob = (await import("./probe.js")).takePendingProbeSecret(probe_id, callerDaemon.daemonNodeId); if (!blob) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: "probe_request_unavailable", reason: "not_found_or_wrong_daemon_or_expired" }) }] }; } return { content: [{ type: "text" as const, text: JSON.stringify({ ok: true, probe_id: blob.probe_id, vendor: blob.vendor, base_url: blob.base_url, model_name: blob.model_name, api_key: blob.api_key, // ephemeral; daemon writes to .env.local or in-memory only }) }] }; }, ); // §2.3.8 daemon-facing — ack_probe_request (STRICT whitelist via zod). // R3 LOCK (RFC-028 v3): ack payload has EXACTLY 4 keys. We pass a // ZodObject with .strict() so the MCP SDK's validateToolInput surfaces // any extra field (e.g. an attacker smuggling `error_message` to leak a // secret) as a -32602 Invalid params error at the protocol boundary // BEFORE our handler runs. The SDK invokes z.object(shape) by default // which is strip-mode; passing a fully-constructed strict object // bypasses that and enforces unknownKeys='strict'. server.registerTool( "ack_probe_request", { description: "Daemon acks a probe. Schema is STRICT whitelist (no error_message; v3 R3 LOCK). RFC-028.", // Strict-mode ZodObject so the MCP SDK's validateToolInput surfaces // any extra field as a -32602 Invalid params error BEFORE the // handler runs. server.tool() accepts only ZodRawShape (default // strip-mode); registerTool() accepts a constructed ZodObject and // honors its unknownKeys policy. inputSchema: z.object({ probe_id: z.string().min(1).max(200), status: z.enum(["ok", "auth_fail", "quota", "rate_limit", "network_error", "timeout", "redirect_forbidden", "vendor_5xx", "other_4xx", "tls_error", "probe_resolve_unsafe_ip", "probe_target_forbidden"]), raw_status_code: z.number().int().min(100).max(599).optional(), latency_ms: z.number().int().min(0).max(60_000), }).strict() as any, }, async (args: any) => { const callerDaemon = _resolveCallerDaemonTokenBound({ callerTokenIsNetwork, callerTokenId, enforceNetworkId }); if (!callerDaemon.ok) { return { content: [{ type: "text" as const, text: JSON.stringify({ ok: false, error: callerDaemon.error }) }] }; } try { const r = finalizeProbeAck(args, { network_id: callerDaemon.networkId, daemon_node_id: callerDaemon.daemonNodeId }); return { content: [{ type: "text" as const, text: JSON.stringify(r) }] }; } catch (e) { return probeFailReply(e); } }, ); } // ──────────────────────────────────────────────────────────────────── // PR A SEC follow-up (#287 cross-tenant trust-root catch, 通信牛 // 2026-06-28) — exported so the production report_status path AND // the regression test in config-apply-sec1.test.ts exercise the SAME // code. Per 通信龙 test-quality finding: an inline-mirror test that // re-implements the gate inside the test body provides zero // protection against guard drift. By forcing both code paths through // this single helper, deleting / weakening the gate fails the test. // // Returns a discriminated outcome so callers can log/route the refused // case (production: silent skip + console.warn; tests: assertion). // ──────────────────────────────────────────────────────────────────── export interface UpsertNodeWithSec1GuardInput { node_id: string; callerNetworkId: string | null; callerUserId?: string | null; callerTokenId?: string | null; node_name?: string | null; alias?: string | null; runtime?: string | null; model?: string | null; config_path?: string | null; channels?: string | null; server?: string | null; hostname?: string | null; config_snapshot?: unknown | null; } export type UpsertNodeOutcome = | { result: "inserted" | "updated"; node_id: string } | { result: "refused"; reason: "cross_network" | "token_node_mismatch" | "owner_mismatch"; existingNet: string | null; callerNet: string | null } | { result: "skipped"; reason: "missing_node_id" }; const _norm = (x: string | null | undefined) => (x === null || x === undefined ? "default" : x); /** * A capability that changes peer delivery semantics is trusted only when the * authenticating ntok is immutably bound to the exact reported node. Legacy * alias-only tokens may still heartbeat, but cannot opt a node into #698. */ export function trustedConfigSnapshotForNode( snapshot: unknown | null | undefined, callerTokenId: string | null | undefined, nodeId: string, ): unknown | null | undefined { if (!snapshot || typeof snapshot !== "object") return snapshot; const copy = { ...(snapshot as Record) }; const token = callerTokenId ? db.get<{ bound_node_id: string | null }>( "SELECT bound_node_id FROM api_tokens WHERE token_id = ?1", callerTokenId, ) : null; if (token?.bound_node_id !== nodeId) delete copy.peer_reply_inbox_capable; return copy; } export function upsertNodeWithSec1Guard(input: UpsertNodeWithSec1GuardInput): UpsertNodeOutcome { if (!input.node_id) return { result: "skipped", reason: "missing_node_id" }; const existing = db.get<{ network_id: string | null; owner_user_id: string | null }>( "SELECT network_id, owner_user_id FROM nodes WHERE node_id = ?1", input.node_id, ); const callerNet = input.callerNetworkId; // RFC-036 — when a token was minted with a node_id binding, a heartbeat may // report only that exact node. Legacy unbound ntok rows remain compatible, // but they can never consume owner-gated schedule intents. if (input.callerTokenId) { const token = db.get<{ bound_node_id: string | null; user_id: string; network_id: string | null }>( "SELECT bound_node_id, user_id, network_id FROM api_tokens WHERE token_id = ?1", input.callerTokenId, ); if (token?.bound_node_id && token.bound_node_id !== input.node_id) { return { result: "refused", reason: "token_node_mismatch", existingNet: existing?.network_id ?? null, callerNet }; } if (token?.network_id && _norm(token.network_id) !== _norm(callerNet)) { return { result: "refused", reason: "cross_network", existingNet: existing?.network_id ?? null, callerNet }; } } if (existing?.owner_user_id && input.callerUserId !== existing.owner_user_id) { return { result: "refused", reason: "owner_mismatch", existingNet: existing.network_id, callerNet }; } // Legacy / first-write paths: row missing OR network_id NULL → claim. const isLegacy = !existing || existing.network_id === null || existing.network_id === undefined; const sec1Ok = isLegacy || _norm(existing.network_id) === _norm(callerNet); if (!sec1Ok) { console.warn( `[commhub] 🚫 report_status cross-network node upsert refused: caller-net=${callerNet ?? "default"} existing-net=${existing!.network_id} node_id=${input.node_id}`, ); return { result: "refused", reason: "cross_network", existingNet: existing!.network_id, callerNet, }; } db.run( `INSERT INTO nodes (node_id, node_name, alias, runtime, model, config_path, channels, server, hostname, network_id, updated_at) VALUES (?1, ?2, ?3, ?4, ?5, ?6, ?7, ?8, ?9, ?10, datetime('now')) ON CONFLICT(node_id) DO UPDATE SET node_name = COALESCE(?2, nodes.node_name), alias = COALESCE(?3, nodes.alias), runtime = COALESCE(?4, nodes.runtime), model = COALESCE(?5, nodes.model), config_path = COALESCE(?6, nodes.config_path), channels = COALESCE(?7, nodes.channels), server = COALESCE(?8, nodes.server), hostname = COALESCE(?9, nodes.hostname), network_id = COALESCE(?10, nodes.network_id), updated_at = datetime('now')`, [ input.node_id, input.node_name ?? input.alias ?? null, input.alias ?? null, input.runtime ?? null, input.model ?? null, input.config_path ?? null, input.channels ?? null, input.server ?? null, input.hostname ?? null, callerNet ?? null, ], ); const trustedSnapshot = trustedConfigSnapshotForNode( input.config_snapshot, input.callerTokenId, input.node_id, ); if (trustedSnapshot) { // RFC-026 §9.3 / #338 PR2+PR3 — promote daemon self-declare fields // to first-class indexable columns alongside the snapshot blob. // The snapshot stays the source of truth for non-list reads; the // columns exist so `list_host_supervisors` doesn't JSON.parse on // every call. typeof-narrow per // per team rule (typeof-narrow extracted JSON fields at the boundary) — zod narrowed but // input.config_snapshot is typed `unknown` here. // // PR3 nit ①: read from nested `daemon_capabilities.*` (canonical // per RFC §9.3 + matches existing hub create_node reads at // tools.ts:2010/2075). PR2 ate from top-level keys, which the // hub create_node path never read → max_concurrent_children // backpressure was dead config + allowlist enforcement bypassed. const snap = trustedSnapshot as Record | null; const caps = (snap?.daemon_capabilities ?? null) as Record | null; const runtimesRaw = caps?.runtimes_supported; const allowedRaw = caps?.allowed_secret_keys; const runtimesJson = Array.isArray(runtimesRaw) && runtimesRaw.every(s => typeof s === "string") ? JSON.stringify(runtimesRaw) : null; const allowedJson = Array.isArray(allowedRaw) && allowedRaw.every(s => typeof s === "string") ? JSON.stringify(allowedRaw) : null; db.run( `UPDATE nodes SET config_snapshot = ?1, runtimes_supported = ?2, allowed_secret_keys = ?3 WHERE node_id = ?4`, [JSON.stringify(trustedSnapshot), runtimesJson, allowedJson, input.node_id], ); // RFC-024 — finalize any pending/restarting update whose target // patch is now reflected in the snapshot. Closes the // restart-required-never-reaches-applied gap that 通信牛 caught: // the old child acks `restarting` + exits 75; the new child boots, // reads the new config, reports status — but never had the // update_id to call ack_config_update(applied) itself. Hub does // it on the new child's behalf by content-matching the patch // against the reported snapshot. finalizePendingMatchingUpdates(input.node_id, trustedSnapshot); } // RFC-026 §2.5 step 4 — on every register/report_status, opportunistically // close out any pending create_node request whose child_name matches // this incoming alias. Same content-match pattern as RFC-024's // finalizePendingMatchingUpdates; the new child doesn't have the // request_id, so hub does the matching on its behalf. try { finalizeCreateOnFirstRegister({ node_id: input.node_id, alias: input.alias || input.node_name || "", network_id: input.callerNetworkId ?? null, }); } catch (e: any) { // create-node finalize is best-effort — never block report_status // on it. Log + continue. console.warn(`[commhub] create-node finalize on report_status failed: ${e?.message || e}`); } return { result: existing ? "updated" : "inserted", node_id: input.node_id }; } /** * RFC-024 restart-finalize (Option A per 通信牛 final review). * * Called from `upsertNodeWithSec1Guard` after writing a fresh * `config_snapshot` for the node. For each pending/restarting update * row, parse the patch and compare every field against the snapshot. * If everything in the patch is now reflected in the live snapshot, * mark the update applied + bump `nodes.config_revision`. The new * child doesn't need to know the update_id — content-matching against * the live state IS the proof that the apply landed. * * Edge cases: * - Empty patch (apply_mode=restart_only from `restart_node` tool) → * ANY snapshot matches (the restart itself was the goal). * - Patch field absent from snapshot → not a match (snapshot * post-dates the apply only when every requested field shows up). * - Multiple concurrent pending rows → impossible by single-flight, * but defensive: finalize OLDEST first so the chain stays linear. * * Pure-ish: takes a snapshot blob (TS shape, see config-snapshot type) * and runs only db.run / db.get. No external IO. */ export function finalizePendingMatchingUpdates( nodeId: string, snapshot: any, ): { finalizedCount: number; finalizedIds: string[] } { const pending = db.all<{ update_id: string; patch_json: string; apply_mode: string; base_revision: number; }>( "SELECT update_id, patch_json, apply_mode, base_revision FROM node_config_updates WHERE node_id = ?1 AND status IN ('pending', 'restarting') ORDER BY created_at ASC", nodeId, ); if (pending.length === 0) return { finalizedCount: 0, finalizedIds: [] }; const snapModel: string | null | undefined = snapshot?.model; const snapFlags: Record = (snapshot?.flags && typeof snapshot.flags === "object") ? snapshot.flags : {}; // #260 P5 — snapshot.channels is the (sorted, bare-type) channel set // the node currently has forked. agent-node's buildConfigSnapshot // always emits it (even as []), so the "absent field" case here means // an older pre-#260-P5 agent-node — for those, don't finalize a // channels-carrying patch (would false-positive on the OTHER fields). const snapChannelsPresent = Array.isArray(snapshot?.channels); const snapChannels: string[] = snapChannelsPresent ? (snapshot.channels as unknown[]).filter((c): c is string => typeof c === "string") : []; const finalizedIds: string[] = []; for (const row of pending) { let patch: any = {}; try { patch = JSON.parse(row.patch_json); } catch { continue; } let matches = true; // restart_only / empty patch → any snapshot proves the restart // happened, finalize unconditionally. if (row.apply_mode !== "restart_only") { if (patch.model !== undefined) { if (snapModel !== patch.model) { matches = false; } } if (matches && patch.flags && typeof patch.flags === "object") { for (const [k, v] of Object.entries(patch.flags as Record)) { // Canonical-key fallback for legacy aliases. The dashboard // schema uses `budget` and `timeout`; node-side config may // also carry the older `maxBudgetUsd` / `claudeTimeoutMs` / // `codexTimeoutMs` keys. agent-node's buildConfigSnapshot // only reports the canonical key, so we just compare on `k`. if (snapFlags[k] !== v) { matches = false; break; } } } // #260 P5 — channels field content-match. Without this the // node's very first startup report_status matches (patch.flags // is `{}` for a channels-only update, so the flags loop is // trivially satisfied) and hub prematurely marks the update // applied, deleting the pending row + bumping config_revision // BEFORE the doorbell reaches the child. Codex catch on PR #411. // // Set-equality is enough because the patch side comes from // narrowChannelsPatch → already deduped + case-folded + in // EDITABLE_CHANNELS iteration order; the snapshot side comes // from buildConfigSnapshot which mirrors the same shape. if (matches && Array.isArray(patch.channels)) { if (!snapChannelsPresent) { // Pre-#260-P5 agent-node — no channels field in snapshot, // so we can't prove the apply landed. Skip finalize; hub's // F-B reaper still supersedes this eventually. matches = false; } else { const wanted = new Set(patch.channels); const have = new Set(snapChannels); if (wanted.size !== have.size) { matches = false; } else { for (const w of wanted) { if (!have.has(w)) { matches = false; break; } } } } } } if (!matches) continue; // Promote nodes.config_revision atomically with the update row. const nextRev = (db.get<{ config_revision: number }>( "SELECT config_revision FROM nodes WHERE node_id = ?1", nodeId, )?.config_revision || 0) + 1; db.run( "UPDATE node_config_updates SET status = 'applied', acked_at = ?1, new_revision = ?2 WHERE update_id = ?3 AND status IN ('pending', 'restarting')", [Date.now(), nextRev, row.update_id], ); db.run("UPDATE nodes SET config_revision = ?1 WHERE node_id = ?2", [nextRev, nodeId]); finalizedIds.push(row.update_id); console.log( `[commhub] ✓ finalize update ${row.update_id} via report_status content-match: node=${nodeId} new_revision=${nextRev} apply_mode=${row.apply_mode}`, ); } return { finalizedCount: finalizedIds.length, finalizedIds }; }