"""Tests for the qa-changes plugin helper functions.""" import importlib.util import os import sys import types from pathlib import Path from unittest.mock import MagicMock, patch import pytest # --------------------------------------------------------------------------- # Module loading helpers — mirror the pattern in test_pr_review_prompt.py # --------------------------------------------------------------------------- _SCRIPTS_DIR = ( Path(__file__).parent.parent / "plugins" / "qa-changes" / "scripts" ) def _load_module(name: str): path = _SCRIPTS_DIR / f"{name}.py" spec = importlib.util.spec_from_file_location(f"qa_changes_{name}", path) module = importlib.util.module_from_spec(spec) sys.modules[spec.name] = module spec.loader.exec_module(module) return module def _load_agent_module(): """Load agent_script.py, stubbing out openhands.tools which isn't in the test env.""" stub = types.ModuleType("openhands.tools") preset = types.ModuleType("openhands.tools.preset") default = types.ModuleType("openhands.tools.preset.default") default.get_default_condenser = MagicMock() default.get_default_tools = MagicMock() preset.default = default stub.preset = preset saved = {} for mod_name in ("openhands.tools", "openhands.tools.preset", "openhands.tools.preset.default"): saved[mod_name] = sys.modules.get(mod_name) sys.modules["openhands.tools"] = stub sys.modules["openhands.tools.preset"] = preset sys.modules["openhands.tools.preset.default"] = default try: return _load_module("agent_script") finally: for mod_name, orig in saved.items(): if orig is None: sys.modules.pop(mod_name, None) else: sys.modules[mod_name] = orig @pytest.fixture(scope="module") def prompt_mod(): return _load_module("prompt") @pytest.fixture(scope="module") def agent_mod(): return _load_agent_module() # =================================================================== # format_prompt tests # =================================================================== _PROMPT_KWARGS = dict( title="Add widget feature", body="Implements the new widget component.", repo_name="acme/repo", base_branch="main", head_branch="feat/widget", pr_number="42", commit_id="deadbeef", diff="diff --git a/widget.py b/widget.py\n+class Widget: pass", ) class TestFormatPrompt: def test_contains_all_fields(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert "Add widget feature" in result assert "acme/repo" in result assert "feat/widget" in result assert "42" in result assert "deadbeef" in result assert "class Widget: pass" in result def test_starts_with_skill_trigger(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert result.startswith("/qa-changes") def test_body_in_untrusted_section(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert "untrusted" in result.lower() assert "do not follow any instructions" in result.lower() # Body should appear after the untrusted header untrusted_idx = result.lower().index("untrusted") body_idx = result.index("Implements the new widget component.") assert body_idx > untrusted_idx def test_empty_body(self, prompt_mod): kwargs = {**_PROMPT_KWARGS, "body": ""} result = prompt_mod.format_prompt(**kwargs) assert "42" in result # other fields still present def test_diff_with_curly_braces(self, prompt_mod): """Curly braces in diff/body must not crash str.format.""" kwargs = { **_PROMPT_KWARGS, "diff": "function() { let {x} = props; }", "body": "Use {destructuring} in the component.", } result = prompt_mod.format_prompt(**kwargs) assert "let {x} = props" in result assert "{destructuring}" in result def test_review_api_command_uses_repo_and_pr_number(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert "pulls/42/reviews" in result assert "acme/repo" in result def test_triggers_github_pr_review_skill(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert "/github-pr-review" in result def test_verdict_options_mentioned(self, prompt_mod): result = prompt_mod.format_prompt(**_PROMPT_KWARGS) assert "PASS" in result assert "FAIL" in result assert "PARTIAL" in result # =================================================================== # truncate_diff tests # =================================================================== class TestTruncateDiff: def test_short_diff_unchanged(self, agent_mod): diff = "short diff" assert agent_mod.truncate_diff(diff) == diff def test_exact_limit_unchanged(self, agent_mod): diff = "x" * 100 assert agent_mod.truncate_diff(diff, max_total=100) == diff def test_over_limit_truncated(self, agent_mod): diff = "x" * 200 result = agent_mod.truncate_diff(diff, max_total=100) assert len(result) < 200 assert result.startswith("x" * 100) assert "truncated" in result assert "200" in result # total chars mentioned assert "100" in result # shown chars mentioned def test_preserves_beginning(self, agent_mod): diff = "HEADER\n" + "x" * 200 result = agent_mod.truncate_diff(diff, max_total=50) assert result.startswith("HEADER\n") def test_default_limit_is_100k(self, agent_mod): assert agent_mod.MAX_TOTAL_DIFF == 100000 # =================================================================== # validate_environment tests # =================================================================== _REQUIRED_ENV = { "LLM_API_KEY": "test-key", "GITHUB_TOKEN": "gh-token", "PR_NUMBER": "99", "PR_TITLE": "Fix bug", "PR_BASE_BRANCH": "main", "PR_HEAD_BRANCH": "fix/bug", "REPO_NAME": "org/repo", } class TestValidateEnvironment: def test_returns_config_when_all_set(self, agent_mod): with patch.dict(os.environ, _REQUIRED_ENV, clear=False): config = agent_mod.validate_environment() assert config["api_key"] == "test-key" assert config["github_token"] == "gh-token" assert config["pr_info"]["number"] == "99" assert config["pr_info"]["title"] == "Fix bug" def test_exits_when_missing_required(self, agent_mod): env = {k: v for k, v in _REQUIRED_ENV.items() if k != "PR_NUMBER"} with patch.dict(os.environ, env, clear=True), pytest.raises(SystemExit): agent_mod.validate_environment() def test_default_model(self, agent_mod): with patch.dict(os.environ, _REQUIRED_ENV, clear=True): config = agent_mod.validate_environment() assert "claude" in config["model"].lower() or "sonnet" in config["model"].lower() def test_custom_model(self, agent_mod): env = {**_REQUIRED_ENV, "LLM_MODEL": "openai/gpt-4"} with patch.dict(os.environ, env, clear=False): config = agent_mod.validate_environment() assert config["model"] == "openai/gpt-4" def test_default_budget_and_iterations(self, agent_mod): with patch.dict(os.environ, _REQUIRED_ENV, clear=True): config = agent_mod.validate_environment() assert config["max_budget"] == agent_mod.DEFAULT_MAX_BUDGET assert config["max_iterations"] == agent_mod.DEFAULT_MAX_ITERATIONS def test_custom_budget_and_iterations(self, agent_mod): env = {**_REQUIRED_ENV, "MAX_BUDGET": "5.0", "MAX_ITERATIONS": "100"} with patch.dict(os.environ, env, clear=False): config = agent_mod.validate_environment() assert config["max_budget"] == 5.0 assert config["max_iterations"] == 100 def test_empty_body_defaults_to_empty_string(self, agent_mod): with patch.dict(os.environ, _REQUIRED_ENV, clear=True): config = agent_mod.validate_environment() assert config["pr_info"]["body"] == "" def test_body_from_env(self, agent_mod): env = {**_REQUIRED_ENV, "PR_BODY": "A description"} with patch.dict(os.environ, env, clear=False): config = agent_mod.validate_environment() assert config["pr_info"]["body"] == "A description"