// luma.gl
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors

import type {Binding, CompositeShaderType, UniformValue} from '@luma.gl/core';
import type {ShaderModuleUniformValue} from '@luma.gl/shadertools';
import {isNumericArray} from '@math.gl/types';

export function isUniformValue(value: unknown): value is UniformValue {
  return isNumericArray(value) || typeof value === 'number' || typeof value === 'boolean';
}

type UniformsAndBindings = {
  bindings: Record<string, Binding>;
  uniforms: Record<string, ShaderModuleUniformValue>;
};

export function splitUniformsAndBindings(
  uniforms: Record<string, Binding | ShaderModuleUniformValue>,
  uniformTypes: Readonly<Record<string, CompositeShaderType>> = {}
): UniformsAndBindings {
  const result: UniformsAndBindings = {bindings: {}, uniforms: {}};
  Object.keys(uniforms).forEach(name => {
    const uniform = uniforms[name];
    if (Object.prototype.hasOwnProperty.call(uniformTypes, name) || isUniformValue(uniform)) {
      result.uniforms[name] = uniform as ShaderModuleUniformValue;
    } else {
      result.bindings[name] = uniform as Binding;
    }
  });

  return result;
}